From: наб <nabijaczleweli@nabijaczleweli.xyz>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: fsck exits 0 with no output (just version) when it doesn't find a type-specific fsck
Date: Thu, 8 Feb 2024 15:24:35 +0100 [thread overview]
Message-ID: <z4ddhuuxh3wquorqohlbec5m6talui6wuwuu5wy4gjw4wg6ltv@tarta.nabijaczleweli.xyz> (raw)
In-Reply-To: <20240208115549.4iucrphww74l5zna@ws.net.home>
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
On Thu, Feb 08, 2024 at 12:55:49PM +0100, Karel Zak wrote:
> On Wed, Feb 07, 2024 at 06:52:47PM +0100, наб wrote:
> > I think in -A mode it makes sense to silently ignore a lack of type-specific fsck.
> > But when explicitly requesting fsck /dev/whatever, that condition
> > should at /least/ warn (I'm assuming erroring out would be too invasive),
> > because right now fsck cleared my potentially-broken filesystem w/o checks.
> Good idea, possible improvements:
> https://github.com/util-linux/util-linux/pull/2777
Looks good, works for me.
(The warning is in slavic word order, though;
ought to be "fsck.%s not found".)
Best,
наб
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-02-08 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 17:52 fsck exits 0 with no output (just version) when it doesn't find a type-specific fsck наб
2024-02-08 11:55 ` Karel Zak
2024-02-08 14:24 ` наб [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=z4ddhuuxh3wquorqohlbec5m6talui6wuwuu5wy4gjw4wg6ltv@tarta.nabijaczleweli.xyz \
--to=nabijaczleweli@nabijaczleweli.xyz \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).