From: Florian Zimmermann <florian.zimmermann@gmail.com>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org, 927041@bugs.debian.org
Subject: Re: [PATCH] cfdisk, fix behavior after writing changes
Date: Mon, 26 Jun 2023 14:02:29 +0200 [thread overview]
Message-ID: <f4333bbc-5903-8729-5b88-04c1178fd418@gmail.com> (raw)
In-Reply-To: <20230626113052.gzluriz2qsqmjk4a@ws.net.home>
On 6/26/23 13:30, Karel Zak wrote:
> On Sun, Jun 25, 2023 at 01:31:33PM +0200, Florian Zimmermann wrote:
>> diff --git a/disk-utils/cfdisk.c b/disk-utils/cfdisk.c
>> index 2e29421d7..a05a50f3e 100644
>> --- a/disk-utils/cfdisk.c
>> +++ b/disk-utils/cfdisk.c
>> @@ -2530,6 +2530,7 @@ static int main_menu_action(struct cfdisk *cf, int key)
>> else
>> fdisk_reread_partition_table(cf->cxt);
>> info = _("The partition table has been altered.");
>> + ui_menu_goto(cf, 2); /* after writing reset
>> next action to Quit by default */
>> }
>
> It seems that 'Quit' does not have to be the second item in the menu in
> all cases. I have applied a little bit different version of the patch:
> https://github.com/util-linux/util-linux/commit/b0d4d093796c3a3776b155e4ec7e2aa7cb09677d
>
> Thanks!
Thanks, your modified patch is more generic and better indeed.
CCing debian bug folks.
Florian
prev parent reply other threads:[~2023-06-26 12:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 11:31 [PATCH] cfdisk, fix behavior after writing changes Florian Zimmermann
2023-06-26 11:30 ` Karel Zak
2023-06-26 12:02 ` Florian Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4333bbc-5903-8729-5b88-04c1178fd418@gmail.com \
--to=florian.zimmermann@gmail.com \
--cc=927041@bugs.debian.org \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).