From: "Thomas Weißschuh" <thomas@t-8ch.de>
To: Edward Chron <echron@arista.com>
Cc: util-linux@vger.kernel.org, colona@arista.com
Subject: Re: [PATCH] Add dmesg syslog interface tests for PRINTK_CALLER field
Date: Tue, 12 Dec 2023 19:46:23 +0100 [thread overview]
Message-ID: <a8f0a8e8-d09f-487a-abd4-af11461afb28@t-8ch.de> (raw)
In-Reply-To: <20231209222019.954-1-echron@arista.com>
Hi,
thanks for the tests!
On 2023-12-09 14:20:19-0800, Edward Chron wrote:
> Submission to Project: util-linux
> Open Incident: #2637 at github.com/util-linux/util-linux/issues/2637
> Component: util-linux/sys-utils
> File: dmesg.c
> Code level patch applied against: https://github.com/t-8ch/util-linux/
> and we used his local-dmesg-tests from t8ch/dmesg/tests
> as we needed the numerous improvements and fixes that Thomas has
> made to the code.
>
[..]
> Tests include syslog-printk-caller versions of all existing tests:
>
> -------------------- util-linux regression tests --------------------
>
> For development purpose only.
> Don't execute on production system!
>
> kernel: 6.6.4-200.fc39.x86_64
>
> options: --srcdir=/usr/src/util-linux/pending/util-linux/tests/.. \
> --builddir=/usr/src/util-linux/pending/util-linux/tests/..
>
> dmesg: colors ... OK
> dmesg: colors-syslog-prtk-caller ... OK
> dmesg: levels ... OK
> dmesg: levels-syslog-prtk-caller ... OK
> dmesg: decode ... OK
> dmesg: decode-syslog-prtk-caller ... OK
> dmesg: delta ... OK
> dmesg: delta-syslog-prtk-caller ... OK
> dmesg: facilities ... OK
> dmesg: facilities-syslog-prtk-caller ... OK
> dmesg: indentation ... OK
> dmesg: indent-syslog-printk-caller ... OK
> dmesg: limit ... OK
> dmesg: limit-syslog-prtk-caller ... OK
Do we need so many new testcases?
Wouldn't two tests be enough to be sure that the new logic works?
One for the syslog parsing logic and one for the /dev/kmsg one?
Thomas
prev parent reply other threads:[~2023-12-12 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 22:20 [PATCH] Add dmesg syslog interface tests for PRINTK_CALLER field Edward Chron
2023-12-12 9:43 ` Karel Zak
2023-12-12 18:46 ` Thomas Weißschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8f0a8e8-d09f-487a-abd4-af11461afb28@t-8ch.de \
--to=thomas@t-8ch.de \
--cc=colona@arista.com \
--cc=echron@arista.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).