Util-Linux Archive mirror
 help / color / mirror / Atom feed
From: Chris Webb <chris@arachsys.com>
To: util-linux@vger.kernel.org
Subject: [PATCH] unshare: fix a --map-auto error message
Date: Sun, 25 Dec 2022 16:34:37 +0000	[thread overview]
Message-ID: <Y6h7nVM0l4mAiBgw@arachsys.com> (raw)

When --map-auto is used by a user not listed in /etc/subuid, the error

  unshare: no line matching user "foo" in /etc/subuid: No error information

is emitted. Fix the stray ': No error information', correcting err() to
the intended errx().

Signed-off-by: Chris Webb <chris@arachsys.com>
---
 sys-utils/unshare.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys-utils/unshare.c b/sys-utils/unshare.c
index f5fe046a8..8313ee0a7 100644
--- a/sys-utils/unshare.c
+++ b/sys-utils/unshare.c
@@ -485,7 +485,7 @@ static struct map_range *read_subid_range(char *filename, uid_t uid)
 		return map;
 	}
 
-	err(EXIT_FAILURE, _("no line matching user \"%s\" in %s"),
+	errx(EXIT_FAILURE, _("no line matching user \"%s\" in %s"),
 	pw->pw_name, filename);
 }
 

             reply	other threads:[~2022-12-25 16:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-25 16:34 Chris Webb [this message]
2023-01-03 14:35 ` [PATCH] unshare: fix a --map-auto error message Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y6h7nVM0l4mAiBgw@arachsys.com \
    --to=chris@arachsys.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).