From: "Tom Schwindl" <schwindl@posteo.de>
To: <alison@she-devel.com>, <util-linux@vger.kernel.org>
Cc: <kzak@redhat.com>, <achaiken@aurora.tech>
Subject: Re: [PATCH 1/3] schedutils: clarify confusing mask example in taskset man page
Date: Tue, 10 Jan 2023 17:25:07 +0000 [thread overview]
Message-ID: <CPOOOY8R5JSS.1Y7ZTQL4S42BO@morphine> (raw)
In-Reply-To: <20230107194708.6878-2-alison@she-devel.com>
Hi,
On Sat Jan 7, 2023 at 8:47 PM CET, wrote:
> From: Alison Chaiken <alison@she-devel.com>
>
> Omit "0x" from a mask example which is clearly hexadecimal rather than omitting
> it from "32", which could be a decimal representation.
> ---
> schedutils/taskset.1.adoc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/schedutils/taskset.1.adoc b/schedutils/taskset.1.adoc
> index c10cc62a2..efbab08dc 100644
> --- a/schedutils/taskset.1.adoc
> +++ b/schedutils/taskset.1.adoc
> @@ -52,10 +52,10 @@ is processor #0,
> *0x00000003*::
> is processors #0 and #1,
>
> -*0xFFFFFFFF*::
> +*FFFFFFFF*::
> is processors #0 through #31,
>
> -*32*::
> +*0x32*::
> is processors #1, #4, and #5,
>
> *--cpu-list 0-2,6*::
> --
> 2.32.0
I'd keep the `0x` prefix simply for consistency reasons.
It's easy for the eye to recognize the character sequence as a number
and looks cleaner in general.
The second change, however, I think is right for the very same reason.
--
Best Regards,
Tom Schwindl
next prev parent reply other threads:[~2023-01-10 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 19:47 [PATCH 0/3] clarify the usage and behavior of the taskset command alison
2023-01-07 19:47 ` [PATCH 1/3] schedutils: clarify confusing mask example in taskset man page alison
2023-01-10 17:25 ` Tom Schwindl [this message]
2023-01-07 19:47 ` [PATCH 2/3] schedutils: clarify meaning of taskset return code alison
2023-01-07 19:47 ` [PATCH 3/3] schedutils: better illustrate the usage of cpu-lists with taskset alison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CPOOOY8R5JSS.1Y7ZTQL4S42BO@morphine \
--to=schwindl@posteo.de \
--cc=achaiken@aurora.tech \
--cc=alison@she-devel.com \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).