Util-Linux Archive mirror
 help / color / mirror / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: Parallel build failures with util-linux 2.40
Date: Wed, 15 May 2024 18:18:58 +0200	[thread overview]
Message-ID: <87eda31219.fsf@alyssa.is> (raw)
In-Reply-To: <20240515142226.oyp37o3fkajvpoal@ws.net.home>

[-- Attachment #1: Type: text/plain, Size: 1854 bytes --]

Karel Zak <kzak@redhat.com> writes:

> On Tue, May 14, 2024 at 12:01:23PM +0200, Alyssa Ross wrote:
>> Since updating from util-linux 2.39.3 to 2.40.1 in Nixpkgs, we've been
>> seeing intermittent parallel build failures like the following:
>
> What does it mean "parallel build"? make -j ?

Yeah.

>> libtool: warning(B: relinking 'pam_lastlog2.la'(B libtool: install:
>> (cd /build/util-linux-2.40.1;
>> /nix/store/306znyj77fv49kwnkpxmb0j2znqpa8bj-bash-5.2p26/bin/bash
>> "/build/util-linux-2.40.1/libtool"  --silent --tag CC --mode=relink
>> gcc -fsigned-char -fno-common -Wall -Wextra
>> -Waddress-of-packed-member -Wdiscarded-qualifiers -Wformat-security
>> -Wimplicit-function-declaration -Wmissing-declarations
>> -Wmissing-parameter-type -Wmissing-prototypes -Wnested-externs
>> -Wno-missing-field-initializers -Wold-style-definition
>> -Wpointer-arith -Wredundant-decls -Wsign-compare -Wstrict-prototypes
>> -Wtype-limits -Wuninitialized -Wunused-but-set-parameter
>> -Wunused-but-set-variable -Wunused-parameter -Wunused-result
>> -Wunused-variable -Wvla -Walloca -Werror=sequence-point
>> -I./liblastlog2/src -g -O2 -module -avoid-version -shared
>> pam_lastlog2_la_LDFLAGS +=
>
> I'm not sure, but it seems like you're being affected by an extra "+="
> in the LDFLAGS. This should be fixed by...
>
>     https://github.com/util-linux/util-linux/commit/290748729dc3edf9ea1c680c8954441a5e367a44
>     https://github.com/util-linux/util-linux/commit/597e8b246ae31366514ead6cca240a09fe5e1528
>
> Can you try your use case with the latest git tree?

Thanks for pointing these out — I've applied the patches to our build,
but since the failure only happened intermittently, I'm not going to be
able to tell if it's fixed the issue right away.  We'll just have to
wait and see, and no news will be good news.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2024-05-15 16:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-14 10:01 Parallel build failures with util-linux 2.40 Alyssa Ross
2024-05-15 14:22 ` Karel Zak
2024-05-15 16:18   ` Alyssa Ross [this message]
2024-05-18 19:54     ` Alyssa Ross
2024-05-18 20:15       ` Santiago Vila
2024-05-19  8:13         ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eda31219.fsf@alyssa.is \
    --to=hi@alyssa.is \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).