Util-Linux Archive mirror
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: наб <nabijaczleweli@nabijaczleweli.xyz>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] libfdisk: fdisk_deassign_device: only sync(2) blockdevs
Date: Mon, 15 Jan 2024 10:40:34 +0100	[thread overview]
Message-ID: <20240115094034.2anrtva3yf6hoshf@ws.net.home> (raw)
In-Reply-To: <utso6yacwbluj5pou2vwllxfb5dxmhbly5qaumlshga3o5fbgg@tarta.nabijaczleweli.xyz>

On Sat, Jan 13, 2024 at 11:35:31PM +0100, наб wrote:
> When not editing a blockdev, syncing disks provides no benefit
> (we already fsync() above), takes a long time,
> and affects unrelated caches.
> 
> BLKRRPART is similarly gated on !S_ISBLK(st_mode) in
> fdisk_reread_partition_table.

Applied, thanks!

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com


      reply	other threads:[~2024-01-15  9:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-13 22:35 [PATCH] libfdisk: fdisk_deassign_device: only sync(2) blockdevs наб
2024-01-15  9:40 ` Karel Zak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240115094034.2anrtva3yf6hoshf@ws.net.home \
    --to=kzak@redhat.com \
    --cc=nabijaczleweli@nabijaczleweli.xyz \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).