From: Masatake YAMATO <yamato@redhat.com>
To: util-linux@vger.kernel.org
Cc: glaubitz@physik.fu-berlin.de, Masatake YAMATO <yamato@redhat.com>
Subject: [PATCH] tests: (lsfd::column-xmode) ignore "rwx" mappings
Date: Tue, 14 Nov 2023 11:21:22 +0900 [thread overview]
Message-ID: <20231114022122.1292703-1-yamato@redhat.com> (raw)
This change fixes the issue about lsfd reported in
https://marc.info/?l=util-linux-ng&m=169972678725084&w=2
column-xmode test case assumes an executable file has only
one "x" mapping like:
% pmap $$ | grep ${SHELL##*/}
1292343: zsh
0000562386c1c000 92K r---- zsh
0000562386c33000 716K r-x-- zsh <<
0000562386ce6000 88K r---- zsh
0000562386cfc000 8K r---- zsh
0000562386cfe000 24K rw--- zsh
However, this assumption is wrong on Sparc64:
% pmap $$
1490470: zsh
0000010000000000 792K r-x-- zsh <<
00000100001fe000 8K r---- zsh
0000010000200000 32K rwx-- zsh <<
Two "x" mappings are found.
As a result, the original test case failed.
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
---
tests/ts/lsfd/column-xmode | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ts/lsfd/column-xmode b/tests/ts/lsfd/column-xmode
index 7fea4b0ec..dd8539837 100755
--- a/tests/ts/lsfd/column-xmode
+++ b/tests/ts/lsfd/column-xmode
@@ -82,7 +82,7 @@ ts_init_subtest "XMODE-w-bit"
wait "${MKFDS_PID}"
ts_finalize_subtest
-EXPR='(ASSOC == "mem") and (INODE == '"$INO"') and (MODE != "r--") and (MODE != "rw-")'
+EXPR='(ASSOC == "mem") and (INODE == '"$INO"') and (MODE != "r--") and (MODE != "rw-") and (MODE != "rwx")'
ts_init_subtest "MODE-x-bit"
if [ "$QEMU_USER" == "1" ]; then
ts_skip_subtest "running under qemu-user emulation"
--
2.41.0
next reply other threads:[~2023-11-14 2:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 2:21 Masatake YAMATO [this message]
2023-11-14 7:24 ` [PATCH] tests: (lsfd::column-xmode) ignore "rwx" mappings John Paul Adrian Glaubitz
2023-11-14 8:16 ` Karel Zak
2023-11-14 8:39 ` John Paul Adrian Glaubitz
2023-11-14 9:19 ` Karel Zak
2023-11-14 10:12 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231114022122.1292703-1-yamato@redhat.com \
--to=yamato@redhat.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).