From: Samuel Thibault <samuel.thibault@aquilenet.fr>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: Fix non-Linux build
Date: Mon, 18 Sep 2023 13:25:33 +0200 [thread overview]
Message-ID: <20230918112533.uafpxkcei4odkfj6@begin> (raw)
In-Reply-To: <20230918111109.2b25gk3zixqdj7zt@ws.net.home>
Karel Zak, le lun. 18 sept. 2023 13:11:09 +0200, a ecrit:
> On Sun, Sep 17, 2023 at 06:36:31PM +0200, Samuel Thibault wrote:
> > --- a/libmount/src/hooks.c
> > +++ b/libmount/src/hooks.c
> > @@ -315,9 +315,11 @@ static int call_hook(struct libmnt_context *cxt, struct hookset_hook *hook)
> > {
> > int rc = 0;
> >
> > +#if LINUX
> > if (mnt_context_is_fake(cxt))
> > DBG(CXT, ul_debugobj(cxt, " FAKE call"));
> > else
> > +#endif
> > rc = hook->func(cxt, hook->hookset, hook->data);
>
> It seems better to not use libmount/src/hooks.c on non-Linux systems.
> Fixed (but not tested:-).
That works, thanks!
Samuel
prev parent reply other threads:[~2023-09-18 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-17 16:36 Fix non-Linux build Samuel Thibault
2023-09-18 11:11 ` Karel Zak
2023-09-18 11:25 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918112533.uafpxkcei4odkfj6@begin \
--to=samuel.thibault@aquilenet.fr \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).