Util-Linux Archive mirror
 help / color / mirror / Atom feed
From: Quentin Rameau <quinq@fifth.space>
To: util-linux@vger.kernel.org
Subject: Re: mount: sshfs problem with "defaults" option after 2.39 upgrade
Date: Mon, 22 May 2023 18:56:59 +0200	[thread overview]
Message-ID: <20230522185659.486273e8.quinq@fifth.space> (raw)
In-Reply-To: <02247015-d693-4c22-96a6-d89ecad0c82e@t-8ch.de>

Hello Thomas,

> > > > On a side-note, should that flag be applied to other generic parameters
> > > > too, like user(s) for example?    
> > > 
> > > I guess they are useful for the helpers.
> > > 
> > > If the helpers were able to handle it before it should be fine.
> > > (They were passed in 2.38)
> > > 
> > > One could even argue that "defaults" should have been fine to be passed,
> > > but now it's a regression so needs to be fixed.  
> > 
> > One difference that I can see is that before, "user" was being passed
> > but now, "user=$user" is being passed (and that gives an error too)
> > 
> > With mount patched with the above patch, and "user" option in the fstab
> > 
> > $ mount /mnt/ssh/path
> > fusermount3: unknown option 'user=quinq
> > 
> > But maybe that should be a different thread, what do you think?  
> 
> I can't reproduce this.
> 
> Could you provide more traces?
> 
> Or maybe try to adapt tests/ts/mount/special in the util-linux source to
> test for it. That would make it easier to reproduce and fix.

Sorry I'm just seeing your message coming home now from work,
but it seems that Karel already made a fix for it!

  reply	other threads:[~2023-05-22 16:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-21 16:18 mount: sshfs problem with "defaults" option after 2.39 upgrade Quentin Rameau
2023-05-21 18:06 ` Thomas Weißschuh
2023-05-21 18:15   ` Quentin Rameau
2023-05-21 18:58     ` Thomas Weißschuh
2023-05-21 19:20       ` Quentin Rameau
2023-05-22  6:55         ` Thomas Weißschuh
2023-05-22 16:56           ` Quentin Rameau [this message]
2023-05-22 14:21         ` Karel Zak
2023-05-22 15:33           ` Karel Zak
2023-05-22 16:55             ` Quentin Rameau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230522185659.486273e8.quinq@fifth.space \
    --to=quinq@fifth.space \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).