From: Masatake YAMATO <yamato@redhat.com>
To: bruce.dubbs@gmail.com
Cc: kzak@redhat.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, util-linux@vger.kernel.org,
renodr2002@gmail.com
Subject: Re: [ANNOUNCE] util-linux v2.39
Date: Mon, 22 May 2023 06:48:45 +0900 (JST) [thread overview]
Message-ID: <20230522.064845.1518051418018369671.yamato@redhat.com> (raw)
In-Reply-To: <ced4d4e1-8358-d718-58ee-9effe39cff6e@gmail.com>
From: Bruce Dubbs <bruce.dubbs@gmail.com>
Subject: Re: [ANNOUNCE] util-linux v2.39
Date: Sat, 20 May 2023 18:16:07 -0500
> On 5/19/23 17:56, Bruce Dubbs wrote:
>> On 5/19/23 17:43, Masatake YAMATO wrote:
>>> Bruce,
>>>
>>>> On 5/17/23 06:22, Karel Zak wrote:
>>>>> The util-linux release v2.39 is available at
>>>>> http://www.kernel.org/pub/linux/utils/util-linux/v2.39
>>>>> Feedback and bug reports, as
>>>>> always, are welcomed.
>>>>
>>>> Karel, I have installed util-linux v2.39 in LFS and have run into a
>>>> problem with one test, test_mkfds. Actually the test passes, but does
>>>> not clean up after itself. What is left over is:
>>>>
>>>> tester 32245 1 0 15:43 ? 00:00:00 /sources/util-linux-2.39/test_mkfds
>>>> -q udp 3 4 server-port=34567 client-port=23456 server-do-bind=1
>>>> client-do-bind=1 client-do-connect=1
>>>> tester 32247 1 0 15:43 ? 00:00:00 /sources/util-linux-2.39/test_mkfds
>>>> -q udp6 3 4 lite=1 server-port=34567 client-port=23456
>>>> server-do-bind=1 client-do-bind=1 client-do-connect=1
>>>>
>>>> It's possible it may be due to something we are doing inside our
>>>> chroot environment, but we've not had this type of problem with
>>>> earlier versions of util-linux.
>>>>
>>>> In all I do have:
>>>>
>>>> All 261 tests PASSED
>>>>
>>>> but the left over processes interfere later when we try to remove the
>>>> non-root user, tester, that runs the tests. I can work around the
>>>> problem by disabling test_mkfds, but thought you would like to know.
>>>
>>> Thank you for reporting.
>>> Reproduced on my PC. I found two processes were not killed properly.
>>>
>>> Could you try the following change?
>>>
>>> diff --git a/tests/ts/lsfd/option-inet b/tests/ts/lsfd/option-inet
>>> index 21e66f700..70cc3798d 100755
>>> --- a/tests/ts/lsfd/option-inet
>>> +++ b/tests/ts/lsfd/option-inet
>>> @@ -84,14 +84,10 @@ ts_cd "$TS_OUTDIR"
>>> -o ASSOC,TYPE,NAME \
>>> -Q "(PID == $PID0) or (PID == $PID1) or (PID ==
>>> $PID2) or (PID == $PID3) or (PID == $PID4)"
>>> - kill -CONT "${PID0}"
>>> - wait "${PID0}"
>>> -
>>> - kill -CONT "${PID1}"
>>> - wait "${PID1}"
>>> -
>>> - kill -CONT "${PID2}"
>>> - wait "${PID2}"
>>> + for pid in "${PID0}" "${PID1}" "${PID2}" "${PID3}" "${PID4}"; do
>>> + kill -CONT "${pid}"
>>> + wait "${pid}"
>>> + done
>>> } > "$TS_OUTPUT" 2>&1
>>> ts_finalize
>> I will do that, but will not be able to get to it until late tomorrow,
>> but will report back asap.
>
> I used the above patch and it fixed the problem. Thank you.
>
> -- Bruce
>
>
Thank you for testing.
I made a pull request based on this change:
https://github.com/util-linux/util-linux/pull/2246
Masatake YAMATO
prev parent reply other threads:[~2023-05-21 21:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 11:22 [ANNOUNCE] util-linux v2.39 Karel Zak
2023-05-17 13:48 ` Christian Brauner
2023-05-18 10:23 ` Karel Zak
2023-05-18 14:00 ` Christian Brauner
2023-05-18 23:31 ` Bruce Dubbs
2023-05-18 23:42 ` Masatake YAMATO
2023-05-19 22:43 ` Masatake YAMATO
2023-05-19 22:56 ` Bruce Dubbs
2023-05-20 23:16 ` Bruce Dubbs
2023-05-21 21:48 ` Masatake YAMATO [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522.064845.1518051418018369671.yamato@redhat.com \
--to=yamato@redhat.com \
--cc=bruce.dubbs@gmail.com \
--cc=kzak@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=renodr2002@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).