From: Karel Zak <kzak@redhat.com>
To: Thomas Haller <thaller@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 1/1] lib/randutils: drop unnecessary fcntl() in random_get_fd()
Date: Wed, 22 Feb 2023 21:46:22 +0100 [thread overview]
Message-ID: <20230222204622.6ac45lugaizc5jbt@ws.net.home> (raw)
In-Reply-To: <20230222153203.1506570-1-thaller@redhat.com>
On Wed, Feb 22, 2023 at 04:32:03PM +0100, Thomas Haller wrote:
> This was a left over from commit b1fa3e2234fa ('lib: use O_CLOEXEC in
> libcommon').
An excellent example of using sed(1) (or so) to modify code without
reading context is a bad idea.
> lib/randutils.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Applied, thanks!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2023-02-22 20:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 15:32 [PATCH 1/1] lib/randutils: drop unnecessary fcntl() in random_get_fd() Thomas Haller
2023-02-22 20:46 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222204622.6ac45lugaizc5jbt@ws.net.home \
--to=kzak@redhat.com \
--cc=thaller@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).