From: Jonas Karlman <jonas@kwiboo.se>
To: Chris Morgan <macroalpha82@gmail.com>,
Chris Morgan <macromorgan@hotmail.com>
Cc: dsimic@manjaro.org, trini@konsulko.com,
kever.yang@rock-chips.com, philipp.tomsich@vrull.eu,
sjg@chromium.org, u-boot@lists.denx.de
Subject: Re: [PATCH 2/2] board: rockchip: rgxx3: Use sdmmc0 as first device
Date: Thu, 2 May 2024 22:00:46 +0200 [thread overview]
Message-ID: <ff2f5c65-2f86-4ac5-866a-afbee5a05c98@kwiboo.se> (raw)
In-Reply-To: <20240502193410.1080938-3-macroalpha82@gmail.com>
Hi Chris,
On 2024-05-02 21:34, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Some of the rgxx3 devices do not have a way to recover from a poor
> flash of a bootloader to eMMC. Set the device to always attempt to boot
> from sdmmc0 first which ensures that we can override the boot from
> emmc if we have a card present with a valid U-Boot stage.
I would expect that after [1] was merged in v2024.07-rc1 the likelihood
of booting a bad/poor flash (where FIT checksum is invalid) have been
mitigated and the boot process now fall back to loading FIT from SD-card?
Or is it to protect against flashing a FIT containing a non working
U-Boot proper that this tries to protect against?
Also sdmmc1 seem to be missing from SPL control FDT so that could also
impact fallback logic in SPL. Following nodes should be added to
rk3566-anbernic-rgxx3-u-boot.dtsi:
&sdmmc1 {
bootph-pre-ram;
bootph-some-ram;
};
&sdmmc1_bus4 {
bootph-pre-ram;
bootph-some-ram;
};
&sdmmc1_clk {
bootph-pre-ram;
bootph-some-ram;
};
&sdmmc1_cmd {
bootph-pre-ram;
bootph-some-ram;
};
&sdmmc1_det {
bootph-pre-ram;
bootph-some-ram;
};
[1] https://source.denx.de/u-boot/u-boot/-/commit/61177bead95d366d3155722eb52db8077829579c
Regards,
Jonas
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> arch/arm/dts/rk3566-anbernic-rgxx3-u-boot.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/rk3566-anbernic-rgxx3-u-boot.dtsi b/arch/arm/dts/rk3566-anbernic-rgxx3-u-boot.dtsi
> index 793ed4ae8a..18f540a3a2 100644
> --- a/arch/arm/dts/rk3566-anbernic-rgxx3-u-boot.dtsi
> +++ b/arch/arm/dts/rk3566-anbernic-rgxx3-u-boot.dtsi
> @@ -4,7 +4,7 @@
>
> / {
> chosen {
> - u-boot,spl-boot-order = "same-as-spl", &sdmmc1, &sdmmc0;
> + u-boot,spl-boot-order = &sdmmc0, &sdmmc1, &sdhci;
> };
> };
>
next prev parent reply other threads:[~2024-05-02 20:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 19:34 [PATCH 0/2] RGXX3: Set boot order for mmc0 first Chris Morgan
2024-05-02 19:34 ` [PATCH 1/2] Revert "board: rockchip: Add early ADC button detect for RGxx3" Chris Morgan
2024-05-02 19:34 ` [PATCH 2/2] board: rockchip: rgxx3: Use sdmmc0 as first device Chris Morgan
2024-05-02 20:00 ` Jonas Karlman [this message]
2024-05-21 15:12 ` Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff2f5c65-2f86-4ac5-866a-afbee5a05c98@kwiboo.se \
--to=jonas@kwiboo.se \
--cc=dsimic@manjaro.org \
--cc=kever.yang@rock-chips.com \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).