From: Jonas Karlman <jonas@kwiboo.se>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Kever Yang <kever.yang@rock-chips.com>,
Jagan Teki <jagan@edgeble.ai>, Tim Lunn <tim@feathertop.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH v1] rockchip: rv1126: Migrate to OF_UPSTREAM
Date: Thu, 9 May 2024 19:04:39 +0200 [thread overview]
Message-ID: <f0aa181a-d154-4647-90e1-b241fdfe893e@kwiboo.se> (raw)
In-Reply-To: <CANAwSgQ_iqEFZV2ZKHNpOBTG+4+Rhza8v5b-GZEFyJdA0_U2Hw@mail.gmail.com>
Hi Anand,
On 2024-05-09 18:42, Anand Moon wrote:
> Hi Jonas
>
> On Thu, 9 May 2024 at 21:38, Jonas Karlman <jonas@kwiboo.se> wrote:
>>
>> Hi,
>>
>> On 2024-05-09 17:26, Anand Moon wrote:
>>> Migrate RV1126 boards that exists in Linux v6.8 to use OF_UPSTREAM.
>>>
>>> Following targets is not migrated to use OF_UPSTREAM:
>>
>
> Ok, will update the commit message in the future.
>
>> At first I got a little bit confused about the "not migrated", but see
>> now that these are the boards that is migrated.
>>
>>> - rv1126-edgeble-neu2 : Board is an industrial form factor
>>> IO board.
>>> - sonoff-ihost-rv1126 : Gateway device designed to provide a
>>> Smart Home Hub.
>>>
>>> Cc: Tim Lunn <tim@feathertop.org>
>>> Cc: Jagan Teki <jagan@edgeble.ai>
>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>> ---
>>> Tested on neu2 edgable board.
>>> ---
>>> arch/arm/dts/Makefile | 3 -
>>> arch/arm/dts/rv1126-edgeble-neu2-io.dts | 112 -----
>>> arch/arm/dts/rv1126-edgeble-neu2.dtsi | 345 -------------
>>> arch/arm/dts/rv1126-pinctrl.dtsi | 341 -------------
>>> arch/arm/dts/rv1126-sonoff-ihost.dts | 29 --
>>> arch/arm/dts/rv1126-sonoff-ihost.dtsi | 404 ---------------
>>> arch/arm/dts/rv1126.dtsi | 623 ------------------------
>>> arch/arm/mach-rockchip/Kconfig | 1 +
>>> configs/neu2-io-rv1126_defconfig | 2 +-
>>> configs/sonoff-ihost-rv1126_defconfig | 2 +-
>>> 10 files changed, 3 insertions(+), 1859 deletions(-)
>>> delete mode 100644 arch/arm/dts/rv1126-edgeble-neu2-io.dts
>>> delete mode 100644 arch/arm/dts/rv1126-edgeble-neu2.dtsi
>>> delete mode 100644 arch/arm/dts/rv1126-pinctrl.dtsi
>>> delete mode 100644 arch/arm/dts/rv1126-sonoff-ihost.dts
>>> delete mode 100644 arch/arm/dts/rv1126-sonoff-ihost.dtsi
>>> delete mode 100644 arch/arm/dts/rv1126.dtsi
>>
>> Following should also be removed:
>> - include/dt-bindings/clock/rockchip,rv1126-cru.h
>> - include/dt-bindings/power/rockchip,rv1126-power.h
>>
>> Side note, following is remaining after the rv1108 migration and should
>> probably also be removed:
>> - include/dt-bindings/clock/rv1108-cru.h
>>
>
> I will check if any drivers are using this if not I will remove them.
> will address this in V2.
After migration to OF_UPSTREAM any related dt-bindings include must be
removed from include/dt-bindings/ or the upstream include files cannot
be included from dts/upstream/include/dt-bindings/.
Fabio just sent a fix for rv1108-cru.h, thanks!
Please remove the two rv1126 include/dt-bindings/ files in v2.
Regards,
Jonas
>
>> Regards,
>> Jonas
>
> Thanks
> -Anand
prev parent reply other threads:[~2024-05-09 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 15:26 [PATCH v1] rockchip: rv1126: Migrate to OF_UPSTREAM Anand Moon
2024-05-09 16:08 ` Jonas Karlman
2024-05-09 16:42 ` Anand Moon
2024-05-09 17:04 ` Jonas Karlman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0aa181a-d154-4647-90e1-b241fdfe893e@kwiboo.se \
--to=jonas@kwiboo.se \
--cc=jagan@edgeble.ai \
--cc=kever.yang@rock-chips.com \
--cc=linux.amoon@gmail.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=tim@feathertop.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).