From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0B61C47096 for ; Thu, 3 Jun 2021 15:07:30 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02F426136E for ; Thu, 3 Jun 2021 15:07:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02F426136E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=prevas.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8DBF382FC9; Thu, 3 Jun 2021 17:07:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=prevas.dk header.i=@prevas.dk header.b="dUnePMXh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 166A482F47; Thu, 3 Jun 2021 17:07:25 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0724.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1f::724]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EB15582F47 for ; Thu, 3 Jun 2021 17:07:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f1Tal9JtjnSWxDEsfBgg0lmMJciV0Af/voVcyB5uVfCyjUq9Gqhm2NOu+vMNAj0oRWWhayAScaAbRjrX7okvZfVaTZZJTg9bql5guRZhsr8xBOIcU8iYOmqm/Z6/YH3En9poOCs/1jWGvNj7wxGSJHEBaICQU7EE/blqJU24kXOqe5lFWJwrHKdLP9tmlbqZicYxnlCWb51xFQW8uHIgLvUBx3jRi8qxWD4icdECRWcoiZDKlq81kVh5/UBIpmnDsqRIRtjf81LBVNgKl7hmolzgVHYtZppnRiBh3Ssuz7bEXcctA0iZP3OVAaVgN5F1nf9HzsNDrpDhJhMM1AmGvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/6Fvv/rhfaufjB/P6hRjItK36S2P08ml5ykQivywCy0=; b=UT3Ad9LoWRs+HlcJBTCDxg/S1iLcvGCOO7lZhgDBlCYECtIvVIH4bt9slbv6qd+n21a+Zak72UBbJssjq+/0MrM0ATbldaC3UorQiP+cTSuxqBw6aQmFTrxdULWJvwDHprsZ/DA7kB5PbJUOBzageDEpz56HBJXgYqStNWTGbNn7UyQjD7PirO84wunpxuCxizz/oVF37aEjZZfLk8mOiphGF+/HYMEvnDWFmmkZdtMyVk3z0VwYxJlUeLYecmyhpw1vjGjxsCXTKDRQMDLs5wXOk74/oou2Ch6FsLO/YvLzFpSlYnqJnHZVJ5m5ba36e3GG4XkZaRiKJHTX/uxxrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk; dkim=pass header.d=prevas.dk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/6Fvv/rhfaufjB/P6hRjItK36S2P08ml5ykQivywCy0=; b=dUnePMXh4ImaAGlYYQXVJmUS/DvbWWwefc2H09nkL3GexzNykuoAS4d1qcCv0pEpf5Twg4FPPrPO84DCYGBvNHPqW9MUDRKK3F6AxLn8LW8m75twJmnMybO3Mq6CbBXhVptkPrIrRrFSn7qr6ZpXH1kL3KFxYH33TlrLaA7eYeQ= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=prevas.dk; Received: from AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:3f::10) by AM0PR10MB2482.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:d5::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.21; Thu, 3 Jun 2021 15:07:20 +0000 Received: from AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM ([fe80::888d:190b:b3b5:1ad2]) by AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM ([fe80::888d:190b:b3b5:1ad2%3]) with mapi id 15.20.4173.030; Thu, 3 Jun 2021 15:07:19 +0000 Subject: Re: [PATCH 3/4] socfpga64: Do not define CONFIG_SYS_MEM_RESERVE_SECURE to 0 To: Tom Rini References: <20210518091947.63513-1-rasmus.villemoes@prevas.dk> <20210603133902.4192-1-trini@konsulko.com> <20210603133902.4192-3-trini@konsulko.com> From: Rasmus Villemoes Cc: u-boot Message-ID: Date: Thu, 3 Jun 2021 17:07:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210603133902.4192-3-trini@konsulko.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [81.216.59.226] X-ClientProxiedBy: HE1PR05CA0347.eurprd05.prod.outlook.com (2603:10a6:7:92::42) To AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:3f::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [172.17.20.80] (81.216.59.226) by HE1PR05CA0347.eurprd05.prod.outlook.com (2603:10a6:7:92::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.22 via Frontend Transport; Thu, 3 Jun 2021 15:07:19 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 59c08f36-4f05-4384-7d52-08d926a14863 X-MS-TrafficTypeDiagnostic: AM0PR10MB2482: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1850; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2ImUOFRBi+tSiXiG0n62NUE97CTPziKPmnLSxbJmdIwmuAHz0Q/5+S1LeJcMZqJ1JPZus2cUwBH5tuX/6JeVcZMuT924unt4IE6G4hefOlO6PCRXsLN1wfB5be78ObYJFXZt9PhCXS593mfA5YBfI4zJChXYwKfblr3IrTXaQ1vsBgvN+pwmwsIr1YvZJSXueYcQCwhSuIdTjKj7OVyizDI94hWpBW/mJMvUmkWTeRs+FXrufo2tK1jsGcTRbitythbnuKX8JgUxDUSkNAwDYL/Du+EiV5WaEa2DPkGP+YI5Xp5LhuUSnpDiqUjRgqJFy6whsPc2nk+VQXDKXCt3V0uYibyHR4DhZF7zUpFdqnBsEzPjEyXJGpR849MtKTQ5n3IvhyVz5lw+bgcRRnuYa+onr7JZTKSMNv4/XctUk6X9wEOVvswD5DBtLwGLsxkzFIjXQJnrRjPIsWXJbThokKsuEGc1tlG5yHQxekEtQ9SpMoj2irI5uwT4LCb5Nr+Vk6b8hGO5HsXeW0P1Wzh2y4PTQJKE+WOUe0vrgqKqXqAu0kW+7ykshIjqusnFwDrCDl8sjriMSc+LHxrmMPm5sqr6Lgv7egYofljpw/yh+6BANxIBDZ3FqYPTahcGXC8fV/whDH7Zc6o7bGpst1WRpoJl+//OQYu+Wu/RCK8fZJUQCpw74iuC1n3/tRCuljEBv52lbldqlLLrdztZH1z6RB2g6tzQWF0cwQdmjKuuAmCJE8jcMa5oLXyYt5ujbdLq/vswpUUs0LLschZ2mxMxSnQHAC7JpXNLLzIea5/kypfTXDSv4CLjr8GU6N2NChiQMukPNaqQ/6Vtns05q1YsFg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(366004)(376002)(39830400003)(136003)(396003)(346002)(31696002)(38100700002)(38350700002)(86362001)(83380400001)(6486002)(8936002)(8676002)(66946007)(66556008)(66476007)(5660300002)(4326008)(478600001)(6916009)(8976002)(4744005)(44832011)(2906002)(956004)(26005)(316002)(16576012)(31686004)(36756003)(2616005)(52116002)(16526019)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?Windows-1252?Q?kP2LZIbqhfdHkGpUuqLxxAm/xX2deyNrD2XAb1zQZZ/A402h7LPd9Y/c?= =?Windows-1252?Q?LaHdCO2OQiuA/BQdvKaVlYGe+9nnyVEkto9CNm2FAOX5yzREi0zq4vP0?= =?Windows-1252?Q?cjRAtxpgpTwp22peE7cJ+J8FPQGq+fHLsN0sNWmpYVRECPLw9kS1/byD?= =?Windows-1252?Q?p7oVNeKUhZ9Gn9pfROAFeXAp717YitQkf/pD8rJOkvAA7tRTJE0s8llo?= =?Windows-1252?Q?y4xsQ2Zjzca1TDfQI8MZJ1ulvF0rLNP4Q15oiBFTNf4tDZswKOgVBCuq?= =?Windows-1252?Q?4yIWvTdvNehnUqIuXQNjPI0cyOYJvtrbUS9uJWs4Ccxme2f8L1vni0Jx?= =?Windows-1252?Q?t7sPQ5WuO1UPIKDnRzl6IJcbJPj8BfmepjkJeanvcby0ujgFHpAns8QQ?= =?Windows-1252?Q?3x29qlV3d4quhsp/F8wKVzPSVxXezWTd922Ui5XXkbz2JIL/EoyL+Pe/?= =?Windows-1252?Q?jafuqU5HETLvV2zo2IsM3iwmjz/ghY+/DI8OC77SY9+xDiUJSf7JXO6u?= =?Windows-1252?Q?3Ar5VLskfyonGpsDVPpLWhyNhYckHx7Xi+Owk377annEstxKuvV/Falf?= =?Windows-1252?Q?XgIby73SDSHA3f7WOPVqjXNJjWd5lru+mgVQ10hxrAr9TI+iFwvg7UbQ?= =?Windows-1252?Q?uw+KQ/+J5j2Whn4u4twsK1Dd91ShyXE3lQI7bQPU2iLbI27/HhvcyO4s?= =?Windows-1252?Q?4+VjwHve0UTYylVSungrLM6eXelkVI5vkVIG2/tLY7LndxVGhZKNGEIX?= =?Windows-1252?Q?8oTPbKXCFGNWZybJu8h7B/TvgnV/CWNmyvQGy/2HYWi7rznMAdJhDvCa?= =?Windows-1252?Q?PQ5M/9emaiH4f/ZwJokiTsvyEZJk8J19quqsoJ2f3VrOSDzwnB1Eid0R?= =?Windows-1252?Q?uKFhMlokDt83aRQ+UFKksavwDL/mBu8iXX13x+YedbXvUdnGCoFjv84D?= =?Windows-1252?Q?c8VOl67Gwggq/HGQlmK6lOCslT/TDlUGhwf57ZDsrfPmpBCIt8CAkaig?= =?Windows-1252?Q?01VXYSexRLyXN5a9QIn1jVcMJ0tv1xY0Sk3KbhFBNzcES0iwd6jVwrmM?= =?Windows-1252?Q?YxR35uYNtG+lGBmsHMQrXlfrCxJXrwbhhFOpqlbnNuRxf5lGST7MCWIC?= =?Windows-1252?Q?uXgh5xIU8bTP1Mao+rO2RcUPj+faTtV6CTQsGoAIsAoxCCncoKTok1RT?= =?Windows-1252?Q?64EJiPYjSPGQ/1wzg9gL/YIGm8xqAehrxOPK83tGL3u45Et8YnD+Jjep?= =?Windows-1252?Q?knKXiMyNIttf1JsQ0maewCmvJy7ul2/0v5Lq/zC6xsf11hsoZ9N8x8RB?= =?Windows-1252?Q?uO4rrS1Wf2NigzO73/iWxtzLx+hcFZzCDFo1W7TDKzggvYDpDBKKBeiv?= =?Windows-1252?Q?J16woLwwYsR7BYyp9l0ia93LTJdFg4mKioODSFSdOgRl9yFXLOME2RBw?= X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-Network-Message-Id: 59c08f36-4f05-4384-7d52-08d926a14863 X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2021 15:07:19.6924 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HFzXgeEStcF2hl++kNjpR8/Hc9i8/Otak8F8SkdYrjX8vyhR6u2Cuo/HPbf7YZ2AC6AZ/KaYmGwU0iB/kg6jUAgjmx01kydBar54b25xsDM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB2482 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On 03/06/2021 15.39, Tom Rini wrote: > Based on the comment in socfpga_soc64_common.h, the intention is for > CONFIG_SYS_MEM_RESERVE_SECURE to be unused. However, in the code we do: > ... > > and that will evaluate to true. This leads to unwanted code being Some cleanup made lines beginning with # disappear? I can _strongly_ recommend setting commit.cleanup to scissors; I have lost count of the number of times I've had a commit message mangled and become practically useless because important lines got removed. For example became Rasmus