From: Tony Dinh <mibodhi@gmail.com>
To: Fiona Klute <fiona.klute@gmx.de>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH v2 2/2] doc: Update netconsole examples, mention stderr
Date: Thu, 16 May 2024 12:20:17 -0700 [thread overview]
Message-ID: <CAJaLiFxP91T9CvgjZxtrgqZWjvQLzAP7z4M1xbw6EwXyeRJnUQ@mail.gmail.com> (raw)
In-Reply-To: <20240516104245.2075748-2-fiona.klute@gmx.de>
Hi Fiona,
On Thu, May 16, 2024 at 3:43 AM Fiona Klute <fiona.klute@gmx.de> wrote:
>
> Stderr was missing from the initial description and example.
>
> As I understand the env command documentation the subcommand style is
> preferred, though the old format is still fully supported.
>
> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
> ---
> Changes in v2:
> * Mention stderr redirection
> * Use 4 spaces instead of tabs for code block to avoid overflowing
> lines
>
> doc/usage/netconsole.rst | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/doc/usage/netconsole.rst b/doc/usage/netconsole.rst
> index 647f0c220b..f745615d9a 100644
> --- a/doc/usage/netconsole.rst
> +++ b/doc/usage/netconsole.rst
> @@ -3,10 +3,10 @@ Network console
>
> In U-Boot, we implemented the networked console via the standard
> "devices" mechanism, which means that you can switch between the
> -serial and network input/output devices by adjusting the 'stdin' and
> -'stdout' environment variables. To switch to the networked console,
> -set either of these variables to "nc". Input and output can be
> -switched independently.
> +serial and network input/output devices by adjusting the 'stdin',
> +'stdout', and 'stderr' environment variables. To switch to the
> +networked console, set either of these variables to "nc". Input and
> +output can be switched independently.
>
> The default buffer size can be overridden by setting
> CFG_NETCONSOLE_BUFFER_SIZE.
> @@ -24,10 +24,10 @@ can be used for network console.
>
> For example, if your server IP is 192.168.1.1, you could use::
>
> - => setenv nc 'setenv stdout nc;setenv stdin nc'
> - => setenv ncip 192.168.1.1
> - => saveenv
> - => run nc
> + => env set nc 'env set stdout nc; env set stderr nc; env set stdin nc'
> + => env set ncip 192.168.1.1
> + => env save
> + => run nc
>
> On the host side, please use this script to access the console
>
> --
> 2.43.0
>
Reviewed-by: Tony Dinh <mibodhi@gmail.com>
All the best,
Tony
next prev parent reply other threads:[~2024-05-16 19:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 10:42 [PATCH v2 1/2] doc: Detailed example for netconsole setup Fiona Klute
2024-05-16 10:42 ` [PATCH v2 2/2] doc: Update netconsole examples, mention stderr Fiona Klute
2024-05-16 19:20 ` Tony Dinh [this message]
2024-05-16 19:28 ` [PATCH v2 1/2] doc: Detailed example for netconsole setup Tony Dinh
2024-05-18 11:05 ` Fiona Klute
2024-05-18 19:57 ` Tony Dinh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJaLiFxP91T9CvgjZxtrgqZWjvQLzAP7z4M1xbw6EwXyeRJnUQ@mail.gmail.com \
--to=mibodhi@gmail.com \
--cc=fiona.klute@gmx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).