From: Marek Vasut <marex@denx.de>
To: Tim Harvey <tharvey@gateworks.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Simon Glass <sjg@chromium.org>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Devarsh Thakkar <devarsht@ti.com>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
Eddie James <eajames@linux.ibm.com>,
Tom Rini <trini@konsulko.com>,
u-boot@lists.denx.de,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Michal Simek <michal.simek@amd.com>
Subject: Re: [PATCH] fdt: add kaslr-seed if DM_RNG is enabled
Date: Wed, 15 May 2024 22:05:28 +0200 [thread overview]
Message-ID: <9d4a93df-0976-44b9-9f5d-6a946aea99a2@denx.de> (raw)
In-Reply-To: <CAJ+vNU2yjkFpz4-WUDzJtwnsm4yi4mLk3HMK6J7J_Y38c6C2Sw@mail.gmail.com>
On 5/15/24 9:57 PM, Tim Harvey wrote:
[...]
>> The kaslrseed command similarly becomes obsolete with your patch and
>> should be removed. 'git grep -n CMD_KASLR' indicates which defconfigs
>> would be impacted.
>>
>
> There are several users of this command currently:
> $ git grep CMD_KASLR configs/
> configs/evb-rk3308_defconfig:CONFIG_CMD_KASLRSEED=y
These four i.MX8M I can test (and you can drop the kaslrseed command
from them, no worries).
> configs/imx8mm_data_modul_edm_sbc_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/imx8mp_data_modul_edm_sbc_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/imx8mp_dhcom_pdk2_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/imx8mp_dhcom_pdk3_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/roc-cc-rk3308_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/rock-pi-s-rk3308_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/xilinx_versal_net_virt_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/xilinx_versal_virt_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/xilinx_zynqmp_kria_defconfig:CONFIG_CMD_KASLRSEED=y
> configs/xilinx_zynqmp_virt_defconfig:CONFIG_CMD_KASLRSEED=y
>
> While I can deduplicate code by calling a shared function in that
> command I don't feel like I should remove that command until the
> maintainers of the boards above agree on removing it from their
> defconfigs as they could have bootscripts that fail with the command
> missing.
>
> I could add a warning print in the kaslrseed command indicating that
> the use of this command is no longer needed.
That sounds good to me.
next prev parent reply other threads:[~2024-05-15 20:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 0:22 [PATCH] fdt: add kaslr-seed if DM_RNG is enabled Tim Harvey
2024-05-15 0:50 ` Marek Vasut
2024-05-15 5:03 ` Heinrich Schuchardt
2024-05-15 19:57 ` Tim Harvey
2024-05-15 20:05 ` Marek Vasut [this message]
2024-05-15 16:29 ` Tim Harvey
2024-05-15 18:35 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d4a93df-0976-44b9-9f5d-6a946aea99a2@denx.de \
--to=marex@denx.de \
--cc=devarsht@ti.com \
--cc=eajames@linux.ibm.com \
--cc=hvilleneuve@dimonoff.com \
--cc=ilias.apalodimas@linaro.org \
--cc=michal.simek@amd.com \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=sjg@chromium.org \
--cc=tharvey@gateworks.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).