U-boot Archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Philip Oberfichtner <pro@denx.de>, u-boot@lists.denx.de
Cc: joe.hershberger@ni.com, rfried.dev@gmail.com, trini@konsulko.com,
	caleb.connolly@linaro.org, neil.armstrong@linaro.org,
	sumit.garg@linaro.org, sjg@chromium.org,
	philipp.tomsich@vrull.eu, kever.yang@rock-chips.com,
	patrick.delaunay@foss.st.com, patrice.chotard@foss.st.com,
	jonas@kwiboo.se, leyfoon.tan@starfivetech.com, epsi@gmx.de,
	xypron.glpk@gmx.de, seanga2@gmail.com,
	sebastien.szymanski@armadeus.com, festevam@gmail.com,
	sebastian.reichel@collabora.com, yanhong.wang@starfivetech.com,
	christophe.roullier@st.com
Subject: Re: [PATCH v2 1/1] net: dwc_eth_qos: mdio: Implement clause 45
Date: Tue, 7 May 2024 15:41:02 +0200	[thread overview]
Message-ID: <54f3cc5c-1f2d-4a7c-ab46-45aa5c40d3e4@denx.de> (raw)
In-Reply-To: <20240507094237.168238-1-pro@denx.de>

On 5/7/24 11:42 AM, Philip Oberfichtner wrote:
> Bevor this commit, only clause 22 access was possible. After this commit,
> clause 45 direct access will available as well.
> 
> Note that there is a slight change of behavior: Before this commit, the
> C45E bit was set to whatever value was left in the register from the
> previous access. After this commit, we adopt the common practice of
> discerning C45 from C22 using the devad argument.
> 
> Signed-off-by: Philip Oberfichtner <pro@denx.de>
> ---
> 
> Notes:
>      Attention: There is a slight change of behavior introduced by this
>      commit (see commit message). Please test and review if this works for
>      everybody.
>      
>      My implementation is tested on an Intel Elkhart lake SOC, patch
>      submitted here:
>      
>      https://patchwork.ozlabs.org/project/uboot/list/?series=405358
>      
>      Changes in V2:
>      	- Use FIELD_PREP() instead of manual '<<' shifting
>      	- Fix whitespace errors

Reviewed-by: Marek Vasut <marex@denx.de>

      reply	other threads:[~2024-05-07 14:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-07  9:42 [PATCH v2 1/1] net: dwc_eth_qos: mdio: Implement clause 45 Philip Oberfichtner
2024-05-07 13:41 ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54f3cc5c-1f2d-4a7c-ab46-45aa5c40d3e4@denx.de \
    --to=marex@denx.de \
    --cc=caleb.connolly@linaro.org \
    --cc=christophe.roullier@st.com \
    --cc=epsi@gmx.de \
    --cc=festevam@gmail.com \
    --cc=joe.hershberger@ni.com \
    --cc=jonas@kwiboo.se \
    --cc=kever.yang@rock-chips.com \
    --cc=leyfoon.tan@starfivetech.com \
    --cc=neil.armstrong@linaro.org \
    --cc=patrice.chotard@foss.st.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=pro@denx.de \
    --cc=rfried.dev@gmail.com \
    --cc=seanga2@gmail.com \
    --cc=sebastian.reichel@collabora.com \
    --cc=sebastien.szymanski@armadeus.com \
    --cc=sjg@chromium.org \
    --cc=sumit.garg@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    --cc=yanhong.wang@starfivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).