From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "rogerq@kernel.org" <rogerq@kernel.org>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Cc: "joe.hershberger@ni.com" <joe.hershberger@ni.com>,
"s-vadapalli@ti.com" <s-vadapalli@ti.com>,
"j-keerthy@ti.com" <j-keerthy@ti.com>,
"rfried.dev@gmail.com" <rfried.dev@gmail.com>,
"matthias.schiffer@ew.tq-group.com"
<matthias.schiffer@ew.tq-group.com>,
"grygorii.strashko@ti.com" <grygorii.strashko@ti.com>,
"nm@ti.com" <nm@ti.com>, "s-anna@ti.com" <s-anna@ti.com>
Subject: Re: [PATCH] net: ti: am65-cpsw-nuss: don't touch DMA after stop
Date: Fri, 10 May 2024 19:40:54 +0000 [thread overview]
Message-ID: <49bff29281250c0063300b8042dce43d471d9509.camel@siemens.com> (raw)
In-Reply-To: <98ffe161-33d0-479b-972e-92f9e8b8c2ff@kernel.org>
Hi Roger!
On Fri, 2024-05-10 at 12:11 +0300, Roger Quadros wrote:
> > Contrary to doc/develop/driver-model/ethernet.rst contract, eth_ops
> > .free_pkt can be called after .stop, there are several error paths in TFTP,
> > for instance:
>
> Doesn't this mean we need to fix TFTP instead of patching the Ethernet
> driver? I'm sure the issue is present for all Ethernet drivers as none
> of them are checking if Ethernet is stopped. Just that most of them
> don't print any error message so it goes unnoticed.
Thanks for looking into this, your proposal makes sense to me!
I'll rework!
Best regards,
--
Alexander Sverdlin
Siemens AG
www.siemens.com
prev parent reply other threads:[~2024-05-10 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 18:36 [PATCH] net: ti: am65-cpsw-nuss: don't touch DMA after stop A. Sverdlin
2024-05-10 9:11 ` Roger Quadros
2024-05-10 19:40 ` Sverdlin, Alexander [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49bff29281250c0063300b8042dce43d471d9509.camel@siemens.com \
--to=alexander.sverdlin@siemens.com \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=joe.hershberger@ni.com \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=nm@ti.com \
--cc=rfried.dev@gmail.com \
--cc=rogerq@kernel.org \
--cc=s-anna@ti.com \
--cc=s-vadapalli@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).