From: Tom Rini <trini@konsulko.com>
To: Bryan Brattlof <bb@ti.com>
Cc: Andrew Davis <afd@ti.com>,
u-boot@lists.denx.de, Nitin Yadav <n-yadav@ti.com>,
Dhruva Gole <d-gole@ti.com>
Subject: Re: [PATCH v3 2/2] configs: add defconfigs for the am625-lp-sk
Date: Thu, 16 May 2024 10:15:19 -0600 [thread overview]
Message-ID: <20240516161519.GC2568172@bill-the-cat> (raw)
In-Reply-To: <20240516154158.3vg7qdjmfnddrraa@bryanbrattlof.com>
[-- Attachment #1: Type: text/plain, Size: 2575 bytes --]
On Thu, May 16, 2024 at 10:41:58AM -0500, Bryan Brattlof wrote:
> On May 15, 2024 thus sayeth Andrew Davis:
> > On 5/15/24 1:21 PM, Tom Rini wrote:
> > > On Fri, May 03, 2024 at 11:44:29AM -0500, Bryan Brattlof wrote:
> > >
> > > > The am62x-lp-sk is a package and reference board spin of the am62x-sk to
> > > > showcase the low-power features of the am62x SoC family. Because it so
> > > > closely resembles the am62x-sk board, use the preprocessor to inherit
> > > > its configuration making the needed changes for this board where
> > > > necessary.
> > > >
> > > > Reviewed-by: Dhruva Gole <d-gole@ti.com>
> > > > Signed-off-by: Bryan Brattlof <bb@ti.com>
> > > > ---
> > > > configs/am62x_lp_sk_a53_defconfig | 3 +++
> > > > configs/am62x_lp_sk_r5_defconfig | 2 ++
> > > > 2 files changed, 5 insertions(+)
> > > >
> > > > diff --git a/configs/am62x_lp_sk_a53_defconfig b/configs/am62x_lp_sk_a53_defconfig
> > > > new file mode 100644
> > > > index 0000000000000..904b2142b2f53
> > > > --- /dev/null
> > > > +++ b/configs/am62x_lp_sk_a53_defconfig
> > > > @@ -0,0 +1,3 @@
> > > > +#include <configs/am62x_evm_a53_defconfig>
> > > > +CONFIG_DEFAULT_DEVICE_TREE="ti/k3-am62-lp-sk"
> > > > +CONFIG_OF_UPSTREAM=y
> > >
> > > So, there's a problem here. The #include trick for defconfig files isn't
> > > working as intended, exactly. The example here doesn't work right.
> > > First, it shows up as a variant of "sandbox" (as buildman will show and
> > > leads to https://source.denx.de/u-boot/u-boot/-/jobs/835067#L119)
> > >
> > > And this becomes clearer if you look at configs/am69_sk_r5_defconfig
> > > which has to set some symbols already found in
> > > configs/j784s4_evm_r5_defconfig in order to work. This is seemingly very
> > > not equivalent to invoking "make foo_defconfig bar.config" to combine
> > > things.
> > >
> >
> > This is equivalent when running make. The issue is with buildman which
> > manually checks the content of the defconfig to find what ARCH it should
> > run the defconfig with. buildman doesn't understand the #include yet.
> > Until buildman can be fixed, you'll need to do what we did with
> > am69_sk_r5_defconfig and redefine the ARCH/SOC/TARGET info in the
> > defconfig file so buildman can find it without following the #include.
>
> Ah Okay, I'll take a stab at the buildman fix. Also noticed in the logs
> I didn't add the configs to a MAINTAINERS entry.
Thanks. And re MAINTAINERS, I just fixed that up in-place before seeing
this bigger problem.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2024-05-16 16:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 16:44 [PATCH v3 0/2] introduce basic support for TI's am625-lp-sk Bryan Brattlof
2024-05-03 16:44 ` [PATCH v3 1/2] arm: dts: add U-Boot dtbs for the am625-lp-sk Bryan Brattlof
2024-05-03 16:44 ` [PATCH v3 2/2] configs: add defconfigs " Bryan Brattlof
2024-05-15 18:21 ` Tom Rini
2024-05-15 18:48 ` Andrew Davis
2024-05-16 15:41 ` Bryan Brattlof
2024-05-16 16:15 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240516161519.GC2568172@bill-the-cat \
--to=trini@konsulko.com \
--cc=afd@ti.com \
--cc=bb@ti.com \
--cc=d-gole@ti.com \
--cc=n-yadav@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).