From: Andre Przywara <andre.przywara@arm.com>
To: Tom Rini <trini@konsulko.com>, Jaehoon Chung <jh80.chung@samsung.com>
Cc: Jagan Teki <jagan@amarulasolutions.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Chris Morgan <macromorgan@hotmail.com>,
Ryan Walklin <ryan@testtoast.com>,
u-boot@lists.denx.de, linux-sunxi@lists.linux.dev
Subject: [PATCH 0/6] power: pmic: sunxi: consolidate AXP SPL drivers
Date: Thu, 16 May 2024 00:48:33 +0100 [thread overview]
Message-ID: <20240515234839.26898-1-andre.przywara@arm.com> (raw)
Hi,
this is the first series in an attempt to clean up the X-Powers AXP PMIC
drivers used by the SPL for sunxi boards. So far we have a separate
driver file for each AXP variant, but the code was largely the same,
just differing by the regulator ranges.
This adds a new generic driver, which reads the regulator description
from an array of structs. This is similar to how the DM AXP driver used
for U-Boot proper works, but is simplified, since we won't need the full
feature set for the SPL, and we want to keep the code size small.
To help bisect-ability, and to simplify review, each of the simpler AXP
drivers covered by this approach is handled in a separate patch.
We just convert the AXP313, AXP305, AXP717 for now, and on the way add
support for the AXP707, just because it's now very easy, and we will
need it soon enough.
The other AXP SPL drivers are more complex, and support more regulators,
but my hunch is that we really just need the DC/DC converters in the
SPL. However I need to prove and test this, so I will convert the other
AXP chips later.
Please have a look and comment whether the approach in general is a good
idea.
Cheers,
Andre
Andre Przywara (6):
power: pmic: sunxi: only build AXP drivers for SPL
power: pmic: sunxi: introduce generic SPL AXP DC/DC driver
power: pmic: sunxi: replace AXP717 SPL driver
power: pmic: sunxi: use generic AXP SPL driver for AXP313
power: pmic: sunxi: use generic AXP SPL driver for AXP305
power: pmic: sunxi: add AXP707 support
drivers/power/Makefile | 8 +-
drivers/power/axp305.c | 82 ------------------
drivers/power/axp313.c | 133 -----------------------------
drivers/power/axp717.c | 92 --------------------
drivers/power/axp_spl.c | 184 ++++++++++++++++++++++++++++++++++++++++
5 files changed, 189 insertions(+), 310 deletions(-)
delete mode 100644 drivers/power/axp305.c
delete mode 100644 drivers/power/axp313.c
delete mode 100644 drivers/power/axp717.c
create mode 100644 drivers/power/axp_spl.c
--
2.35.8
next reply other threads:[~2024-05-15 23:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 23:48 Andre Przywara [this message]
2024-05-15 23:48 ` [PATCH 1/6] power: pmic: sunxi: only build AXP drivers for SPL Andre Przywara
2024-05-15 23:48 ` [PATCH 2/6] power: pmic: sunxi: introduce generic SPL AXP DC/DC driver Andre Przywara
2024-05-15 23:48 ` [PATCH 3/6] power: pmic: sunxi: replace AXP717 SPL driver Andre Przywara
2024-05-15 23:48 ` [PATCH 4/6] power: pmic: sunxi: use generic AXP SPL driver for AXP313 Andre Przywara
2024-05-15 23:48 ` [PATCH 5/6] power: pmic: sunxi: use generic AXP SPL driver for AXP305 Andre Przywara
2024-05-15 23:48 ` [PATCH 6/6] power: pmic: sunxi: add AXP707 support Andre Przywara
2024-05-20 12:48 ` [PATCH 0/6] power: pmic: sunxi: consolidate AXP SPL drivers Peter Robinson
2024-05-20 14:18 ` Andre Przywara
2024-05-20 16:31 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515234839.26898-1-andre.przywara@arm.com \
--to=andre.przywara@arm.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=macromorgan@hotmail.com \
--cc=ryan@testtoast.com \
--cc=samuel@sholland.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).