From: Tom Rini <trini@konsulko.com>
To: Maxim Moskalets <maximmosk4@gmail.com>
Cc: sjg@chromium.org, u-boot@lists.denx.de, philipp.tomsich@vrull.eu,
kever.yang@rock-chips.com, eugen.hristev@collabora.com,
Maxim.Moskalets@kaspersky.com
Subject: Re: [PATCH] arch: fix arch-rockchip/clock.h dependency
Date: Mon, 13 May 2024 11:52:07 -0600 [thread overview]
Message-ID: <20240513175207.GG2568172@bill-the-cat> (raw)
In-Reply-To: <20240513165916.24259-1-Maxim.Moskalets@kaspersky.com>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Mon, May 13, 2024 at 07:59:16PM +0300, Maxim Moskalets wrote:
> This header uses u32 and should include header with this typedef.
>
> Signed-off-by: Maxim Moskalets <maximmosk4@gmail.com>
> ---
> arch/arm/include/asm/arch-rockchip/clock.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/include/asm/arch-rockchip/clock.h b/arch/arm/include/asm/arch-rockchip/clock.h
> index f01c5aeb71..ade53e6fd9 100644
> --- a/arch/arm/include/asm/arch-rockchip/clock.h
> +++ b/arch/arm/include/asm/arch-rockchip/clock.h
> @@ -6,6 +6,8 @@
> #ifndef _ASM_ARCH_CLOCK_H
> #define _ASM_ARCH_CLOCK_H
>
> +#include <common.h>
> +
> struct udevice;
>
> /* define pll mode */
NAK. In the -next branch, common.h has been removed. If this header
needs type information it should include <linux/types.h> directly.
Please check the next branch as well as I may have already added it
there.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2024-05-13 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 16:59 [PATCH] arch: fix arch-rockchip/clock.h dependency Maxim Moskalets
2024-05-13 17:52 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513175207.GG2568172@bill-the-cat \
--to=trini@konsulko.com \
--cc=Maxim.Moskalets@kaspersky.com \
--cc=eugen.hristev@collabora.com \
--cc=kever.yang@rock-chips.com \
--cc=maximmosk4@gmail.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).