From: Manorit Chawdhry <m-chawdhry@ti.com>
To: Neha Malcom Francis <n-francis@ti.com>
Cc: Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Alper Nebi Yasak <alpernebiyasak@gmail.com>,
<u-boot@lists.denx.de>, Nishanth Menon <nm@ti.com>,
Andrew Davis <afd@ti.com>, Udit Kumar <u-kumar1@ti.com>,
Aniket Limaye <a-limaye@ti.com>
Subject: Re: [PATCH 4/6] arch: arm: dts: k3-am68-sk-r5: Sync with J721s2 R5 file
Date: Thu, 9 May 2024 11:57:07 +0530 [thread overview]
Message-ID: <20240509062707.cgoniskfs5bm2lyp@uda0497581> (raw)
In-Reply-To: <4750f270-eddc-4597-bead-fc26fb390089@ti.com>
Hi Neha,
On 11:29-20240509, Neha Malcom Francis wrote:
> Hi Manorit
>
> On 09/05/24 11:04, Manorit Chawdhry wrote:
> > Hi Neha,
> >
> > On 10:37-20240509, Manorit Chawdhry wrote:
> > > Hi Neha,
> > >
> > > On 16:09-20240508, Neha Malcom Francis wrote:
> > > > Hi Manorit,
> > > >
> > > > On 08/05/24 12:56, Manorit Chawdhry wrote:
> > > > > Update the file with the required nodes from J721s2 R5 file to start
> > > > > using k3-am68-sk-r5 file for AM68.
> > > > >
> > > > > Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> > > > > ---
> > > >
> > > > What's the motivation behind this patch vs. squashing it into patch 5/6?
> > > >
> > >
> > > Could've squashed it ig, I think developed it in this order so this
> > > remained. Would squash it. Also realised that I should be putting that
> > > patch before the config split otherwise am68 boot would break again.
> > > Would take that up as well in v2. Thanks for the review!
> > >
> >
> > Though on second thoughts.. I think it's good as it tells that AM68 R5
> > DT had been missing some changes. If someone wants to track what changed
> > then ig it's better that they don't have to debug the merge commit which
> > ends up altering the contents of AM68 R5 DT ( in-case this patch ain't
> > there ) and people will have to manually check the diff as to what
> > altered. Do you think it's better to keep this patch with the following
> > reasoning?
> >
>
> Yes you can do that but I think this commit message is confusing. The "start
> using k3-am68-sk-r5 file for AM68" threw me off, maybe modify it to say that
> AM68 R5 DT is missing these changes and needs them why? After that grabbing
> the common bits into an SoC R5 file in patch 5/6 makes sense.
>
Ah okay, I think I can explain better "start using k3-am68-sk-r5 file"
in the commit message itself along with telling the reasoning as to why
it wasn't failing previously as well along with your suggestions.
Thanks!
Regards,
Manorit
>
> > Regards,
> > Manorit
> >
> > > Regards,
> > > Manorit
> > >
> > > > > arch/arm/dts/k3-am68-sk-r5-base-board.dts | 5 ++++-
> > > > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/arch/arm/dts/k3-am68-sk-r5-base-board.dts b/arch/arm/dts/k3-am68-sk-r5-base-board.dts
> > > > > index 695aadc287bd..038b08dc3e01 100644
> > > > > --- a/arch/arm/dts/k3-am68-sk-r5-base-board.dts
> > > > > +++ b/arch/arm/dts/k3-am68-sk-r5-base-board.dts
> > > > > @@ -24,7 +24,8 @@
> > > > > compatible = "ti,am654-rproc";
> > > > > reg = <0x0 0x00a90000 0x0 0x10>;
> > > > > power-domains = <&k3_pds 61 TI_SCI_PD_EXCLUSIVE>,
> > > > > - <&k3_pds 202 TI_SCI_PD_EXCLUSIVE>;
> > > > > + <&k3_pds 202 TI_SCI_PD_EXCLUSIVE>,
> > > > > + <&k3_pds 4 TI_SCI_PD_EXCLUSIVE>;
> > > > > resets = <&k3_reset 202 0>;
> > > > > clocks = <&k3_clks 61 1>;
> > > > > assigned-clocks = <&k3_clks 61 1>, <&k3_clks 202 0>;
> > > > > @@ -54,10 +55,12 @@
> > > > > &secure_proxy_mcu {
> > > > > bootph-pre-ram;
> > > > > + status = "okay";
> > > > > };
> > > > > &secure_proxy_sa3 {
> > > > > bootph-pre-ram;
> > > > > + status = "okay";
> > > > > };
> > > > > &cbass_mcu_wakeup {
> > > > >
> > > >
> > > > --
> > > > Thanking You
> > > > Neha Malcom Francis
>
> --
> Thanking You
> Neha Malcom Francis
next prev parent reply other threads:[~2024-05-09 6:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 7:26 [PATCH 0/6] Enable OF_UPSTREAM for j721s2 and am68 Manorit Chawdhry
2024-05-08 7:26 ` [PATCH 1/6] board: ti: j721s2: j721s2.env: Add explicit boot_targets Manorit Chawdhry
2024-05-08 7:26 ` [PATCH 2/6] configs: j721s2_evm_a72_defconfig: Switch to bootstd Manorit Chawdhry
2024-05-08 7:26 ` [PATCH 3/6] configs: am68_sk: Move to separate defconfig for AM68 SK board Manorit Chawdhry
2024-05-08 10:24 ` Neha Malcom Francis
2024-05-08 7:26 ` [PATCH 4/6] arch: arm: dts: k3-am68-sk-r5: Sync with J721s2 R5 file Manorit Chawdhry
2024-05-08 10:39 ` Neha Malcom Francis
2024-05-09 5:07 ` Manorit Chawdhry
2024-05-09 5:34 ` Manorit Chawdhry
2024-05-09 5:59 ` Neha Malcom Francis
2024-05-09 6:27 ` Manorit Chawdhry [this message]
2024-05-08 7:26 ` [PATCH 5/6] arch: arm: dts: k3-j721s2-r5: Introduce k3-j721s2-r5.dtsi Manorit Chawdhry
2024-05-08 7:26 ` [PATCH 6/6] arm: dts: k3-j721s2|am68: Migrate to OF_UPSTREAM Manorit Chawdhry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509062707.cgoniskfs5bm2lyp@uda0497581 \
--to=m-chawdhry@ti.com \
--cc=a-limaye@ti.com \
--cc=afd@ti.com \
--cc=alpernebiyasak@gmail.com \
--cc=n-francis@ti.com \
--cc=nm@ti.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).