From: Tom Rini <trini@konsulko.com>
To: "Abbarapu, Venkatesh" <venkatesh.abbarapu@amd.com>,
"jagan@amarulasolutions.com" <jagan@amarulasolutions.com>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
"Simek, Michal" <michal.simek@amd.com>,
"git (AMD-Xilinx)" <git@amd.com>
Subject: Re: [PATCH v11 0/8] spi-nor: Add parallel and stacked memories support
Date: Tue, 7 May 2024 09:48:36 -0600 [thread overview]
Message-ID: <20240507154836.GV2568172@bill-the-cat> (raw)
In-Reply-To: <SA1PR12MB8697F03FAFE69E8FE81F397598E42@SA1PR12MB8697.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 6253 bytes --]
On Tue, May 07, 2024 at 04:15:14AM +0000, Abbarapu, Venkatesh wrote:
> + Tom Rini
>
> Do you have any comments for this series?
Seems likely fine. Jagan, do you have time to put this in a PR for
-next? Thanks.
>
> Thanks
> Venkatesh
>
> > -----Original Message-----
> > From: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
> > Sent: Monday, March 4, 2024 8:41 AM
> > To: u-boot@lists.denx.de
> > Cc: Simek, Michal <michal.simek@amd.com>; jagan@amarulasolutions.com;
> > git (AMD-Xilinx) <git@amd.com>
> > Subject: [PATCH v11 0/8] spi-nor: Add parallel and stacked memories support
> >
> > This series adds support for Xilinx qspi parallel and stacked memeories.
> >
> > In parallel mode, the current implementation assumes that a maximum of
> > two flashes are connected. The QSPI controller splits the data evenly between
> > both the flashes so, both the flashes that are connected in parallel mode
> > should be identical.
> > During each operation SPI-NOR sets 0th bit for CS0 & 1st bit for CS1 in
> > nor->flags.
> >
> > In stacked mode the current implementation assumes that a maximum of two
> > flashes are connected and both the flashes are of same make but can differ in
> > sizes. So, except the sizes all other flash parameters of both the flashes are
> > identical.
> >
> > Spi-nor will pass on the appropriate flash select flag to low level driver, and it
> > will select pass all the data to that particular flash.
> >
> > Write operation in parallel mode are performed in page size * 2 chunks as
> > each write operation results in writing both the flashes. For doubling the
> > address space each operation is performed at addr/2 flash offset, where addr
> > is the address specified by the user.
> >
> > Similarly for read and erase operations it will read from both flashes, so size
> > and offset are divided by 2 and send to flash.
> >
> > Changes in v2:
> > - Fixed the compilation issues.
> > Changes in v3:
> > - Fixed the CI issues.
> > Changes in v4:
> > - Removed the dio,dummy_bytes variables from zynq_qspi driver.
> > - Fix the compilation issue by including the DM_SPI config.
> > Changes in v5:
> > - Fixed the issue reported by buildman.
> > Changes in v6:
> > - Fixed the issues reported while running the sandbox test cases.
> > Changes in v7:
> > - Fixed the issues reported while running these da850evm_defconfig,
> > imx28_xea_defconfig configs.
> > - Fixed the issue when DM_SPI config is disabled.
> > - Fixed the issue while running the sandbox_noinst_defconfig with spl
> > ./spl/u-boot-spl -d arch/sandbox/dts/test.dtb
> > jedec_spi_nor spi.bin@0: has no valid 'reg' property (-12)
> > jedec_spi_nor spi.bin@1: has no valid 'reg' property (-12)
> > ### ERROR ### Please RESET the board ### Changes in v8:
> > - Fixed the compilation issue with imx28_xea_defconfig.
> > - Fixed the SPL size issue with the axm and taurus defconfigs.
> > - Rebased the patches on top of next branch.
> > Changes in v9:
> > - Updated the commit log why SPL_FIT is being enabled.
> > Changes in v10:
> > - Added the new config SPI_ADVANCE to fix the issue while enabling
> > imx28_xea_defconfig.
> > Changes in v11:
> > - Removed the unused variable, corrected the type of variable and replaced
> > memcpy with memmove.
> >
> > Ashok Reddy Soma (4):
> > mtd: spi-nor: Add parallel and stacked memories support
> > mtd: spi-nor: Add parallel memories support for read_sr and read_fsr
> > mtd: spi-nor: Add parallel and stacked memories support in read_bar
> > and write_bar
> > spi: spi-uclass: Read chipselect and restrict capabilities
> >
> > Venkatesh Yadav Abbarapu (4):
> > spi: zynqmp_gqspi: Add parallel memories support in GQSPI driver
> > spi: zynq_qspi: Add parallel memories support in QSPI driver
> > spi: Add the spi advance options for non SPL
> > config: xea: Enable the SPI_ADVANCE config option
> >
> > configs/imx28_xea_defconfig | 1 +
> > drivers/mtd/spi/sandbox.c | 2 +-
> > drivers/mtd/spi/spi-nor-core.c | 399 ++++++++++++++++++++++++++++-----
> > drivers/spi/Kconfig | 7 +
> > drivers/spi/altera_spi.c | 4 +-
> > drivers/spi/atcspi200_spi.c | 2 +-
> > drivers/spi/ath79_spi.c | 2 +-
> > drivers/spi/atmel_spi.c | 6 +-
> > drivers/spi/bcm63xx_hsspi.c | 42 ++--
> > drivers/spi/bcm63xx_spi.c | 6 +-
> > drivers/spi/bcmbca_hsspi.c | 34 +--
> > drivers/spi/cf_spi.c | 6 +-
> > drivers/spi/davinci_spi.c | 8 +-
> > drivers/spi/fsl_dspi.c | 18 +-
> > drivers/spi/fsl_espi.c | 4 +-
> > drivers/spi/fsl_qspi.c | 4 +-
> > drivers/spi/gxp_spi.c | 2 +-
> > drivers/spi/mpc8xx_spi.c | 4 +-
> > drivers/spi/mpc8xxx_spi.c | 10 +-
> > drivers/spi/mscc_bb_spi.c | 4 +-
> > drivers/spi/mxc_spi.c | 6 +-
> > drivers/spi/npcm_fiu_spi.c | 14 +-
> > drivers/spi/nxp_fspi.c | 2 +-
> > drivers/spi/octeon_spi.c | 2 +-
> > drivers/spi/omap3_spi.c | 4 +-
> > drivers/spi/pic32_spi.c | 2 +-
> > drivers/spi/rk_spi.c | 4 +-
> > drivers/spi/rockchip_sfc.c | 2 +-
> > drivers/spi/spi-aspeed-smc.c | 28 +--
> > drivers/spi/spi-mxic.c | 6 +-
> > drivers/spi/spi-qup.c | 4 +-
> > drivers/spi/spi-sifive.c | 6 +-
> > drivers/spi/spi-sn-f-ospi.c | 2 +-
> > drivers/spi/spi-sunxi.c | 6 +-
> > drivers/spi/spi-synquacer.c | 4 +-
> > drivers/spi/spi-uclass.c | 34 ++-
> > drivers/spi/stm32_qspi.c | 2 +-
> > drivers/spi/stm32_spi.c | 4 +-
> > drivers/spi/ti_qspi.c | 14 +-
> > drivers/spi/xilinx_spi.c | 6 +-
> > drivers/spi/zynq_qspi.c | 119 ++++++++--
> > drivers/spi/zynq_spi.c | 6 +-
> > drivers/spi/zynqmp_gqspi.c | 141 ++++++++++--
> > include/linux/mtd/spi-nor.h | 12 +
> > include/spi.h | 23 +-
> > lib/acpi/acpi_device.c | 2 +-
> > 46 files changed, 792 insertions(+), 228 deletions(-)
> >
> > --
> > 2.17.1
>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-05-07 15:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 3:10 [PATCH v11 0/8] spi-nor: Add parallel and stacked memories support Venkatesh Yadav Abbarapu
2024-03-04 3:10 ` [PATCH v11 1/8] mtd: " Venkatesh Yadav Abbarapu
2024-03-04 3:10 ` [PATCH v11 2/8] mtd: spi-nor: Add parallel memories support for read_sr and read_fsr Venkatesh Yadav Abbarapu
2024-03-04 3:10 ` [PATCH v11 3/8] mtd: spi-nor: Add parallel and stacked memories support in read_bar and write_bar Venkatesh Yadav Abbarapu
2024-03-04 3:10 ` [PATCH v11 4/8] spi: spi-uclass: Read chipselect and restrict capabilities Venkatesh Yadav Abbarapu
2024-03-04 3:10 ` [PATCH v11 5/8] spi: zynqmp_gqspi: Add parallel memories support in GQSPI driver Venkatesh Yadav Abbarapu
2024-03-04 3:10 ` [PATCH v11 6/8] spi: zynq_qspi: Add parallel memories support in QSPI driver Venkatesh Yadav Abbarapu
2024-03-04 3:10 ` [PATCH v11 7/8] spi: Add the spi advance options for non SPL Venkatesh Yadav Abbarapu
2024-03-04 3:10 ` [PATCH v11 8/8] config: xea: Enable the SPI_ADVANCE config option Venkatesh Yadav Abbarapu
2024-05-07 4:15 ` [PATCH v11 0/8] spi-nor: Add parallel and stacked memories support Abbarapu, Venkatesh
2024-05-07 15:48 ` Tom Rini [this message]
2024-05-24 14:09 ` Michal Simek
2024-05-24 15:26 ` Tom Rini
2024-05-24 16:07 ` Jagan Teki
2024-05-24 16:11 ` Tom Rini
2024-05-24 16:57 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507154836.GV2568172@bill-the-cat \
--to=trini@konsulko.com \
--cc=git@amd.com \
--cc=jagan@amarulasolutions.com \
--cc=michal.simek@amd.com \
--cc=u-boot@lists.denx.de \
--cc=venkatesh.abbarapu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).