From: Sam Day <me@samcday.com>
To: Lukasz Majewski <lukma@denx.de>,
Sean Anderson <seanga2@gmail.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Sumit Garg <sumit.garg@linaro.org>, Tom Rini <trini@konsulko.com>,
Marek Vasut <marex@denx.de>
Cc: Caleb Connolly <caleb.connolly@linaro.org>,
u-boot-qcom@groups.io, u-boot@lists.denx.de,
Sam Day <me@samcday.com>
Subject: [PATCH v2 0/2] qcom: ehci: enable core + iface clocks
Date: Mon, 06 May 2024 10:26:51 +0000 [thread overview]
Message-ID: <20240506-msm8916-hs-usb-clocks-v2-0-34f741b3a2ec@samcday.com> (raw)
These clocks are mandatory, as can be seen in msm_hsusb driver in the
Linux kernel.
The appropriate HS_USB AHB/SYSTEM clocks were added to gcc_apq8016.
Technically there's other adjacent SoC families that can use the
msm_hsusb driver with different clocks, but only msm8916/apq8016 are
currently making use of it so I think this change shouldn't break
anything elsewhere.
Signed-off-by: Sam Day <me@samcday.com>
---
Changes in v2:
- Remove nonsensical/unnecessary reference to pending qcom debug dump
from commit message.
- Collapse ftbl_gcc_usb_hs_system_clk into apq8016_clk_set_rate, since
it's only 1 entry.
- Add bounds check on clock id in apq8016_clk_enable
- Add warn if a rate other than 80mhz is requested for
GCC_USB_HS_SYSTEM_CLK
- Caleb: I opted to keep the non-bulk clock enablement code as-is in
ehci_msm, since that more closely resembles the existing Linux
kernel code.
- Link to v1: https://lore.kernel.org/r/20240502-msm8916-hs-usb-clocks-v1-0-eeccf483b68d@samcday.com
---
Sam Day (2):
clk/qcom: apq8016: add support for USB_HS clocks
ehci: msm: bring up iface + core clocks
drivers/clk/qcom/clock-apq8016.c | 32 ++++++++++++++++++++++++++++++++
drivers/usb/host/ehci-msm.c | 37 +++++++++++++++++++++++++++++++++++--
2 files changed, 67 insertions(+), 2 deletions(-)
---
base-commit: 2f1e76bcfee75b9f99ade63002c05ffaaec86afb
change-id: 20240502-msm8916-hs-usb-clocks-34bc22b03f3d
Best regards,
--
Sam Day <me@samcday.com>
next reply other threads:[~2024-05-06 10:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 10:26 Sam Day [this message]
2024-05-06 10:26 ` [PATCH v2 1/2] clk/qcom: apq8016: add support for USB_HS clocks Sam Day
2024-05-08 12:46 ` Caleb Connolly
2024-05-06 10:26 ` [PATCH v2 2/2] ehci: msm: bring up iface + core clocks Sam Day
2024-05-13 8:27 ` [PATCH v2 0/2] qcom: ehci: enable core + iface clocks Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506-msm8916-hs-usb-clocks-v2-0-34f741b3a2ec@samcday.com \
--to=me@samcday.com \
--cc=caleb.connolly@linaro.org \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=neil.armstrong@linaro.org \
--cc=seanga2@gmail.com \
--cc=sumit.garg@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).