From: "A. Sverdlin" <alexander.sverdlin@siemens.com>
To: Ian Roberts <ian.roberts@timesys.com>,
Greg Malysa <greg.malysa@timesys.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
u-boot@lists.denx.de
Cc: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Subject: [PATCH] mmc: sdhci: Correct ADMA_DESC_LEN to 12
Date: Wed, 1 May 2024 20:53:04 +0200 [thread overview]
Message-ID: <20240501185331.1189647-1-alexander.sverdlin@siemens.com> (raw)
From: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Commit 37cb626da25d0d ("mmc: sdhci: Add Support for ADMA2") introduced
ADMA_DESC_LEN == 16 (64 bit case), but it was never used before commit
74755c1fed1b0 ("mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops").
"sizeof(struct sdhci_adma_desc)" (== 12 for 64bit case) was used instead.
Confusion probably originates from Linux commit 685e444bbaa0
("mmc: sdhci: Add ADMA2 64-bit addressing support for V4 mode"), but
the latter "V4 mode" was never ported to U-Boot.
Fixes: 74755c1fed1b0 ("mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops")
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
---
include/sdhci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/sdhci.h b/include/sdhci.h
index d73a725609be3..810ef56e4be66 100644
--- a/include/sdhci.h
+++ b/include/sdhci.h
@@ -300,7 +300,7 @@ struct sdhci_ops {
#define ADMA_MAX_LEN 65532
#ifdef CONFIG_DMA_ADDR_T_64BIT
-#define ADMA_DESC_LEN 16
+#define ADMA_DESC_LEN 12
#else
#define ADMA_DESC_LEN 8
#endif
--
2.44.0
next reply other threads:[~2024-05-01 18:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 18:53 A. Sverdlin [this message]
2024-05-01 20:06 ` [PATCH] mmc: sdhci: Correct ADMA_DESC_LEN to 12 Jon Humphreys
2024-05-02 2:38 ` Greg Malysa
2024-05-02 5:56 ` Sverdlin, Alexander
2024-05-02 14:21 ` Judith Mendez
2024-05-02 17:50 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501185331.1189647-1-alexander.sverdlin@siemens.com \
--to=alexander.sverdlin@siemens.com \
--cc=greg.malysa@timesys.com \
--cc=ian.roberts@timesys.com \
--cc=jh80.chung@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).