From: seanedmond@linux.microsoft.com
To: u-boot@lists.denx.de
Cc: joe.hershberger@ni.com, rfried.dev@gmail.com, trini@konsulko.com,
v.v.mitrofanov@yadro.com, saproj@gmail.com,
Sean Edmond <seanedmond@microsoft.com>
Subject: [PATCH] Fix neighbor discovery ethernet address saving
Date: Mon, 29 Apr 2024 11:51:16 -0700 [thread overview]
Message-ID: <20240429185116.2287092-1-seanedmond@linux.microsoft.com> (raw)
From: Sean Edmond <seanedmond@microsoft.com>
When a successful neighbor advertisement is received, the ethernet
address should be saved for later use to avoid having to redo the
neighbor discovery process.
For example, with TFTP the address should get saved into
"net_server_ethaddr". This is being done correctly with ARP for IPv4,
but not for neighbor discovery with IPv6.
Signed-off-by: Sean Edmond <seanedmond@microsoft.com>
---
net/ndisc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ndisc.c b/net/ndisc.c
index d1cec0601c8..505515f2d95 100644
--- a/net/ndisc.c
+++ b/net/ndisc.c
@@ -461,8 +461,8 @@ int ndisc_receive(struct ethernet_hdr *et, struct ip6_hdr *ip6, int len)
ndisc_extract_enetaddr(ndisc, neigh_eth_addr);
/* save address for later use */
- if (!net_nd_packet_mac)
- net_nd_packet_mac = neigh_eth_addr;
+ if (net_nd_packet_mac)
+ memcpy(net_nd_packet_mac, neigh_eth_addr, 6);
/* modify header, and transmit it */
memcpy(((struct ethernet_hdr *)net_nd_tx_packet)->et_dest,
--
2.42.0
next reply other threads:[~2024-04-29 18:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 18:51 seanedmond [this message]
2024-05-05 9:40 ` [PATCH] Fix neighbor discovery ethernet address saving Vyacheslav V. Mitrofanov
2024-05-08 5:16 ` Sean Edmond
2024-05-13 6:55 ` Vyacheslav V. Mitrofanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429185116.2287092-1-seanedmond@linux.microsoft.com \
--to=seanedmond@linux.microsoft.com \
--cc=joe.hershberger@ni.com \
--cc=rfried.dev@gmail.com \
--cc=saproj@gmail.com \
--cc=seanedmond@microsoft.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=v.v.mitrofanov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).