From: Sean Edmond <seanedmond@microsoft.com>
To: u-boot@lists.denx.de
Cc: trini@konsulko.com, "Sean Edmond" <seanedmond@microsoft.com>,
"AKASHI Takahiro" <takahiro.akashi@linaro.org>,
"Bin Meng" <bmeng.cn@gmail.com>, "Bin Meng" <bmeng@tinylab.org>,
"Charles Hardin" <ckhardin@gmail.com>,
"Francis Laniel" <francis.laniel@amarulasolutions.com>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Joe Hershberger" <joe.hershberger@ni.com>,
"Marek Vasut" <marex@denx.de>,
"Mattijs Korpershoek" <mkorpershoek@baylibre.com>,
"Michal Simek" <michal.simek@amd.com>,
"Oleksandr Suvorov" <oleksandr.suvorov@foundries.io>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Ramon Fried" <rfried.dev@gmail.com>,
"Sean Anderson" <sean.anderson@seco.com>,
"Sean Anderson" <seanga2@gmail.com>,
"Simon Glass" <sjg@chromium.org>,
"Vincent Stehlé" <vincent.stehle@arm.com>
Subject: [PATCH v6 0/3] BOOTP/DHCPv4 enhancements
Date: Mon, 29 Apr 2024 11:33:55 -0700 [thread overview]
Message-ID: <20240429183449.2284935-1-seanedmond@microsoft.com> (raw)
In our datacenter application, a single DHCP server is servicing 36000+ clients.
Improvements are required to the DHCPv4 retransmission behavior to align with
RFC and ensure less pressure is exerted on the server:
- retransmission backoff interval maximum is configurable
(environment variable bootpretransmitperiodmax)
- initial retransmission backoff interval is configurable
(environment variable bootpretransmitperiodinit)
- transaction ID is kept the same for each BOOTP/DHCPv4 request
(not recreated on each retry)
For our application we'll use:
- bootpretransmitperiodmax=16000
- bootpretransmitperiodinit=2000
A new configuration BOOTP_RANDOM_XID has been added to enable a randomized
BOOTP/DHCPv4 transaction ID.
Enhance DHCPv4 sending/parsing option 209 (PXE config file). A previous
patch was accepted. A new patch fixes a possible double free() and
addresses latest review comments.
Changes in v7:
- Remove "depends on LIB_RAND || LIB_HW_RAND" from CMD_BOOTP
- Add CMD_BOOTP/CMD_DHCP/CMD_DHCP6 to LIB_RAND menu choice
- Add space after "config CMD_DHCP"
Changes in v6:
- CMD_BOOTP should "depends on LIB_RAND || LIB_HW_RAND"
Changes in v5:
- add change log to individual patches
- fix depends for BOOTP_RANDOM_XID:
"depends on CMD_BOOTP && (LIB_RAND || LIB_HW_RAND)"
Changes in v4:
- rebase master and resolve conflicts
- default y for BOOTP_PXE_DHCP_OPTION (feedback from review)
- Add "select LIB_RAND" for "config CMD_BOOTP" (retransmission
improvements require rand())
Changes in v3:
- add define for option 209 and rfc5071 reference
- Set RETRANSMIT_PERIOD_MAX_MS=60000
- Add randomization factor to retransmission timeout
- Add depends for BOOTP_RANDOM_XID
Changes in v2:
- use env_get_ulong() to get environment variables
Sean Edmond (3):
net: Enhancements for dhcp option 209
net: bootp: BOOTP/DHCPv4 retransmission improvements
net: bootp: add config option BOOTP_RANDOM_XID
cmd/Kconfig | 8 ++++++
cmd/pxe.c | 2 ++
lib/Kconfig | 3 ++-
net/bootp.c | 76 +++++++++++++++++++++++++++++++++++++++++------------
net/bootp.h | 2 ++
5 files changed, 73 insertions(+), 18 deletions(-)
--
2.42.0
next reply other threads:[~2024-04-29 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 18:33 Sean Edmond [this message]
2024-04-29 18:33 ` [PATCH v6 1/3] net: Enhancements for dhcp option 209 Sean Edmond
2024-04-29 18:33 ` [PATCH v6 2/3] net: bootp: BOOTP/DHCPv4 retransmission improvements Sean Edmond
2024-05-08 15:32 ` Tom Rini
2024-04-29 18:33 ` [PATCH v6 3/3] net: bootp: add config option BOOTP_RANDOM_XID Sean Edmond
-- strict thread matches above, loose matches on Subject: below --
2023-11-22 23:27 [PATCH v6 0/3] BOOTP/DHCPv4 enhancements Sean Edmond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429183449.2284935-1-seanedmond@microsoft.com \
--to=seanedmond@microsoft.com \
--cc=bmeng.cn@gmail.com \
--cc=bmeng@tinylab.org \
--cc=ckhardin@gmail.com \
--cc=francis.laniel@amarulasolutions.com \
--cc=ilias.apalodimas@linaro.org \
--cc=joe.hershberger@ni.com \
--cc=marex@denx.de \
--cc=michal.simek@amd.com \
--cc=mkorpershoek@baylibre.com \
--cc=oleksandr.suvorov@foundries.io \
--cc=pbrobinson@gmail.com \
--cc=rfried.dev@gmail.com \
--cc=sean.anderson@seco.com \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=takahiro.akashi@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vincent.stehle@arm.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).