* [PATCH] sysreset: Change Kconfig GPIO dependency
@ 2023-07-04 12:05 Michal Simek
2023-07-08 15:29 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Michal Simek @ 2023-07-04 12:05 UTC (permalink / raw
To: u-boot, git; +Cc: Heinrich Schuchardt, Leo Yu-Chi Liang
DM_GPIO depends on GPIO to be enabled but select will cause that DM_GPIO is
selected without GPIO which ends up in compilation error:
undefined reference to `dm_gpio_set_value'
undefined reference to `dm_gpio_get_value'
undefined reference to `dm_gpio_free'
undefined reference to `gpio_request_by_name'
Signed-off-by: Michal Simek <michal.simek@amd.com>
---
drivers/sysreset/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/sysreset/Kconfig b/drivers/sysreset/Kconfig
index 03f7fdd59785..bdbe2a95364d 100644
--- a/drivers/sysreset/Kconfig
+++ b/drivers/sysreset/Kconfig
@@ -61,14 +61,14 @@ endif
config POWEROFF_GPIO
bool "Enable support for GPIO poweroff driver"
- select DM_GPIO
+ depends on DM_GPIO
help
Support for system poweroff using a GPIO pin. This can be used
for systems having a single GPIO to trigger a system poweroff.
config SYSRESET_GPIO
bool "Enable support for GPIO reset driver"
- select DM_GPIO
+ depends on DM_GPIO
help
Reset support via GPIO pin connected reset logic. This is used for
example on Microblaze where reset logic can be controlled via GPIO
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sysreset: Change Kconfig GPIO dependency
2023-07-04 12:05 [PATCH] sysreset: Change Kconfig GPIO dependency Michal Simek
@ 2023-07-08 15:29 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2023-07-08 15:29 UTC (permalink / raw
To: Michal Simek; +Cc: u-boot, git, Heinrich Schuchardt, Leo Yu-Chi Liang
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
On Tue, Jul 04, 2023 at 02:05:13PM +0200, Michal Simek wrote:
> DM_GPIO depends on GPIO to be enabled but select will cause that DM_GPIO is
> selected without GPIO which ends up in compilation error:
> undefined reference to `dm_gpio_set_value'
> undefined reference to `dm_gpio_get_value'
> undefined reference to `dm_gpio_free'
> undefined reference to `gpio_request_by_name'
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-08 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-04 12:05 [PATCH] sysreset: Change Kconfig GPIO dependency Michal Simek
2023-07-08 15:29 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).