* [PATCH v2] dfu: Add proper dependency for CONFIG_DFU_MMC
@ 2023-07-07 8:51 Ashok Reddy Soma
2023-07-18 13:57 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Ashok Reddy Soma @ 2023-07-07 8:51 UTC (permalink / raw
To: u-boot; +Cc: lukma, michal.simek, git, Ashok Reddy Soma
When CONFIG_CMD_MMC and CONFIG_MMC are disabled, still some compilation
errors are seen as below due to unresolved symbols.
drivers/dfu/dfu_mmc.o: in function `mmc_block_op':
drivers/dfu/dfu_mmc.c:32: undefined reference to `find_mmc_device'
drivers/dfu/dfu_mmc.c:54: undefined reference to `mmc_get_blk_desc'
drivers/dfu/dfu_mmc.c:67: undefined reference to `mmc_get_blk_desc'
drivers/dfu/dfu_mmc.c:70: undefined reference to `mmc_get_blk_desc'
drivers/dfu/dfu_mmc.o: in function `dfu_fill_entity_mmc':
drivers/dfu/dfu_mmc.c:369: undefined reference to `find_mmc_device'
drivers/dfu/dfu_mmc.c:376: undefined reference to `mmc_init'
drivers/dfu/dfu_mmc.c:403: undefined reference to `mmc_get_blk_desc'
gnu/aarch64/lin/aarch64-linux/bin/aarch64-linux-gnu-ld.bfd: line 4:
31661 Segmentation fault (core dumped) $CC --sysroot=$LIBC
--no-warn-rwx-segment "$@"
Makefile:1760: recipe for target 'u-boot' failed
make: *** [u-boot] Error 139
make: *** Deleting file 'u-boot'
Add dependency of CONFIG_MMC for CONFIG_DFU_MMC config to fix the errors.
Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@amd.com>
---
Changes in v2:
- Changed patch subject prefix to dfu from zynqmp: config
drivers/dfu/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
index 8d7f13dcb0..8e9e8eb4fe 100644
--- a/drivers/dfu/Kconfig
+++ b/drivers/dfu/Kconfig
@@ -35,6 +35,7 @@ config DFU_TIMEOUT
config DFU_MMC
bool "MMC back end for DFU"
+ depends on MMC
help
This option enables using DFU to read and write to MMC based storage.
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] dfu: Add proper dependency for CONFIG_DFU_MMC
2023-07-07 8:51 [PATCH v2] dfu: Add proper dependency for CONFIG_DFU_MMC Ashok Reddy Soma
@ 2023-07-18 13:57 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2023-07-18 13:57 UTC (permalink / raw
To: Ashok Reddy Soma; +Cc: u-boot, lukma, michal.simek, git
[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]
On Fri, Jul 07, 2023 at 02:51:36AM -0600, Ashok Reddy Soma wrote:
> When CONFIG_CMD_MMC and CONFIG_MMC are disabled, still some compilation
> errors are seen as below due to unresolved symbols.
>
> drivers/dfu/dfu_mmc.o: in function `mmc_block_op':
> drivers/dfu/dfu_mmc.c:32: undefined reference to `find_mmc_device'
> drivers/dfu/dfu_mmc.c:54: undefined reference to `mmc_get_blk_desc'
> drivers/dfu/dfu_mmc.c:67: undefined reference to `mmc_get_blk_desc'
> drivers/dfu/dfu_mmc.c:70: undefined reference to `mmc_get_blk_desc'
> drivers/dfu/dfu_mmc.o: in function `dfu_fill_entity_mmc':
> drivers/dfu/dfu_mmc.c:369: undefined reference to `find_mmc_device'
> drivers/dfu/dfu_mmc.c:376: undefined reference to `mmc_init'
> drivers/dfu/dfu_mmc.c:403: undefined reference to `mmc_get_blk_desc'
> gnu/aarch64/lin/aarch64-linux/bin/aarch64-linux-gnu-ld.bfd: line 4:
> 31661 Segmentation fault (core dumped) $CC --sysroot=$LIBC
> --no-warn-rwx-segment "$@"
> Makefile:1760: recipe for target 'u-boot' failed
> make: *** [u-boot] Error 139
> make: *** Deleting file 'u-boot'
>
> Add dependency of CONFIG_MMC for CONFIG_DFU_MMC config to fix the errors.
>
> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@amd.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-18 13:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-07 8:51 [PATCH v2] dfu: Add proper dependency for CONFIG_DFU_MMC Ashok Reddy Soma
2023-07-18 13:57 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).