From: Tero Kristo <kristo@kernel.org>
To: u-boot@lists.denx.de, lokeshvutla@ti.com
Cc: trini@konsulko.com
Subject: [PATCHv5 11/26] clk: fix set_rate to clean up cached rates for the hierarchy
Date: Thu, 3 Jun 2021 09:32:40 +0300 [thread overview]
Message-ID: <20210603063255.5483-12-kristo@kernel.org> (raw)
In-Reply-To: <20210603063255.5483-1-kristo@kernel.org>
From: Tero Kristo <t-kristo@ti.com>
Clock rates are cached within the individual clock nodes, and right now
if one changes a clock rate somewhere in the middle of the tree, none
of its child clocks notice the change. To fix this, clear up all the
cached rates for us and our child clocks.
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Tero Kristo <kristo@kernel.org>
---
drivers/clk/clk-uclass.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c
index 815f7bfe98..3d2344f009 100644
--- a/drivers/clk/clk-uclass.c
+++ b/drivers/clk/clk-uclass.c
@@ -568,6 +568,22 @@ ulong clk_round_rate(struct clk *clk, ulong rate)
return ops->round_rate(clk, rate);
}
+static void clk_clean_rate_cache(struct clk *clk)
+{
+ struct udevice *child_dev;
+ struct clk *clkp;
+
+ if (!clk)
+ return;
+
+ clk->rate = 0;
+
+ list_for_each_entry(child_dev, &clk->dev->child_head, sibling_node) {
+ clkp = dev_get_clk_ptr(child_dev);
+ clk_clean_rate_cache(clkp);
+ }
+}
+
ulong clk_set_rate(struct clk *clk, ulong rate)
{
const struct clk_ops *ops;
@@ -580,6 +596,9 @@ ulong clk_set_rate(struct clk *clk, ulong rate)
if (!ops->set_rate)
return -ENOSYS;
+ /* Clean up cached rates for us and all child clocks */
+ clk_clean_rate_cache(clk);
+
return ops->set_rate(clk, rate);
}
--
2.17.1
next prev parent reply other threads:[~2021-06-03 6:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 6:32 [PATCHv5 00/26] Re-base / re-post of TI-K3 HSM rearch series Tero Kristo
2021-06-03 6:32 ` [PATCHv5 01/26] lib: rational: copy the rational fraction lib routines from Linux Tero Kristo
2021-06-03 6:32 ` [PATCHv5 02/26] arm: mach-k3: introduce new config option for sysfw split Tero Kristo
2021-06-03 6:32 ` [PATCHv5 03/26] remoteproc: k3-r5: remove sysfw PM calls if not supported Tero Kristo
2021-06-03 6:32 ` [PATCHv5 04/26] common: fit: Update board_fit_image_post_process() to pass fit and node_offset Tero Kristo
2021-06-09 10:33 ` Tero Kristo
2021-06-03 6:32 ` [PATCHv5 05/26] clk: fixed_rate: add API for directly registering fixed rate clocks Tero Kristo
2021-06-03 6:32 ` [PATCHv5 06/26] clk: fix clock tree dump to properly dump out every registered clock Tero Kristo
2021-06-03 6:32 ` [PATCHv5 07/26] clk: do not attempt to fetch clock pointer with null device Tero Kristo
2021-06-03 6:32 ` [PATCHv5 08/26] clk: add support for setting clk rate from cmdline Tero Kristo
2021-06-03 6:32 ` [PATCHv5 09/26] clk: sci-clk: fix return value of set_rate Tero Kristo
2021-06-03 6:32 ` [PATCHv5 10/26] clk: fix assigned-clocks to pass with deferring provider Tero Kristo
2021-06-03 6:32 ` Tero Kristo [this message]
2021-06-03 6:32 ` [PATCHv5 12/26] clk: add support for TI K3 SoC PLL Tero Kristo
2021-06-03 6:32 ` [PATCHv5 13/26] clk: add support for TI K3 SoC clocks Tero Kristo
2021-06-03 6:32 ` [PATCHv5 14/26] power: domain: Introduce driver for raw TI K3 PDs Tero Kristo
2021-06-03 6:32 ` [PATCHv5 15/26] cmd: ti: pd: Add debug command for K3 power domains Tero Kristo
2021-06-03 6:32 ` [PATCHv5 16/26] tools: k3_fit_atf: add DM binary to the FIT image Tero Kristo
2021-06-03 6:32 ` [PATCHv5 17/26] arm: mach-k3: Add platform data for j721e and j7200 Tero Kristo
2021-06-03 6:32 ` [PATCHv5 18/26] arm: mach-k3: add support for detecting firmware images from FIT Tero Kristo
2021-06-03 6:32 ` [PATCHv5 19/26] arm: mach-k3: do board config for PM only if supported Tero Kristo
2021-06-03 6:32 ` [PATCHv5 20/26] arm: mach-k3: common: Drop main r5 start Tero Kristo
2021-06-03 6:32 ` [PATCHv5 21/26] arm: mach-k3: sysfw-loader: pass boardcfg to sciserver Tero Kristo
2021-06-03 6:32 ` [PATCHv5 22/26] arm: mach-k3: j721e_init: Force early probe of clk-k3 driver Tero Kristo
2021-06-03 6:32 ` [PATCHv5 23/26] configs: j721e_evm_r5: Enable raw access power management features Tero Kristo
2021-06-03 6:32 ` [PATCHv5 24/26] configs: j7200_evm_r5: " Tero Kristo
2021-06-03 6:32 ` [PATCHv5 25/26] board: ti: j72xx: README: update build instructions and image formats Tero Kristo
2021-06-03 6:32 ` [PATCHv5 26/26] arm: dts: k3-j72xx: correct MCU timer1 frequency Tero Kristo
2021-06-07 11:22 ` [PATCHv5 00/26] Re-base / re-post of TI-K3 HSM rearch series Lokesh Vutla
2021-06-08 6:27 ` Tero Kristo
2021-06-08 6:32 ` Lokesh Vutla
2021-06-08 6:43 ` Tero Kristo
2021-06-09 16:59 ` Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603063255.5483-12-kristo@kernel.org \
--to=kristo@kernel.org \
--cc=lokeshvutla@ti.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).