From: Tom Rini <trini@konsulko.com>
To: Matt Merhar <mattmerhar@protonmail.com>
Cc: u-boot@lists.denx.de, Priyanka Jain <priyanka.jain@nxp.com>,
Andy Fleming <afleming@gmail.com>, Stefan Roese <sr@denx.de>,
Wolfgang Denk <wd@denx.de>, Mario Six <mario.six@gdsys.cc>,
Daniel Schwierzeck <daniel.schwierzeck@gmail.com>,
Ovidiu Panait <ovidiu.panait@windriver.com>,
Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH] powerpc: fix regression in arch_initr_trap()
Date: Thu, 27 May 2021 07:42:11 -0400 [thread overview]
Message-ID: <20210527114211.GT17669@bill-the-cat> (raw)
In-Reply-To: <TDDHfABfwqGXWepeuoawzSOeOn4QJvTtHSqZY2ugsz4@cp4-web-038.plabs.ch>
[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]
On Mon, May 17, 2021 at 05:32:48PM +0000, Matt Merhar wrote:
> The assembly output of the arch_initr_trap() function differed by a
> single byte after common.h was removed from traps.c:
>
> fff49a18 <arch_initr_trap>:
> fff49a18: 94 21 ff f0 stwu r1,-16(r1)
> fff49a1c: 7c 08 02 a6 mflr r0
> fff49a20: 90 01 00 14 stw r0,20(r1)
> -fff49a24: 80 62 00 44 lwz r3,68(r2)
> +fff49a24: 80 62 00 38 lwz r3,56(r2)
> fff49a28: 4b ff 76 19 bl fff41040 <trap_init>
> fff49a2c: 80 01 00 14 lwz r0,20(r1)
> fff49a30: 38 60 00 00 li r3,0
> fff49a34: 38 21 00 10 addi r1,r1,16
> fff49a38: 7c 08 03 a6 mtlr r0
>
> This was causing a consistent hard lockup during the MMC read / loading
> of the QoriQ FMan firmware on a P2041RDB board.
>
> Re-adding the header causes identical assembly to be emitted and allows
> the firmware loading and subsequent boot to succeed.
>
> Fixes: 401d1c4f5d ("common: Drop asm/global_data.h from common header")
> Signed-off-by: Matt Merhar <mattmerhar@protonmail.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-05-27 11:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 17:32 [PATCH] powerpc: fix regression in arch_initr_trap() Matt Merhar
2021-05-18 5:50 ` Stefan Roese
2021-05-18 7:04 ` Rasmus Villemoes
2021-05-18 9:19 ` [RFC PATCH 0/2] sizeof(gd_t) sanity checking Rasmus Villemoes
2021-05-18 9:19 ` [RFC PATCH 1/2] build_bug.h: add wrapper for _Static_assert Rasmus Villemoes
2021-05-19 15:34 ` Simon Glass
2021-07-01 21:54 ` Tom Rini
2021-05-18 9:19 ` [RFC PATCH 2/2] global-data.h: add build-time sanity check of sizeof(struct global_data) Rasmus Villemoes
2021-05-19 15:34 ` Simon Glass
2021-07-01 21:54 ` Tom Rini
2021-06-03 13:38 ` [PATCH 1/4] powerpc: Don't use relative include for config.h in global_data.h Tom Rini
2021-06-03 13:39 ` [PATCH 2/4] Revert "powerpc: fix regression in arch_initr_trap()" Tom Rini
2021-06-24 13:15 ` Tom Rini
2021-06-03 13:39 ` [PATCH 3/4] socfpga64: Do not define CONFIG_SYS_MEM_RESERVE_SECURE to 0 Tom Rini
2021-06-03 15:07 ` Rasmus Villemoes
2021-06-03 15:14 ` Tom Rini
2021-06-24 13:15 ` Tom Rini
2021-06-03 13:39 ` [PATCH 4/4] global_data: Ensure we have <config.h> when symbols are not in Kconfig yet Tom Rini
2021-06-24 13:15 ` Tom Rini
2021-06-05 19:18 ` [PATCH 1/4] powerpc: Don't use relative include for config.h in global_data.h Matt Merhar
2021-06-24 13:15 ` Tom Rini
2021-05-27 11:42 ` Tom Rini [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-19 3:16 [PATCH] powerpc: fix regression in arch_initr_trap() Matt Merhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527114211.GT17669@bill-the-cat \
--to=trini@konsulko.com \
--cc=afleming@gmail.com \
--cc=daniel.schwierzeck@gmail.com \
--cc=mario.six@gdsys.cc \
--cc=mattmerhar@protonmail.com \
--cc=ovidiu.panait@windriver.com \
--cc=priyanka.jain@nxp.com \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).