* [U-Boot] [PATCH] boston: Drop unused return value
@ 2017-09-15 18:33 Paul Burton
2017-09-15 20:24 ` Daniel Schwierzeck
0 siblings, 1 reply; 2+ messages in thread
From: Paul Burton @ 2017-09-15 18:33 UTC (permalink / raw
To: u-boot
The boston lowlevel_init() function zeroes the return register v0,
despite the function not being expected to return a value & that value
never being used.
Remove the redundant assignment to v0.
Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
---
board/imgtec/boston/lowlevel_init.S | 1 -
1 file changed, 1 deletion(-)
diff --git a/board/imgtec/boston/lowlevel_init.S b/board/imgtec/boston/lowlevel_init.S
index 0c01aa981d..46c9c1d269 100644
--- a/board/imgtec/boston/lowlevel_init.S
+++ b/board/imgtec/boston/lowlevel_init.S
@@ -34,7 +34,6 @@ LEAF(lowlevel_init)
PTR_LA a0, msg_ddr_ok
bal lowlevel_display
- move v0, zero
jr s0
END(lowlevel_init)
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] boston: Drop unused return value
2017-09-15 18:33 [U-Boot] [PATCH] boston: Drop unused return value Paul Burton
@ 2017-09-15 20:24 ` Daniel Schwierzeck
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Schwierzeck @ 2017-09-15 20:24 UTC (permalink / raw
To: u-boot
Am 15.09.2017 um 20:33 schrieb Paul Burton:
> The boston lowlevel_init() function zeroes the return register v0,
> despite the function not being expected to return a value & that value
> never being used.
>
> Remove the redundant assignment to v0.
>
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> ---
>
> board/imgtec/boston/lowlevel_init.S | 1 -
> 1 file changed, 1 deletion(-)
applied to u-boot-mips, thanks
--
- Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170915/ced55451/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-15 20:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-15 18:33 [U-Boot] [PATCH] boston: Drop unused return value Paul Burton
2017-09-15 20:24 ` Daniel Schwierzeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).