From: "Neil Armstrong" <narmstrong@baylibre.com>
To: christianshewitt@gmail.com, adeep@lexina.in, trini@konsulko.com
Cc: u-boot-amlogic@groups.io, u-boot@lists.denx.de
Subject: Re: [PATCH] configs: amlogic: Disable CONFIG_NET_RANDOM_ETHADDR when unnecessary
Date: Fri, 7 Jan 2022 10:12:29 +0100 [thread overview]
Message-ID: <cad23539-0fae-bcbe-ee8a-75f8fc625d1c@baylibre.com> (raw)
In-Reply-To: <20211122110710.1038893-1-narmstrong@baylibre.com>
On 22/11/2021 12:07, Neil Armstrong wrote:
> On Meson GXL, GXM, AXG, G12A, G12B & SM1 SoCs, we can generate an unique
> MAC address if none valid found in the eFuses storage.
>
> Only the GXBB based boards doesn't have a fallback way to generate an
> unique MAC address, so we rely on CONFIG_NET_RANDOM_ETHADDR to have
> a valid one.
>
> An exception is the Radxa Zero board who doesn't have Ethernet on board
> so depends on an (or multiple) eventual USB adapters, so leaving the
> CONFIG_NET_RANDOM_ETHADDR configs seems safer.
>
> Suggested-by: Tom Rini <trini@konsulko.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> configs/bananapi-m5_defconfig | 1 -
> configs/beelink-gsking-x_defconfig | 1 -
> configs/beelink-gtking_defconfig | 1 -
> configs/beelink-gtkingpro_defconfig | 1 -
> configs/jethub_j80_defconfig | 1 -
> configs/khadas-vim2_defconfig | 1 -
> configs/khadas-vim3_defconfig | 1 -
> configs/khadas-vim3l_defconfig | 1 -
> configs/khadas-vim_defconfig | 1 -
> configs/libretech-ac_defconfig | 1 -
> configs/libretech-cc_defconfig | 1 -
> configs/libretech-cc_v2_defconfig | 1 -
> configs/libretech-s905d-pc_defconfig | 1 -
> configs/libretech-s912-pc_defconfig | 1 -
> configs/odroid-c4_defconfig | 1 -
> configs/odroid-hc4_defconfig | 1 -
> configs/odroid-n2_defconfig | 1 -
> configs/p212_defconfig | 1 -
> configs/s400_defconfig | 1 -
> configs/sei510_defconfig | 1 -
> configs/sei610_defconfig | 1 -
> configs/u200_defconfig | 1 -
> configs/wetek-core2_defconfig | 1 -
> 23 files changed, 23 deletions(-)
>
> diff --git a/configs/bananapi-m5_defconfig b/configs/bananapi-m5_defconfig
> index 7ca14a5f6a..4bf81b2faa 100644
> --- a/configs/bananapi-m5_defconfig
> +++ b/configs/bananapi-m5_defconfig
> @@ -25,7 +25,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_ADC=y
> CONFIG_SARADC_MESON=y
> CONFIG_MMC_MESON_GX=y
> diff --git a/configs/beelink-gsking-x_defconfig b/configs/beelink-gsking-x_defconfig
> index 54ac1c9315..e60e754f56 100644
> --- a/configs/beelink-gsking-x_defconfig
> +++ b/configs/beelink-gsking-x_defconfig
> @@ -26,7 +26,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_MMC_MESON_GX=y
> CONFIG_MTD=y
> CONFIG_DM_MTD=y
> diff --git a/configs/beelink-gtking_defconfig b/configs/beelink-gtking_defconfig
> index 7735c70e3f..2ec3221563 100644
> --- a/configs/beelink-gtking_defconfig
> +++ b/configs/beelink-gtking_defconfig
> @@ -26,7 +26,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_MMC_MESON_GX=y
> CONFIG_MTD=y
> CONFIG_DM_MTD=y
> diff --git a/configs/beelink-gtkingpro_defconfig b/configs/beelink-gtkingpro_defconfig
> index 93c5739672..60d316d80a 100644
> --- a/configs/beelink-gtkingpro_defconfig
> +++ b/configs/beelink-gtkingpro_defconfig
> @@ -26,7 +26,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_MMC_MESON_GX=y
> CONFIG_MTD=y
> CONFIG_DM_MTD=y
> diff --git a/configs/jethub_j80_defconfig b/configs/jethub_j80_defconfig
> index ad6bec0c43..eb1e4c4a53 100644
> --- a/configs/jethub_j80_defconfig
> +++ b/configs/jethub_j80_defconfig
> @@ -33,7 +33,6 @@ CONFIG_CMD_REGULATOR=y
> CONFIG_PARTITION_TYPE_GUID=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_SARADC_MESON=y
> CONFIG_DM_I2C=y
> CONFIG_SYS_I2C_MESON=y
> diff --git a/configs/khadas-vim2_defconfig b/configs/khadas-vim2_defconfig
> index c852f7f3f9..81cff3cee8 100644
> --- a/configs/khadas-vim2_defconfig
> +++ b/configs/khadas-vim2_defconfig
> @@ -29,7 +29,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_SARADC_MESON=y
> CONFIG_MMC_MESON_GX=y
> CONFIG_MTD=y
> diff --git a/configs/khadas-vim3_defconfig b/configs/khadas-vim3_defconfig
> index a225a564b2..65050efd3f 100644
> --- a/configs/khadas-vim3_defconfig
> +++ b/configs/khadas-vim3_defconfig
> @@ -30,7 +30,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_ADC=y
> CONFIG_SARADC_MESON=y
> CONFIG_BUTTON=y
> diff --git a/configs/khadas-vim3l_defconfig b/configs/khadas-vim3l_defconfig
> index 9d94c31891..b9162c9f1e 100644
> --- a/configs/khadas-vim3l_defconfig
> +++ b/configs/khadas-vim3l_defconfig
> @@ -30,7 +30,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_ADC=y
> CONFIG_SARADC_MESON=y
> CONFIG_BUTTON=y
> diff --git a/configs/khadas-vim_defconfig b/configs/khadas-vim_defconfig
> index 5565635ab1..81eeff4982 100644
> --- a/configs/khadas-vim_defconfig
> +++ b/configs/khadas-vim_defconfig
> @@ -27,7 +27,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_SARADC_MESON=y
> CONFIG_MMC_MESON_GX=y
> CONFIG_PHY_MESON_GXL=y
> diff --git a/configs/libretech-ac_defconfig b/configs/libretech-ac_defconfig
> index fa4427a815..7dcd8540a9 100644
> --- a/configs/libretech-ac_defconfig
> +++ b/configs/libretech-ac_defconfig
> @@ -34,7 +34,6 @@ CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_ENV_IS_IN_SPI_FLASH=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_SARADC_MESON=y
> CONFIG_MMC_MESON_GX=y
> CONFIG_MTD=y
> diff --git a/configs/libretech-cc_defconfig b/configs/libretech-cc_defconfig
> index b729308c8e..b4413ed9b7 100644
> --- a/configs/libretech-cc_defconfig
> +++ b/configs/libretech-cc_defconfig
> @@ -26,7 +26,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_SARADC_MESON=y
> CONFIG_MMC_MESON_GX=y
> CONFIG_PHY_MESON_GXL=y
> diff --git a/configs/libretech-cc_v2_defconfig b/configs/libretech-cc_v2_defconfig
> index 9f8a914bb7..99a0b28d16 100644
> --- a/configs/libretech-cc_v2_defconfig
> +++ b/configs/libretech-cc_v2_defconfig
> @@ -30,7 +30,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_OF_CONTROL=y
> CONFIG_ENV_IS_IN_SPI_FLASH=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_SARADC_MESON=y
> CONFIG_MMC_MESON_GX=y
> CONFIG_MTD=y
> diff --git a/configs/libretech-s905d-pc_defconfig b/configs/libretech-s905d-pc_defconfig
> index bde2bb877c..6e8c8a497e 100644
> --- a/configs/libretech-s905d-pc_defconfig
> +++ b/configs/libretech-s905d-pc_defconfig
> @@ -32,7 +32,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_ENV_IS_IN_SPI_FLASH=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_SARADC_MESON=y
> CONFIG_MMC_MESON_GX=y
> CONFIG_MTD=y
> diff --git a/configs/libretech-s912-pc_defconfig b/configs/libretech-s912-pc_defconfig
> index 536f9e8d12..b08ca44abe 100644
> --- a/configs/libretech-s912-pc_defconfig
> +++ b/configs/libretech-s912-pc_defconfig
> @@ -31,7 +31,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_ENV_IS_IN_SPI_FLASH=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_SARADC_MESON=y
> CONFIG_MMC_MESON_GX=y
> CONFIG_MTD=y
> diff --git a/configs/odroid-c4_defconfig b/configs/odroid-c4_defconfig
> index bc778a641a..1ea003f3f8 100644
> --- a/configs/odroid-c4_defconfig
> +++ b/configs/odroid-c4_defconfig
> @@ -26,7 +26,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_ADC=y
> CONFIG_SARADC_MESON=y
> CONFIG_MMC_MESON_GX=y
> diff --git a/configs/odroid-hc4_defconfig b/configs/odroid-hc4_defconfig
> index 2fe761e939..d632670db0 100644
> --- a/configs/odroid-hc4_defconfig
> +++ b/configs/odroid-hc4_defconfig
> @@ -29,7 +29,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_ADC=y
> CONFIG_SARADC_MESON=y
> CONFIG_SATA=y
> diff --git a/configs/odroid-n2_defconfig b/configs/odroid-n2_defconfig
> index 8e9e8f8fb7..7f87504a9c 100644
> --- a/configs/odroid-n2_defconfig
> +++ b/configs/odroid-n2_defconfig
> @@ -26,7 +26,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_ADC=y
> CONFIG_SARADC_MESON=y
> CONFIG_MMC_MESON_GX=y
> diff --git a/configs/p212_defconfig b/configs/p212_defconfig
> index b1d2ca8350..bca0fa8404 100644
> --- a/configs/p212_defconfig
> +++ b/configs/p212_defconfig
> @@ -25,7 +25,6 @@ CONFIG_CMD_USB=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_MMC_MESON_GX=y
> CONFIG_PHY_MESON_GXL=y
> CONFIG_DM_ETH=y
> diff --git a/configs/s400_defconfig b/configs/s400_defconfig
> index 4467e66929..8483694685 100644
> --- a/configs/s400_defconfig
> +++ b/configs/s400_defconfig
> @@ -25,7 +25,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_MMC_MESON_GX=y
> CONFIG_PHY_REALTEK=y
> CONFIG_DM_ETH=y
> diff --git a/configs/sei510_defconfig b/configs/sei510_defconfig
> index 690a0ca8d4..5e2496edbe 100644
> --- a/configs/sei510_defconfig
> +++ b/configs/sei510_defconfig
> @@ -43,7 +43,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_SYS_MMC_ENV_DEV=2
> CONFIG_SYS_MMC_ENV_PART=1
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_USB_FUNCTION_FASTBOOT=y
> CONFIG_FASTBOOT_BUF_ADDR=0x6000000
> CONFIG_FASTBOOT_FLASH=y
> diff --git a/configs/sei610_defconfig b/configs/sei610_defconfig
> index 63080aec2d..df53c91d8b 100644
> --- a/configs/sei610_defconfig
> +++ b/configs/sei610_defconfig
> @@ -43,7 +43,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_SYS_MMC_ENV_DEV=2
> CONFIG_SYS_MMC_ENV_PART=1
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_USB_FUNCTION_FASTBOOT=y
> CONFIG_FASTBOOT_BUF_ADDR=0x6000000
> CONFIG_FASTBOOT_FLASH=y
> diff --git a/configs/u200_defconfig b/configs/u200_defconfig
> index 144c394010..7f46dcf5c2 100644
> --- a/configs/u200_defconfig
> +++ b/configs/u200_defconfig
> @@ -25,7 +25,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_MMC_MESON_GX=y
> CONFIG_DM_ETH=y
> CONFIG_DM_MDIO=y
> diff --git a/configs/wetek-core2_defconfig b/configs/wetek-core2_defconfig
> index ce947b5625..006cebc711 100644
> --- a/configs/wetek-core2_defconfig
> +++ b/configs/wetek-core2_defconfig
> @@ -26,7 +26,6 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_SARADC_MESON=y
> CONFIG_MMC_MESON_GX=y
> CONFIG_MTD=y
>
Applied to u-boot-amlogic
Neil
prev parent reply other threads:[~2022-01-07 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 11:07 [PATCH] configs: amlogic: Disable CONFIG_NET_RANDOM_ETHADDR when unnecessary Neil Armstrong
2021-11-22 11:27 ` Vyacheslav Bocharov
2022-01-07 9:12 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cad23539-0fae-bcbe-ee8a-75f8fc625d1c@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=adeep@lexina.in \
--cc=christianshewitt@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).