From: neil.armstrong@linaro.org
To: Alexey Romanov <avromanov@salutedevices.com>,
narmstrong@baylibre.com, sjg@google.com,
takahiro.akashi@linaro.org, ilias.apalodimas@linaro.org,
post@lespocky.de, marex@denx.de, msuchanek@suse.de,
sughosh.ganu@linaro.org, jh80.chung@samsung.com,
paul.barker@sancloud.com
Cc: u-boot-amlogic@groups.io, u-boot@lists.denx.de, kernel@sberdevices.ru
Subject: Re: [PATCH v3 0/8] Add SM uclass and Meson SM driver
Date: Thu, 12 Oct 2023 16:45:48 +0200 [thread overview]
Message-ID: <c6a96994-71f7-4b27-8d95-42f6003512c3@linaro.org> (raw)
In-Reply-To: <20230921081346.22157-1-avromanov@salutedevices.com>
Hi,
On 21/09/2023 10:13, Alexey Romanov wrote:
> Hello!
>
> At the moment, there is no single general approach to using
> secure monitor in U-Boot, there is only the smc_call() function,
> over which everyone builds their own add-ons. This patchset
> is designed to solve this problem by adding a new uclass -
> SM_UCLASS. This UCLASS export following generic API:
>
> 1. sm_call() - generic SMC call to the secure-monitor
> 2. sm_call_read() - retrieve data from secure-monitor
> 3. sm_call_write() - send data to secure-monitor
>
> In the future, it is necessary to completely get rid of raw
> smc_call() calls, replacing them with the use of SM_UCLASS
> based drivers.
>
> V2:
>
> - Add SM UCLASS
> - Add SM sandbox driver
> - Add test for sandbox driver
> - Meson Secure Monitor driver now based on SM_UCLASS
> - Fix include order in arch/arm/mach-meson/sm.c
>
> Also, during the discussion in V1 of this patchset, it was
> discussed to create MESON_SM_UCLASS, but I considered such
> a uclass to be too arch-specific. That's why I suggest
> SM_UCLASS, which is not so arch-specific: secure monitor can
> used for whole ARM devices, not only for Amlogic SoC's.
>
> V3:
>
> - Fix typos in commit messages
> - Use uclass_first_device_err() instead of uclass_get_device_by_name()
> - Return -ENOSYS instead of -EPROTONOSUPPORT if SM_UCLASS option not
> implemented
>
> Alexey Romanov (8):
> drivers: introduce Secure Monitor uclass
> sandbox: add sandbox sm uclass driver
> sandbox: dts: add meson secure monitor node
> sandbox: add tests for UCLASS_SM
> sandbox: defconfig: enable CONFIG_SM option
> drivers: introduce Meson Secure Monitor driver
> arch: meson: sm: set correct order of the includes
> arch: meson: use secure monitor driver
>
> MAINTAINERS | 1 +
> arch/arm/mach-meson/Kconfig | 1 +
> arch/arm/mach-meson/sm.c | 116 +++++++++++----------
> arch/sandbox/dts/test.dts | 4 +
> configs/sandbox_defconfig | 1 +
> drivers/Kconfig | 2 +
> drivers/Makefile | 1 +
> drivers/sm/Kconfig | 9 ++
> drivers/sm/Makefile | 5 +
> drivers/sm/meson-sm.c | 198 ++++++++++++++++++++++++++++++++++++
> drivers/sm/sandbox-sm.c | 76 ++++++++++++++
> drivers/sm/sm-uclass.c | 55 ++++++++++
> include/dm/uclass-id.h | 1 +
> include/meson/sm.h | 19 ++++
> include/sandbox-sm.h | 18 ++++
> include/sm-uclass.h | 72 +++++++++++++
> include/sm.h | 67 ++++++++++++
> test/dm/Makefile | 1 +
> test/dm/sm.c | 65 ++++++++++++
> 19 files changed, 656 insertions(+), 56 deletions(-)
> create mode 100644 drivers/sm/Kconfig
> create mode 100644 drivers/sm/Makefile
> create mode 100644 drivers/sm/meson-sm.c
> create mode 100644 drivers/sm/sandbox-sm.c
> create mode 100644 drivers/sm/sm-uclass.c
> create mode 100644 include/meson/sm.h
> create mode 100644 include/sandbox-sm.h
> create mode 100644 include/sm-uclass.h
> create mode 100644 include/sm.h
> create mode 100644 test/dm/sm.c
>
This serie breaks other boards:
+binman: Error 1 running 'mkimage -d ./mkimage-in-simple-bin.mkimage-u-boot-tpl:./mkimage-in-simple-bin.mkimage-u-boot-spl -n px30 -T rksd ./idbloader.img': Error: SPL image is too large (size 0x3000 than 0x2800)
+Error: Bad parameters for image type
+Usage: mkimage [-T type] -l image
+ -l ==> list image header information
+ -T ==> parse image file as 'type'
+ -q ==> quiet
+ mkimage [-x] -A arch -O os -T type -C comp -a addr -e ep -n name -d data_file[:data_file...] image
+ -A ==> set architecture to 'arch'
+ -O ==> set operating system to 'os'
+ -T ==> set image type to 'type'
+ -C ==> set compression type 'comp'
+ -a ==> set load address to 'addr' (hex)
+ -e ==> set entry point to 'ep' (hex)
+ -n ==> set image name to 'name'
+ -R ==> set second image name to 'name'
+ -d ==> use image data from 'datafile'
+ -x ==> set XIP (execute in place)
+ -s ==> create an image with no data
+ -v ==> verbose
+ mkimage [-D dtc_options] [-f fit-image.its|-f auto|-f auto-conf|-F] [-b <dtb> [-b <dtb>]] [-E] [-B size] [-i <ramdisk.cpio.gz>] fit-image
+ <dtb> file is used with -f auto, it may occur multiple times.
+ -D => set all options for device tree compiler
+ -f => input filename for FIT source
+ -i => input filename for ramdisk file
+ -E => place data outside of the FIT structure
+ -B => align size in hex for FIT structure and, with -E, for the external data
+ -b => append the device tree binary to the FIT
+ -t => update the timestamp in the FIT
+Signing / verified boot options: [-k keydir] [-K dtb] [ -c <comment>] [-p addr] [-r] [-N engine]
+ -k => set directory containing private keys
+ -K => write public keys to this .dtb file
+ -g => set key name hint
+ -G => use this signing key (in lieu of -k)
+ -c => add comment in signature node
+ -F => re-sign existing FIT image
+ -p => place external data at a static position
+ -r => mark keys used as 'required' in dtb
+ -N => openssl engine to use for signing
+ -o => algorithm to use for signing
+ mkimage -V ==> print version information and exit
+Use '-T list' to see a list of available image types
+Long options are available; read the man page for details
+make[1]: *** [Makefile:1124: .binman_stamp] Error 1
+make: *** [Makefile:177: sub-make] Error 2
PLease see: https://source.denx.de/u-boot/custodians/u-boot-amlogic/-/jobs/710823#L2912
Neil
prev parent reply other threads:[~2023-10-12 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230921081346.22157-1-avromanov@salutedevices.com>
2023-09-28 9:01 ` [PATCH v3 0/8] Add SM uclass and Meson SM driver Neil Armstrong
2023-09-28 9:08 ` Neil Armstrong
[not found] ` <20230921081346.22157-7-avromanov@salutedevices.com>
2023-10-04 16:00 ` [PATCH v3 6/8] drivers: introduce Meson Secure Monitor driver Neil Armstrong
2023-10-12 14:45 ` neil.armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6a96994-71f7-4b27-8d95-42f6003512c3@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=avromanov@salutedevices.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=kernel@sberdevices.ru \
--cc=marex@denx.de \
--cc=msuchanek@suse.de \
--cc=narmstrong@baylibre.com \
--cc=paul.barker@sancloud.com \
--cc=post@lespocky.de \
--cc=sjg@google.com \
--cc=sughosh.ganu@linaro.org \
--cc=takahiro.akashi@linaro.org \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).