From: Simon Glass <sjg@chromium.org>
To: Tom Rini <trini@konsulko.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Jerome Brunet <jbrunet@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
u-boot-amlogic@groups.io
Subject: Re: [PATCH] pinctrl: meson: Correct the driver GPIO declaration
Date: Sat, 13 Nov 2021 07:08:18 -0700 [thread overview]
Message-ID: <CAPnjgZ0mGRXYo7bw5rXq9ESPWFOmdo1XqPewSOGynfHV_VEQ8A@mail.gmail.com> (raw)
In-Reply-To: <20211113040834.GV24579@bill-the-cat>
Hi Tom,
On Fri, 12 Nov 2021 at 21:08, Tom Rini <trini@konsulko.com> wrote:
>
> On Fri, Nov 12, 2021 at 07:00:34PM -0700, Simon Glass wrote:
>
> > This should use the provided U_BOOT_DRIVER() macro so that the driver gets
> > added to the appropriate linker list. Fix it.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > Fixes: 7c9dcfed50f ("pinctrl: meson: rework gx pmx function")
>
> Doesn't build for me:
> /home/trini/work/u-boot/u-boot/drivers/pinctrl/meson/pinctrl-meson-gxl.c:704:28:
> error: 'meson_
> gx_gpio_driver' undeclared here (not in a function); did you mean
> 'meson_gpio_probe'?
> 704 | .gpio_driver = &meson_gx_gpio_driver,
> | ^~~~~~~~~~~~~~~~~~~~
> | meson_gpio_probe
>
> For libretech-cc
Oh I only fixed one driver and was building odroid-c2 (just a guess).
I will send v2 that works with 'buildman meson'.
Regards,
Simon
prev parent reply other threads:[~2021-11-13 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 2:00 [PATCH] pinctrl: meson: Correct the driver GPIO declaration Simon Glass
2021-11-13 4:08 ` Tom Rini
2021-11-13 14:08 ` Simon Glass [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ0mGRXYo7bw5rXq9ESPWFOmdo1XqPewSOGynfHV_VEQ8A@mail.gmail.com \
--to=sjg@chromium.org \
--cc=jbrunet@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=trini@konsulko.com \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).