From: Simon Glass <sjg@chromium.org>
To: Artem Lapkin <email2tema@gmail.com>
Cc: trini@konsulko.com, marek.behun@nic.cz, narmstrong@baylibre.com,
TWarren@nvidia.com, andre.przywara@arm.com, u-boot@lists.denx.de,
u-boot-amlogic@groups.io, christianshewitt@gmail.com,
art@khadas.com, nick@khadas.com, gouwa@khadas.com
Subject: Re: [PATCH v2 1/2] env: setenv add resolve value option
Date: Wed, 24 Nov 2021 17:13:06 -0700 [thread overview]
Message-ID: <CAPnjgZ0ejPwkwDua9exAU=bLgUUUFVVBcczftxwYSGGeRzrCzA@mail.gmail.com> (raw)
In-Reply-To: <20211119043647.1251416-2-art@khadas.com>
On Thu, 18 Nov 2021 at 21:37, Artem Lapkin <email2tema@gmail.com> wrote:
>
> Add possibility setup env variable with additional resolving vars inside
> value.
>
> Usage examples:
>
> => setenv a hello; setenv b world; setenv c '${a} ${b}'
> => setenv -r d '${c}! ${a}...'
> => printenv d
> d=hello world! hello...
>
> /* internal usage example */
> env_resolve("d", "${c}! ${a}...");
> /* d="hello world! hello..." */
>
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
> V2 changes:
> _ fix comments style
> _ add comment include/exports.h
> _ remake strcpy to strdup
> _ env_resolve minimize
> ---
> cmd/nvedit.c | 43 ++++++++++++++++++++++++++++++++++++++++++-
> include/_exports.h | 1 +
> include/env.h | 11 +++++++++++
> include/exports.h | 2 ++
> 4 files changed, 56 insertions(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
next prev parent reply other threads:[~2021-11-25 0:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 4:36 [PATCH v2 0/2] env: setenv add resolve value option Artem Lapkin
2021-11-19 4:36 ` [PATCH v2 1/2] " Artem Lapkin
2021-11-25 0:13 ` Simon Glass [this message]
2021-11-19 4:36 ` [PATCH v2 2/2] test: env: deep resolve value testing Artem Lapkin
2021-11-25 0:13 ` Simon Glass
2021-11-19 7:48 ` [PATCH v2 0/2] env: setenv add resolve value option Wolfgang Denk
2021-11-19 9:06 ` Art Nikpal
2021-11-20 12:36 ` Wolfgang Denk
2021-11-22 8:25 ` Art Nikpal
[not found] ` <6198ebca.1c69fb81.fc50c.bf0bSMTPIN_ADDED_BROKEN@mx.google.com>
2021-11-22 8:09 ` Art Nikpal
2021-11-22 8:51 ` Wolfgang Denk
2021-11-22 10:06 ` Art Nikpal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ0ejPwkwDua9exAU=bLgUUUFVVBcczftxwYSGGeRzrCzA@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=TWarren@nvidia.com \
--cc=andre.przywara@arm.com \
--cc=art@khadas.com \
--cc=christianshewitt@gmail.com \
--cc=email2tema@gmail.com \
--cc=gouwa@khadas.com \
--cc=marek.behun@nic.cz \
--cc=narmstrong@baylibre.com \
--cc=nick@khadas.com \
--cc=trini@konsulko.com \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).