From: Simon Glass <sjg@chromium.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: u-boot@lists.denx.de, Matthias Brugger <mbrugger@suse.com>,
Anatolij Gustschin <agust@denx.de>, Da Xue <da@libre.computer>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Andre Przywara <andre.przywara@arm.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Kever Yang <kever.yang@rock-chips.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
uboot-stm32@st-md-mailman.stormreply.com,
u-boot-amlogic@groups.io, Alexander Graf <agraf@csgraf.de>
Subject: Re: [PATCH v4 7/9] video: Use VIDEO_DAMAGE for VIDEO_COPY
Date: Sun, 8 Jan 2023 08:48:47 -0700 [thread overview]
Message-ID: <CAPnjgZ0Bw9=oVC5gy_d4x5DeWHWJt_Uyq2EdXoxbY1o1Zmzw5Q@mail.gmail.com> (raw)
In-Reply-To: <b03e611b-2150-9bf9-0cb1-b15752ef9ae5@gmx.de>
Hi Heinrich,
On Sat, 7 Jan 2023 at 16:22, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 1/7/23 01:13, Simon Glass wrote:
> > Hi Alexander,
> >
> > On Tue, 3 Jan 2023 at 14:50, Alexander Graf <agraf@csgraf.de> wrote:
> >>
> >> CONFIG_VIDEO_COPY implemented a range based copying mechanism: If we
> >
> > range-based
> >
> >> print a single character, it will always copy the full range of bytes
> >> from the top left corner of the character to the lower right onto the
> >> uncached frame buffer. This includes pretty much the full line contents
> >> of the printed character.
> >>
> >> Since we now have proper damage tracking, let's make use of that to reduce
> >> the amount of data we need to copy. With this patch applied, we will only
> >> copy the tiny rectangle surrounding characters when we print them,
> >> speeding up the video console.
> >>
> >> As a bonus, we remove a lot of code.
> >>
> >> Signed-off-by: Alexander Graf <agraf@csgraf.de>
> >>
> >> ---
> >>
> >> v2 -> v3:
> >>
> >> - Rebase
> >> - Make CONFIG_COPY always select VIDEO_DAMAGE
> >> ---
> >> drivers/video/Kconfig | 5 ++
> >> drivers/video/console_normal.c | 14 +----
> >> drivers/video/console_rotate.c | 37 ++-----------
> >> drivers/video/console_truetype.c | 17 +-----
> >> drivers/video/vidconsole-uclass.c | 16 ------
> >> drivers/video/video-uclass.c | 91 ++++++++-----------------------
> >> drivers/video/video_bmp.c | 7 ---
> >> include/video.h | 37 -------------
> >> include/video_console.h | 49 -----------------
> >> 9 files changed, 37 insertions(+), 236 deletions(-)
> >>
> >
> > This feature needs some tests in test/dm/video.c
> >
> > For sandbox, I think you will need to allow it to be enabled /
> > disabled at runtime, so the some tests can use it and some not?
>
> It should be good enough to enable the feature in one of the sandbox
> defconfigs and disable it in another.
Yes that would work, e.g. enable in sandbox but not sandbox_flattree
Regards,
Simon
next prev parent reply other threads:[~2023-01-08 15:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230103215004.22646-1-agraf@csgraf.de>
[not found] ` <20230103215004.22646-6-agraf@csgraf.de>
2023-01-04 12:50 ` [PATCH v4 5/9] efi_loader: GOP: Add damage notification on BLT Heinrich Schuchardt
[not found] ` <20230103215004.22646-2-agraf@csgraf.de>
2023-01-07 0:13 ` [PATCH v4 1/9] dm: video: Add damage tracking API Simon Glass
[not found] ` <20230103215004.22646-3-agraf@csgraf.de>
2023-01-07 0:13 ` [PATCH v4 2/9] dm: video: Add damage notification on display clear Simon Glass
[not found] ` <20230103215004.22646-4-agraf@csgraf.de>
2023-01-07 0:13 ` [PATCH v4 3/9] vidconsole: Add damage notifications to all vidconsole drivers Simon Glass
[not found] ` <20230103215004.22646-5-agraf@csgraf.de>
2023-01-07 0:13 ` [PATCH v4 4/9] video: Add damage notification on bmp display Simon Glass
[not found] ` <20230103215004.22646-7-agraf@csgraf.de>
2023-01-07 0:13 ` [PATCH v4 6/9] video: Only dcache flush damaged lines Simon Glass
[not found] ` <20230103215004.22646-8-agraf@csgraf.de>
2023-01-07 0:13 ` [PATCH v4 7/9] video: Use VIDEO_DAMAGE for VIDEO_COPY Simon Glass
2023-01-07 22:40 ` Heinrich Schuchardt
2023-01-08 15:48 ` Simon Glass [this message]
2023-01-07 0:13 ` [PATCH v4 0/9] Add video damage tracking Simon Glass
[not found] ` <20230103215004.22646-9-agraf@csgraf.de>
2023-01-07 0:13 ` [PATCH v4 8/9] video: Always compile cache flushing code Simon Glass
[not found] ` <20230103215004.22646-10-agraf@csgraf.de>
2023-01-04 12:32 ` [PATCH v4 9/9] video: Enable VIDEO_DAMAGE for drivers that need it Neil Armstrong
2023-01-07 0:13 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ0Bw9=oVC5gy_d4x5DeWHWJt_Uyq2EdXoxbY1o1Zmzw5Q@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=agraf@csgraf.de \
--cc=agust@denx.de \
--cc=andre.przywara@arm.com \
--cc=da@libre.computer \
--cc=ilias.apalodimas@linaro.org \
--cc=jagan@amarulasolutions.com \
--cc=kever.yang@rock-chips.com \
--cc=mbrugger@suse.com \
--cc=neil.armstrong@linaro.org \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=philipp.tomsich@vrull.eu \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).