From: Peter Robinson <pbrobinson@gmail.com>
To: neil.armstrong@linaro.org
Cc: Tom Rini <trini@konsulko.com>,
u-boot@lists.denx.de, u-boot-amlogic@groups.io,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH] libretech-cc: Populate SMBIOS information
Date: Wed, 22 Nov 2023 20:02:22 +0000 [thread overview]
Message-ID: <CALeDE9PGErp+wDRR3VDvHNZc6_3ph=vDuvR-dk3TAWBrppayoA@mail.gmail.com> (raw)
In-Reply-To: <ec846ff6-a60b-4eb8-906c-0de6e11b5d9d@linaro.org>
On Tue, Nov 21, 2023 at 2:50 PM Neil Armstrong
<neil.armstrong@linaro.org> wrote:
>
> On 21/11/2023 15:09, Tom Rini wrote:
> > On Tue, Nov 21, 2023 at 02:46:29PM +0100, Neil Armstrong wrote:
> >> On 21/11/2023 14:15, Tom Rini wrote:
> >>> On Tue, Nov 21, 2023 at 10:18:04AM +0100, Neil Armstrong wrote:
> >>>> Hi Tom,
> >>>>
> >>>> On 20/11/2023 21:16, Tom Rini wrote:
> >>>>> Enable CONFIG_SYSINFO_SMBIOS and populate the nodes so that Linux can
> >>>>> eventually display this information
> >>>>>
> >>>>> Signed-off-by: Tom Rini <trini@konsulko.com>
> >>>>> ---
> >>>>> Posting this as this was the easiest platform for me to test some SMBIOS
> >>>>> related patches on and I needed to populate the nodes so I could check
> >>>>> things in dmidecode once Linux was up.
> >>>>
> >>>> Sorry to be late a the party, but can't this be dynamically found from DT's compatible & model ?
> >>>> Since I'll probably need to add this to all boards, it seems like a duplicate of what's already in the DT.
> >>>
> >>> Part of the "fun" as to why we have the binding here is that while we
> >>> could use the top-level model property, there's not a corresponding one
> >>> for manufacturer. I'm fine ignoring the patch I posted here and having a
> >>> longer discussion about populating SMBIOS more usefully, globally, as I
> >>> think has been suggested a time or two.
> >>>
> >>
> >> I'm ok landing it with the same data as from the vendor.
> >> but couldn't we use the first top-level compatible as default smbios data ?
> >>
> >> compatible = "vendor1,board-name", "vendor1,soc-name";
> >>
> >> and translate to:
> >>
> >>
> >> smbios {
> >> system {
> >> manufacturer = "vendor1";
> >> product = "board-name";
> >> };
> >>
> >> baseboard {
> >> manufacturer = "vendor1";
> >> product = "board-name";
> >> };
> >>
> >> chassis {
> >> manufacturer = "vendor1";
> >> product = "board-name";
> >> };
> >> };
> >>
> >> since the vendor name should be already documented in the linux
> >> bindings, same for the board name.
> >> And we would be free to add some custom data in the DT if needed.
> >>
> >> Anyway, not sure it's the right place to discuss about that !
> >
> > That's essentially
> > https://patchwork.ozlabs.org/project/uboot/patch/20220906134426.53748-2-ilias.apalodimas@linaro.org/
> > which had a bunch of comments on 1/2:
> > https://patchwork.ozlabs.org/project/uboot/patch/20220906134426.53748-1-ilias.apalodimas@linaro.org/
> >
> > But I think that since then some thoughts on the subject have changed
> > and that approach might be more welcome now than it was then.
> >
>
> Thanks for the pointer, seems I had the exact same idea.
> Hope this will be re-spinned, I don't want to add this to the 45 amlogic
> boards when we have the necessary info already available and documented...
Fedora has carried this patch for some time for the same reason, a lot
of the tools in distros around support use dmidecode for HW
information and reporting "Unknown" meant there was lots of reports
against tools all over the place. I'd been asking Ilias to upstream it
for a while so I'm in full agreement here and he did mention he would
resend it soon :)
Peter
prev parent reply other threads:[~2023-11-23 13:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 20:16 [PATCH] libretech-cc: Populate SMBIOS information Tom Rini
2023-11-21 2:16 ` Simon Glass
2023-11-21 9:18 ` Neil Armstrong
2023-11-21 13:15 ` Tom Rini
2023-11-21 13:46 ` Neil Armstrong
2023-11-21 14:09 ` Tom Rini
2023-11-21 14:43 ` Neil Armstrong
2023-11-21 15:07 ` Ilias Apalodimas
2023-11-22 20:02 ` Peter Robinson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALeDE9PGErp+wDRR3VDvHNZc6_3ph=vDuvR-dk3TAWBrppayoA@mail.gmail.com' \
--to=pbrobinson@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).