From: Art Nikpal <email2tema@gmail.com>
To: Tom Rini <trini@konsulko.com>
Cc: Simon Glass <sjg@chromium.org>,
marek.behun@nic.cz, Neil Armstrong <narmstrong@baylibre.com>,
Tom Warren <twarren@nvidia.com>,
Andre Przywara <andre.przywara@arm.com>,
U-Boot Mailing List <u-boot@lists.denx.de>,
u-boot-amlogic@groups.io, Artem Lapkin <art@khadas.com>,
Nick Xie <nick@khadas.com>, Gouwa Wang <gouwa@khadas.com>
Subject: Re: [PATCH v1] env: setenv add resolve value option
Date: Wed, 3 Nov 2021 15:41:32 +0800 [thread overview]
Message-ID: <CAKaHn9LVEoiJDtCVdyHzYoi-0yQsFnJ5+jXVw-YYXznTsjdKMw@mail.gmail.com> (raw)
In-Reply-To: <20211102164454.GQ24579@bill-the-cat>
> The high level problem I have with this patch is that we keep going back
> to "we really need to update to a modern hush (or other shell) rather
> than patching new features in to our ancient fork".
Yes it will be fine ! Does anybody have information about these plans ?
but in any case my patch didn't broke compatibility like next patch
> See also this old patch:
> https://patchwork.ozlabs.org/project/uboot/patch/1449255744-25787-1-git-send-email-nm@ti.com/
> Can you please add to the env tests?
> please add function comment
> ...
tnx for suggestions ...
i can make v2 variant for my patch , if no one is against this idea
On Wed, Nov 3, 2021 at 12:44 AM Tom Rini <trini@konsulko.com> wrote:
>
> On Tue, Nov 02, 2021 at 03:19:14PM +0800, Artem Lapkin wrote:
>
> > Add possibility setup env variable with additional resolving vars inside
> > value.
> >
> > Usage examples
> >
> > => setenv a hello
> > => setenv b world
> > => setenv c '${a} ${b}'
> > => setenv -r d '${c}! ${a}...'
> > => printenv d
> > d=hello world! hello...
> >
> > /* internal usage example */
> > env_resolve("d", "${c}! ${a}...");
> > /* d="hello world! hello..." */
> >
> > Notes
> >
> > Resolving works only for ${var} "bracket" and didn't workd for
> > "unbracket" $var
> >
> > => setenv -r d '$c! $a...'
> > => printenv d
> > d=$c! $a...
> >
> > Signed-off-by: Artem Lapkin <art@khadas.com>
>
> The high level problem I have with this patch is that we keep going back
> to "we really need to update to a modern hush (or other shell) rather
> than patching new features in to our ancient fork".
>
> --
> Tom
prev parent reply other threads:[~2021-11-03 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 7:19 [PATCH v1] env: setenv add resolve value option Artem Lapkin
2021-11-02 14:58 ` Simon Glass
2021-11-02 16:44 ` Tom Rini
2021-11-03 7:41 ` Art Nikpal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKaHn9LVEoiJDtCVdyHzYoi-0yQsFnJ5+jXVw-YYXznTsjdKMw@mail.gmail.com \
--to=email2tema@gmail.com \
--cc=andre.przywara@arm.com \
--cc=art@khadas.com \
--cc=gouwa@khadas.com \
--cc=marek.behun@nic.cz \
--cc=narmstrong@baylibre.com \
--cc=nick@khadas.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=twarren@nvidia.com \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).