From: Art Nikpal <email2tema@gmail.com>
To: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Tom Warren <TWarren@nvidia.com>,
Andre Przywara <andre.przywara@arm.com>,
U-Boot Mailing List <u-boot@lists.denx.de>,
u-boot-amlogic@groups.io, Artem Lapkin <art@khadas.com>,
Nick Xie <nick@khadas.com>, Gouwa Wang <gouwa@khadas.com>
Subject: Re: [PATCH] image: fix select_ramdisk for raw initrd
Date: Mon, 1 Nov 2021 15:00:47 +0800 [thread overview]
Message-ID: <CAKaHn9JQyO06-nKftOmMEXaywLt-7Z8wYimtwFfq26R_mgd62A@mail.gmail.com> (raw)
In-Reply-To: <AN6A0QAgIIdLnqeOIKHW84rw.9.1635724039553.Hmail.art@khadas.com>
Hi Simon, Tom , and ...
> Do we need this patch as well as the other one? If so, can you combine them?
> Also, is it possible to drop the assignment to rd_addr at the top of
the function?
this patch must be replaced by another one
https://patchwork.ozlabs.org/project/uboot/patch/20211016051915.4157293-1-art@khadas.com/
( last patch will be enough alone)
On Mon, Nov 1, 2021 at 7:47 AM Simon Glass <sjg@chromium.org> wrote:
>
> Hi Artem,
>
> On Fri, 15 Oct 2021 at 04:15, Artem Lapkin <email2tema@gmail.com> wrote:
> >
> > Problem
> >
> > We have unbootable raw initrd images because, select_ramdisk for raw
> > initrd images ignore submited select addr and setup rd_datap value to 0
> >
> > Solution: setup rd_datap value from select
> >
> > Signed-off-by: Artem Lapkin <art@khadas.com>
> > ---
> > common/image-board.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Do we need this patch as well as the other one? If so, can you combine them?
>
> Also, is it possible to drop the assignment to rd_addr at the top of
> the function?
>
> >
> > diff --git a/common/image-board.c b/common/image-board.c
> > index e7660352e9..e3c6ea806a 100644
> > --- a/common/image-board.c
> > +++ b/common/image-board.c
> > @@ -439,7 +439,7 @@ static int select_ramdisk(bootm_headers_t *images, const char *select, u8 arch,
> > end = strchr(select, ':');
> > if (end) {
> > *rd_lenp = hextoul(++end, NULL);
> > - *rd_datap = rd_addr;
> > + *rd_datap = hextoul(select, NULL);
> > processed = true;
> > }
> > }
> > --
> > 2.25.1
> >
>
> Regards,
> Simon
prev parent reply other threads:[~2021-11-01 7:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211015101501.4091141-1-art@khadas.com>
2021-10-31 23:47 ` [PATCH] image: fix select_ramdisk for raw initrd Simon Glass
[not found] ` <AN6A0QAgIIdLnqeOIKHW84rw.9.1635724039553.Hmail.art@khadas.com>
2021-11-01 7:00 ` Art Nikpal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKaHn9JQyO06-nKftOmMEXaywLt-7Z8wYimtwFfq26R_mgd62A@mail.gmail.com \
--to=email2tema@gmail.com \
--cc=TWarren@nvidia.com \
--cc=andre.przywara@arm.com \
--cc=art@khadas.com \
--cc=gouwa@khadas.com \
--cc=narmstrong@baylibre.com \
--cc=nick@khadas.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).