From: Simon Glass <sjg@chromium.org>
To: Tom Rini <trini@konsulko.com>
Cc: Sumit Garg <sumit.garg@linaro.org>,
u-boot@lists.denx.de, u-boot-amlogic@groups.io,
u-boot-custodians@lists.denx.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor@kernel.org,
neil.armstrong@linaro.org, caleb.connolly@linaro.org,
ff@shokubai.tech, daniel.thompson@linaro.org,
dgilmore@fedoraproject.org, pbrobinson@gmail.com,
ilias.apalodimas@linaro.org, maxim.uvarov@linaro.org,
b.galvani@gmail.com, xypron.glpk@gmx.de, michal.simek@amd.com,
seanga2@gmail.com, rasmus.villemoes@prevas.dk, peng.fan@nxp.com,
jh80.chung@samsung.com, rfried.dev@gmail.com, marex@denx.de,
mibodhi@gmail.com
Subject: Re: [PATCH v3 7/8] dts: meson-gxbb: Switch to using upstream DT
Date: Thu, 28 Dec 2023 15:09:41 +0000 [thread overview]
Message-ID: <CAFLszThP+GJcPP_LJBva1M5mi9Wj-Nh-z7A6-fkSpPgOTtLmRQ@mail.gmail.com> (raw)
In-Reply-To: <20231228135642.GA2652760@bill-the-cat>
Hi Tom,
On Thu, Dec 28, 2023 at 1:56 PM Tom Rini <trini@konsulko.com> wrote:
>
> On Thu, Dec 28, 2023 at 01:37:11PM +0000, Simon Glass wrote:
> > Hi Sumit,
> >
> > On Thu, Dec 28, 2023 at 11:59 AM Sumit Garg <sumit.garg@linaro.org> wrote:
> > >
> > > Although there were still some variations in board DTS files based on
> > > meson-gxbb SoC but I think those were minor differences from upstream
> > > and shouldn't impact boot on these devices.
> > >
> > > So switch to upstream DT via mirroring amlogic/ directory from
> > > devicetree-rebasing/src/arm64/amlogic/ directory. And thereby directly
> > > building DTB from there including *-u-boot.dtsi files from
> > > arch/$(ARCH)/dts/ directory.
> > >
> > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
> > > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> > > ---
> > >
> > > Changes in v3:
> > > --------------
> > > - Dropped Makefile portion and enabled OF_UPSTREAM for SoC instead.
> > >
> > > Changes in v2:
> > > --------------
> > > - Picked up review tag
> > >
> > > arch/arm/mach-meson/Kconfig | 1 +
> > > configs/nanopi-k2_defconfig | 2 +-
> > > configs/odroid-c2_defconfig | 2 +-
> > > configs/p200_defconfig | 2 +-
> > > configs/p201_defconfig | 2 +-
> > > configs/videostrong-kii-pro_defconfig | 2 +-
> > > configs/wetek-hub_defconfig | 2 +-
> > > configs/wetek-play2_defconfig | 2 +-
> > > dts/arch/arm64/amlogic | 1 +
> > > 9 files changed, 9 insertions(+), 7 deletions(-)
> > > create mode 120000 dts/arch/arm64/amlogic
> > >
> >
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> >
> > > diff --git a/arch/arm/mach-meson/Kconfig b/arch/arm/mach-meson/Kconfig
> > > index d6c89058061..8ddb59161a0 100644
> > > --- a/arch/arm/mach-meson/Kconfig
> > > +++ b/arch/arm/mach-meson/Kconfig
> > > @@ -25,6 +25,7 @@ choice
> > > config MESON_GXBB
> > > bool "GXBB"
> > > select MESON_GX
> > > + imply OF_UPSTREAM
> > > help
> > > Select this if your SoC is an S905
> > >
> > > diff --git a/configs/nanopi-k2_defconfig b/configs/nanopi-k2_defconfig
> > > index 41dbf7981f8..2e1c756bf7a 100644
> > > --- a/configs/nanopi-k2_defconfig
> > > +++ b/configs/nanopi-k2_defconfig
> > > @@ -6,7 +6,7 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> > > CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x20000000
> > > CONFIG_ENV_SIZE=0x2000
> > > CONFIG_DM_GPIO=y
> > > -CONFIG_DEFAULT_DEVICE_TREE="meson-gxbb-nanopi-k2"
> > > +CONFIG_DEFAULT_DEVICE_TREE="amlogic/meson-gxbb-nanopi-k2"
> > > CONFIG_OF_LIBFDT_OVERLAY=y
> > > CONFIG_DM_RESET=y
> > > CONFIG_DEBUG_UART_BASE=0xc81004c0
> >
> > So now I am wondering if we can (later) have the SoC be implied when
> > using OF_UPSTREAM so we can do:
> >
> > CONFIG_DEFAULT_DEVICE_TREE="meson-gxbb-nanopi-k2"
> >
> > and it will add the 'amlogic/' automatically?
> >
> > Perhaps that might be a way to bridge the gap in terms of file layout?
>
> That's going to start to look real ugly real quick I suspect and I'm not
> sure what it really gets us? It seems to me that the convention of
> "vendor/board" has already been well enough adapted outside of the
> kernel, with the odd sticking point being getting everyone used to
> whatever will be happening for 32bit boards long term. So I think hiding
> the vendor part of the string here will be more, not less, confusing
> long term.
Now that I dig in a bit, I see that the devicetree-rebasing tree does
not have any Makefiles in it. How does Linux build with it? Does
anyone have instructions?
Regards,
Simon
next prev parent reply other threads:[~2024-01-08 8:14 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 11:57 [PATCH v3 0/8] An effort to bring DT bindings compliance within U-Boot Sumit Garg
2023-12-28 11:57 ` [PATCH v3 1/8] CI: Exclude devicetree-rebasing subtree for CONFIG checks Sumit Garg
2023-12-28 12:02 ` Ilias Apalodimas
2023-12-28 13:37 ` Simon Glass
2023-12-28 11:57 ` [PATCH v3 2/8] Makefile: Add support for DT bindings schema checks Sumit Garg
2023-12-28 13:37 ` Simon Glass
2023-12-28 11:57 ` [PATCH v3 3/8] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location Sumit Garg
2024-01-05 20:41 ` Bryan Brattlof
2024-01-08 7:18 ` Sumit Garg
2024-01-09 1:54 ` Bryan Brattlof
2024-01-09 5:08 ` Sumit Garg
2024-01-09 14:26 ` Bryan Brattlof
2023-12-28 11:58 ` [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds Sumit Garg
2023-12-28 13:37 ` Simon Glass
2023-12-28 14:03 ` Tom Rini
2023-12-28 15:09 ` Simon Glass
2023-12-28 15:54 ` Tom Rini
2023-12-28 19:48 ` Simon Glass
2023-12-28 20:31 ` Tom Rini
2023-12-29 15:30 ` Sumit Garg
2023-12-31 14:28 ` Simon Glass
2023-12-31 20:39 ` Tom Rini
2024-01-01 0:33 ` Mark Kettenis
2024-01-01 22:32 ` Simon Glass
2024-01-01 23:35 ` Tom Rini
2024-01-02 14:06 ` Simon Glass
2024-01-02 15:10 ` Tom Rini
2024-01-02 23:54 ` Simon Glass
2024-01-03 0:41 ` Tom Rini
2024-01-04 1:42 ` Simon Glass
2024-01-02 15:37 ` Sumit Garg
2024-01-02 18:06 ` Tom Rini
2024-01-03 6:57 ` Sumit Garg
2024-01-03 13:23 ` Tom Rini
2024-01-03 7:06 ` Sumit Garg
2024-01-02 12:50 ` Caleb Connolly
2024-01-02 14:06 ` Simon Glass
2024-01-04 12:23 ` Sumit Garg
2023-12-28 11:58 ` [PATCH v3 5/8] doc: devicetree: Updates for devicetree-rebasing subtree Sumit Garg
2023-12-28 12:58 ` Tom Rini
2023-12-28 13:37 ` Simon Glass
2023-12-28 14:10 ` Tom Rini
2024-01-03 16:19 ` Rob Herring
2024-01-03 16:32 ` Tom Rini
2024-01-04 9:46 ` Sumit Garg
2024-01-04 10:08 ` Michal Simek
2024-01-04 13:22 ` Sumit Garg
2024-01-04 13:50 ` Tom Rini
2024-01-04 14:45 ` Michal Simek
2024-01-04 15:30 ` Tom Rini
2024-01-04 15:50 ` Michal Simek
2024-01-04 18:03 ` Tom Rini
2024-01-05 8:16 ` Michal Simek
2024-01-05 11:18 ` Sumit Garg
2023-12-28 11:58 ` [PATCH v3 6/8] MAINTAINERS: Add myself as devicetree-rebasing maintainer Sumit Garg
2023-12-28 13:37 ` Simon Glass
2023-12-28 11:58 ` [PATCH v3 7/8] dts: meson-gxbb: Switch to using upstream DT Sumit Garg
2023-12-28 13:37 ` Simon Glass
2023-12-28 13:56 ` Tom Rini
2023-12-28 15:09 ` Simon Glass [this message]
2023-12-28 15:25 ` Tom Rini
2023-12-28 19:48 ` Simon Glass
2023-12-28 20:32 ` Tom Rini
2023-12-31 12:47 ` Simon Glass
2023-12-28 11:58 ` [PATCH v3 8/8] dts: meson-gxbb: Drop redundant devicetree files Sumit Garg
2024-01-03 12:53 ` [PATCH v3 0/8] An effort to bring DT bindings compliance within U-Boot Michal Simek
2024-01-04 8:18 ` Sumit Garg
2024-01-04 11:25 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLszThP+GJcPP_LJBva1M5mi9Wj-Nh-z7A6-fkSpPgOTtLmRQ@mail.gmail.com \
--to=sjg@chromium.org \
--cc=b.galvani@gmail.com \
--cc=caleb.connolly@linaro.org \
--cc=conor@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=dgilmore@fedoraproject.org \
--cc=ff@shokubai.tech \
--cc=ilias.apalodimas@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=marex@denx.de \
--cc=maxim.uvarov@linaro.org \
--cc=mibodhi@gmail.com \
--cc=michal.simek@amd.com \
--cc=neil.armstrong@linaro.org \
--cc=pbrobinson@gmail.com \
--cc=peng.fan@nxp.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=rfried.dev@gmail.com \
--cc=robh+dt@kernel.org \
--cc=seanga2@gmail.com \
--cc=sumit.garg@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot-custodians@lists.denx.de \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).