From: "Mattijs Korpershoek" <mkorpershoek@baylibre.com>
To: Marek Vasut <marex@denx.de>,
Neil Armstrong <narmstrong@baylibre.com>,
Gary Bisson <gary.bisson@boundarydevices.com>,
u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>
Cc: lukma@denx.de, peter.chen@nxp.com, jun.li@nxp.com,
peng.fan@nxp.com, u-boot-amlogic@groups.io
Subject: Re: [PATCH] usb: gadget: dwc2_udc_otg: set ep's desc during enable/disable
Date: Fri, 07 Jan 2022 16:25:18 +0100 [thread overview]
Message-ID: <87pmp34lgh.fsf@baylibre.com> (raw)
In-Reply-To: <f2b7e565-9dd1-ba71-a143-6c629694be4c@denx.de>
Hi Gary,
Thank you for your patch.
Marek Vasut <marex@denx.de> writes:
> On 1/6/22 16:21, Neil Armstrong wrote:
>> Hi,
>>
>> On 06/01/2022 16:02, Gary Bisson wrote:
>>> Fastboot support has been broken on platforms using dwc2 controller
>>> since the gadget gets its max packet size from it.
>>> This patch is the equivalent of 723fd5668ff which fixed the same issue
>>> but for the chipidea controller.
>>>
>>> Fixes: 27c9141b111 ("usb: gadget: fastboot: use correct max packet size")
>>>
>>> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
>>> ---
>>> drivers/usb/gadget/dwc2_udc_otg.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/usb/gadget/dwc2_udc_otg.c b/drivers/usb/gadget/dwc2_udc_otg.c
>>> index 2f318144421..fb10884755b 100644
>>> --- a/drivers/usb/gadget/dwc2_udc_otg.c
>>> +++ b/drivers/usb/gadget/dwc2_udc_otg.c
>>> @@ -655,6 +655,7 @@ static int dwc2_ep_enable(struct usb_ep *_ep,
>>> return -ESHUTDOWN;
>>> }
>>>
>>> + _ep->desc = desc;
>>> ep->stopped = 0;
>>> ep->desc = desc;
>>
>> Indeed the _ep and ep was confusing when looking code
>>
>>> ep->pio_irqs = 0;
>>> @@ -695,6 +696,7 @@ static int dwc2_ep_disable(struct usb_ep *_ep)
>>> /* Nuke all pending requests */
>>> nuke(ep, -ESHUTDOWN);
>>>
>>> + _ep->desc = NULL;
>>> ep->desc = 0;
>>> ep->stopped = 1;
>>>
>>>
>>
>> An off-tree patch removed from our Yukawa backlog, thanks !
>>
>> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
I can confirm this fixes flashing issues on VIM3/VIM3L boards when
flashing AOSP(yukawa) with fastboot.
Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
>
> +CC Tom, can you pick this one for CURRENT 2022.01 release?
>
> Thank you
prev parent reply other threads:[~2022-01-07 15:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220106150208.1316946-1-gary.bisson@boundarydevices.com>
2022-01-06 15:21 ` [PATCH] usb: gadget: dwc2_udc_otg: set ep's desc during enable/disable Neil Armstrong
2022-01-06 19:55 ` Marek Vasut
2022-01-07 15:25 ` Mattijs Korpershoek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmp34lgh.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=gary.bisson@boundarydevices.com \
--cc=jun.li@nxp.com \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=narmstrong@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=peter.chen@nxp.com \
--cc=trini@konsulko.com \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).