u-boot-amlogic.groups.io archive mirror
 help / color / mirror / Atom feed
From: "Neil Armstrong" <neil.armstrong@linaro.org>
To: Igor Prusov <ivprusov@sberdevices.ru>
Cc: kernel@sberdevices.ru, prusovigor@gmail.com,
	u-boot@lists.denx.de, u-boot-amlogic@groups.io
Subject: Re: [RFC PATCH v1 5/5] board: amlogic: add support for AD401 board
Date: Fri, 5 May 2023 08:55:27 +0200	[thread overview]
Message-ID: <752bcedf-5792-7c43-0573-7fd4d81b54fc@linaro.org> (raw)
In-Reply-To: <20230424180151.9524-6-ivprusov@sberdevices.ru>

On 24/04/2023 20:01, Igor Prusov wrote:
> The AD401 board is the Amlogic A1 SoC reference board
> 
> Signed-off-by: Igor Prusov <ivprusov@sberdevices.ru>
> ---
>   MAINTAINERS                  |  1 +
>   arch/arm/mach-meson/Kconfig  |  1 +
>   board/amlogic/ad401/Makefile |  4 +++
>   board/amlogic/ad401/ad401.c  | 15 ++++++++++
>   configs/ad401_defconfig      | 54 ++++++++++++++++++++++++++++++++++++
>   5 files changed, 75 insertions(+)
>   create mode 100644 board/amlogic/ad401/Makefile
>   create mode 100644 board/amlogic/ad401/ad401.c
>   create mode 100644 configs/ad401_defconfig
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 02a5a8682f..6860309896 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -150,6 +150,7 @@ L:	u-boot-amlogic@groups.io
>   T:	git https://source.denx.de/u-boot/custodians/u-boot-amlogic.git
>   F:	arch/arm/mach-meson/
>   F:	arch/arm/include/asm/arch-meson/
> +F:	board/amlogic/

Boards MAINTAINERS are separate, so please add a separate MAINTAINERS
file in board/amlogic/ad401/, you can add me ad maintainer like other
boards.

>   F:	cmd/meson/
>   F:	drivers/clk/meson/
>   F:	drivers/serial/serial_meson.c
> diff --git a/arch/arm/mach-meson/Kconfig b/arch/arm/mach-meson/Kconfig
> index 519ed563c0..669ca09a00 100644
> --- a/arch/arm/mach-meson/Kconfig
> +++ b/arch/arm/mach-meson/Kconfig
> @@ -75,6 +75,7 @@ config SYS_VENDOR
>   
>   config SYS_BOARD
>   	string "Board name"
> +	default "ad401" if MESON_A1
>   	default "p200" if MESON_GXBB
>   	default "p212" if MESON_GXL
>   	default "q200" if MESON_GXM
> diff --git a/board/amlogic/ad401/Makefile b/board/amlogic/ad401/Makefile
> new file mode 100644
> index 0000000000..e65c1215f6
> --- /dev/null
> +++ b/board/amlogic/ad401/Makefile
> @@ -0,0 +1,4 @@
> +# SPDX-License-Identifier: GPL-2.0+
> +# (C) Copyright 2023 SberDevices, Inc.
> +
> +obj-y	:= ad401.o
> diff --git a/board/amlogic/ad401/ad401.c b/board/amlogic/ad401/ad401.c
> new file mode 100644
> index 0000000000..356b2880bd
> --- /dev/null
> +++ b/board/amlogic/ad401/ad401.c
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * (C) Copyright 2023 SberDevices, Inc.
> + * Author: Igor Prusov <ivprusov@sberdevices.ru>
> + */
> +
> +#include <init.h>
> +#include <asm/arch/eth.h>
> +
> +int misc_init_r(void)
> +{
> +	meson_generate_serial_ethaddr();
> +
> +	return 0;
> +}
> diff --git a/configs/ad401_defconfig b/configs/ad401_defconfig
> new file mode 100644
> index 0000000000..529e553bac
> --- /dev/null
> +++ b/configs/ad401_defconfig
> @@ -0,0 +1,54 @@
> +CONFIG_ARM=y
> +CONFIG_ARCH_MESON=y
> +CONFIG_TEXT_BASE=0x00000000
> +CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> +CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x00200000
> +CONFIG_DM_GPIO=y
> +CONFIG_DEFAULT_DEVICE_TREE="meson-a1-ad401"
> +CONFIG_SYS_PROMPT="ad401 # "
> +CONFIG_OF_LIBFDT_OVERLAY=y
> +CONFIG_MESON_A1=y
> +CONFIG_DEBUG_UART_BASE=0xfe001c00
> +CONFIG_DEBUG_UART_CLOCK=24000000
> +CONFIG_SYS_LOAD_ADDR=0x0
> +CONFIG_DEBUG_UART=y
> +CONFIG_ANDROID_BOOT_IMAGE=y
> +CONFIG_FIT=y
> +CONFIG_FIT_SIGNATURE=y
> +CONFIG_OF_BOARD_SETUP=y
> +CONFIG_BOOTCOMMAND="run storeboot"
> +# CONFIG_DISPLAY_CPUINFO is not set
> +# CONFIG_DISPLAY_BOARDINFO is not set
> +# CONFIG_CMD_BDI is not set
> +# CONFIG_CMD_IMI is not set
> +CONFIG_CMD_GPIO=y
> +CONFIG_CMD_I2C=y
> +# CONFIG_CMD_LOADB is not set
> +# CONFIG_CMD_LOADS is not set
> +CONFIG_CMD_MMC=y
> +CONFIG_CMD_MTD=y
> +# CONFIG_CMD_SETEXPR is not set
> +CONFIG_CMD_CACHE=y
> +CONFIG_CMD_MTDPARTS=y
> +CONFIG_CMD_UBI=y
> +CONFIG_OF_CONTROL=y
> +CONFIG_ADC=y
> +CONFIG_SARADC_MESON=y
> +CONFIG_DM_I2C=y
> +CONFIG_SYS_I2C_MESON=y
> +CONFIG_LED=y
> +CONFIG_MISC=y
> +CONFIG_MTD=y
> +CONFIG_DM_SPI_FLASH=y
> +CONFIG_PHY=y
> +CONFIG_PINCTRL=y
> +CONFIG_PINCTRL_MESON_A1=y
> +CONFIG_DM_REGULATOR=y
> +CONFIG_DM_PWM=y
> +CONFIG_PWM_MESON=y
> +CONFIG_DEBUG_UART_ANNOUNCE=y
> +CONFIG_DEBUG_UART_SKIP_INIT=y
> +CONFIG_MESON_SERIAL=y
> +CONFIG_SPI=y
> +CONFIG_DM_SPI=y
> +CONFIG_WDT=y


With MAINTAINERS file in board dir:

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>


      parent reply	other threads:[~2023-05-05  6:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230424180151.9524-1-ivprusov@sberdevices.ru>
     [not found] ` <20230424180151.9524-2-ivprusov@sberdevices.ru>
2023-05-05  6:52   ` [RFC PATCH v1 1/5] ARM: dts: Add Amlogic Meson A1 DT from Linux 6.3-rc7 Neil Armstrong
     [not found] ` <20230424180151.9524-3-ivprusov@sberdevices.ru>
2023-05-05  6:52   ` [RFC PATCH v1 2/5] ARM: dts: sync meson-a1-ad401 " Neil Armstrong
     [not found] ` <20230424180151.9524-4-ivprusov@sberdevices.ru>
2023-05-05  6:53   ` [RFC PATCH v1 3/5] ARM: meson: add A1 support Neil Armstrong
     [not found] ` <20230424180151.9524-5-ivprusov@sberdevices.ru>
2023-05-05  6:53   ` [RFC PATCH v1 4/5] pinctrl: meson: add pinctrl driver for Amlogic A1 Neil Armstrong
     [not found] ` <20230424180151.9524-6-ivprusov@sberdevices.ru>
2023-05-05  6:55   ` Neil Armstrong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=752bcedf-5792-7c43-0573-7fd4d81b54fc@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=ivprusov@sberdevices.ru \
    --cc=kernel@sberdevices.ru \
    --cc=prusovigor@gmail.com \
    --cc=u-boot-amlogic@groups.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).