From: "Neil Armstrong" <neil.armstrong@linaro.org>
To: u-boot-amlogic@groups.io, sjg@chromium.org,
Alexey Romanov <avromanov@sberdevices.ru>
Cc: narmstrong@baylibre.com, trini@konsulko.com,
u-boot@lists.denx.de, kernel@sberdevices.ru
Subject: Re: [PATCH v2 1/3] asm/arch-meson: add missing meson_sm_write_efuse signature
Date: Wed, 14 Dec 2022 15:53:11 +0100 [thread overview]
Message-ID: <6a7da2a9-3f7b-cce2-62c8-5584c6b6940a@linaro.org> (raw)
In-Reply-To: <CAPnjgZ2CEz=L=cAstFYOszMxDN8FZ3UmG2UQ-=8GY4913ogGLw@mail.gmail.com>
On 14/12/2022 05:39, Simon Glass wrote:
> Hi Alexey,
>
> On Tue, 13 Dec 2022 at 10:32, Alexey Romanov <avromanov@sberdevices.ru> wrote:
>>
>> This function can be used by other modules.
>>
>> Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
>> ---
>> arch/arm/include/asm/arch-meson/sm.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/arch-meson/sm.h b/arch/arm/include/asm/arch-meson/sm.h
>> index f3ae46a6d6b..b68edf842e4 100644
>> --- a/arch/arm/include/asm/arch-meson/sm.h
>> +++ b/arch/arm/include/asm/arch-meson/sm.h
>> @@ -8,6 +8,8 @@
>>
>> ssize_t meson_sm_read_efuse(uintptr_t offset, void *buffer, size_t size);
>>
>> +ssize_t meson_sm_write_efuse(uintptr_t offset, void *buffer, size_t size);
>> +
>> #define SM_SERIAL_SIZE 12
>>
>> int meson_sm_get_serial(void *buffer, size_t size);
>> --
>> 2.25.1
>>
>
> Should add function comments.
>
> Also, you might consider adding a uclass for this. It seems like an
> important use case that is not handled right now.
An NVMEM uclass would be a great addition, but for the scope of this
change it can be done later.
Neil
>
> Regards,
> Simon
>
>
>
>
>
next prev parent reply other threads:[~2022-12-14 14:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 18:31 [PATCH v2 0/3] arch-meson: introduce efusedump command Alexey Romanov
2022-12-13 18:31 ` [PATCH v2 1/3] asm/arch-meson: add missing meson_sm_write_efuse signature Alexey Romanov
2022-12-14 4:39 ` Simon Glass
2022-12-14 11:14 ` Alexey Romanov
2022-12-14 14:53 ` Neil Armstrong [this message]
2022-12-13 18:31 ` [PATCH v2 2/3] arm/mach-meson: move smc commands in cmd/meson Alexey Romanov
2022-12-14 10:33 ` Mattijs Korpershoek
2022-12-14 11:11 ` Alexey Romanov
2022-12-14 14:52 ` Neil Armstrong
2022-12-13 18:31 ` [PATCH v2 3/3] cmd/arm: meson: sm: introduce efusedump command Alexey Romanov
2022-12-14 4:39 ` [PATCH v2 0/3] arch-meson: " Simon Glass
2022-12-14 11:16 ` Alexey Romanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a7da2a9-3f7b-cce2-62c8-5584c6b6940a@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=avromanov@sberdevices.ru \
--cc=kernel@sberdevices.ru \
--cc=narmstrong@baylibre.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).