u-boot-amlogic.groups.io archive mirror
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, git@xilinx.com,
	"AKASHI Takahiro" <takahiro.akashi@linaro.org>,
	"Aaron Williams" <awilliams@marvell.com>,
	"Alexander Sverdlin" <alexander.sverdlin@siemens.com>,
	"Anastasiia Lukianenko" <vicooodin@gmail.com>,
	"Anatolij Gustschin" <agust@denx.de>,
	"Biju Das" <biju.das.jz@bp.renesas.com>,
	"Daniel Schwierzeck" <daniel.schwierzeck@gmail.com>,
	"Dario Binacchi" <dario.binacchi@amarulasolutions.com>,
	"Doug Zobel" <douglas.zobel@climate.com>,
	"Enrico Leto" <enrico.leto@siemens.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Gatien Chevallier" <gatien.chevallier@foss.st.com>,
	"Gregory CLEMENT" <gregory.clement@bootlin.com>,
	"Grzegorz Szymaszek" <gszymaszek@short.pl>,
	"Heiko Schocher" <hs@denx.de>,
	"Horatiu Vultur" <horatiu.vultur@microchip.com>,
	"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
	"Johan Jonker" <jbx6244@gmail.com>,
	"Kever Yang" <kever.yang@rock-chips.com>,
	"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"Lars Povlsen" <lars.povlsen@microchip.com>,
	"Leo Yu-Chi Liang" <ycliang@andestech.com>,
	"Lukasz Majewski" <lukma@denx.de>,
	"Marek Behún" <kabel@kernel.org>,
	"Marek Vasut" <marek.vasut+renesas@mailbox.org>,
	"Matthias Schiffer" <matthias.schiffer@ew.tq-group.com>,
	"Matthias Winker" <matthias.winker@de.bosch.com>,
	"Michael Trimarchi" <michael@amarulasolutions.com>,
	"Minda Chen" <minda.chen@starfivetech.com>,
	"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Nishanth Menon" <nm@ti.com>,
	"Nobuhiro Iwamatsu" <iwamatsu@nigauri.org>,
	"Oleksandr Andrushchenko" <oleksandr_andrushchenko@epam.com>,
	"Oliver Graute" <oliver.graute@kococonnector.com>,
	"Patrice Chotard" <patrice.chotard@foss.st.com>,
	"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
	"Paul Barker" <paul.barker.ct@bp.renesas.com>,
	"Paweł Jarosz" <paweljarosz3691@gmail.com>,
	"Peng Fan" <peng.fan@nxp.com>,
	"Philip Oberfichtner" <pro@denx.de>,
	"Rasmus Villemoes" <rasmus.villemoes@prevas.dk>,
	"Sean Anderson" <seanga2@gmail.com>,
	"Seung-Woo Kim" <sw0312.kim@samsung.com>,
	"Shiji Yang" <yangshiji66@outlook.com>,
	"Simon Glass" <sjg@chromium.org>,
	"Stefan Herbrechtsmeier" <stefan.herbrechtsmeier@weidmueller.com>,
	"Stefan Roese" <sr@denx.de>, "Stefano Babic" <sbabic@denx.de>,
	"Sughosh Ganu" <sughosh.ganu@linaro.org>,
	"Svyatoslav Ryhel" <clamor95@gmail.com>,
	"Viacheslav Bocharov" <adeep@lexina.in>,
	"Yanhong Wang" <yanhong.wang@starfivetech.com>,
	"open list:VIM3" <u-boot-amlogic@groups.io>,
	"moderated list:ST BOARDS"
	<uboot-stm32@st-md-mailman.stormreply.com>,
	"Michal Simek" <michal.simek@amd.com>
Subject: Re: [PATCH v2 5/5] common: Convert *.c/h from UTF-8 to ASCII enconfing
Date: Tue, 16 Apr 2024 18:19:48 +0200	[thread overview]
Message-ID: <58f122b7-e9b4-4028-941a-0f1b647ffe4e@gmx.de> (raw)
In-Reply-To: <20240416160631.GO1054907@bill-the-cat>

On 16.04.24 18:06, Tom Rini wrote:
> On Tue, Apr 16, 2024 at 08:55:19AM +0200, Michal Simek wrote:
>
>> Convert UTF-8 chars to ASCII in cases where make sense. No Copyright or
>> names are converted.
>>
>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>>
>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> Now, how did you test / find these? Given names a CI test is unlikely
> to be doable but if it's otherwise scriptable I can put it in my loops
> and just fixup as needed (like I do today for adding <common.h> for
> example).
>

There seem no to be too many non-ASCI strings outside of comments.
Should we care about non-ASCII comments?

$ find . -name '*.h' -exec grep -P -Hn "[^\x00-\x7F]" {} \; | grep -v
':\s*[\/\*']
./include/configs/tec-ng.h:13:#define CFG_TEGRA_BOARD_STRING    "Avionic
Design Tamonten™ NG Evaluation Carrier"
./arch/mips/mach-octeon/include/mach/cvmx-pko3.h:369:   MEMALG_SUB = 9,
      /* mem = mem – PKO_SEND_MEM_S[OFFSET] */

$ find . -name '*.c' -exec grep -P -Hn "[^\x00-\x7F]" {} \; | grep -v
':\s*[\/\*']
./drivers/mtd/nand/raw/nand_ids.c:65:   {"H27QCG8T2E5R‐BCF 64G 3.3V 8-bit",
./drivers/video/dw_mipi_dsi.c:861:MODULE_AUTHOR("Yannick Fertré
<yannick.fertre@st.com>");
./board/bosch/acc/acc.c:440:    .SRT = 0, // Set to 1 for temperatures
above 85°C
./cmd/2048.c:65:                                printf("   ·   ");
./cmd/2048.c:79:        printf("        ←, ↑, →, ↓ or q        \n");

Best regards

Heinrich


  reply	other threads:[~2024-04-16 17:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16  6:55 [PATCH v2 0/5] Kconfig: some cleanups Michal Simek
2024-04-16  6:55 ` [PATCH v2 5/5] common: Convert *.c/h from UTF-8 to ASCII enconfing Michal Simek
2024-04-16 10:14   ` Marek Behún
2024-04-16 16:06   ` Tom Rini
2024-04-16 16:19     ` Heinrich Schuchardt [this message]
2024-04-16 16:28       ` Tom Rini
2024-04-17  6:01       ` Michal Simek
2024-04-22 19:36 ` [PATCH v2 0/5] Kconfig: some cleanups Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58f122b7-e9b4-4028-941a-0f1b647ffe4e@gmx.de \
    --to=xypron.glpk@gmx.de \
    --cc=adeep@lexina.in \
    --cc=agust@denx.de \
    --cc=alexander.sverdlin@siemens.com \
    --cc=awilliams@marvell.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=clamor95@gmail.com \
    --cc=daniel.schwierzeck@gmail.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=douglas.zobel@climate.com \
    --cc=enrico.leto@siemens.com \
    --cc=festevam@gmail.com \
    --cc=gatien.chevallier@foss.st.com \
    --cc=git@xilinx.com \
    --cc=gregory.clement@bootlin.com \
    --cc=gszymaszek@short.pl \
    --cc=horatiu.vultur@microchip.com \
    --cc=hs@denx.de \
    --cc=ilias.apalodimas@linaro.org \
    --cc=iwamatsu@nigauri.org \
    --cc=jbx6244@gmail.com \
    --cc=kabel@kernel.org \
    --cc=kever.yang@rock-chips.com \
    --cc=lars.povlsen@microchip.com \
    --cc=lukma@denx.de \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=matthias.schiffer@ew.tq-group.com \
    --cc=matthias.winker@de.bosch.com \
    --cc=michael@amarulasolutions.com \
    --cc=michal.simek@amd.com \
    --cc=minda.chen@starfivetech.com \
    --cc=neil.armstrong@linaro.org \
    --cc=nm@ti.com \
    --cc=oleksandr_andrushchenko@epam.com \
    --cc=oliver.graute@kococonnector.com \
    --cc=patrice.chotard@foss.st.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=paul.barker.ct@bp.renesas.com \
    --cc=paweljarosz3691@gmail.com \
    --cc=peng.fan@nxp.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=pro@denx.de \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=sbabic@denx.de \
    --cc=seanga2@gmail.com \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=stefan.herbrechtsmeier@weidmueller.com \
    --cc=sughosh.ganu@linaro.org \
    --cc=sw0312.kim@samsung.com \
    --cc=takahiro.akashi@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot-amlogic@groups.io \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    --cc=uboot-stm32@st-md-mailman.stormreply.com \
    --cc=vicooodin@gmail.com \
    --cc=yangshiji66@outlook.com \
    --cc=yanhong.wang@starfivetech.com \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).