u-boot-amlogic.groups.io archive mirror
 help / color / mirror / Atom feed
From: Arseniy Krasnov <avkrasnov@salutedevices.com>
To: <neil.armstrong@linaro.org>, Tom Rini <trini@konsulko.com>
Cc: <u-boot@lists.denx.de>, <u-boot-amlogic@groups.io>,
	<kernel@sberdevices.ru>, <oxffffaa@gmail.com>
Subject: Re: [PATCH v1] arm: dts: meson-axg: add NAND controller node for AXG
Date: Fri, 26 Apr 2024 11:40:06 +0300	[thread overview]
Message-ID: <21b14ae5-1f92-6c7b-2c65-20ef3cb5820d@salutedevices.com> (raw)
In-Reply-To: <d272b0f6-2f21-4601-b347-f83eac4f12d4@linaro.org>

Hi,

On 26.04.2024 11:21, Neil Armstrong wrote:
> Hi,
> 
> On 25/04/2024 19:50, Arseniy Krasnov wrote:
>> nfc: Synced from Linux commit 7ca2ef33179f ("Linux 6.6-rc1")
>> nand_all_pins: Synced from Linux commit be18d53c32b2 ("Linux 6.7-rc3")
> 
> No need to sync DT anymore, this is handled by OF_UPSTREAM and for next release
> it's already aligned with v6.9 DT.
> 
> Please try your patches with master or next branch of U-Boot repo.

Ok, so I can remove "Synced from" from commit description, thus make it empty, and test that patch applies correctly
on uboot master/ next ?

Thanks

> 
> Neil
> 
>>
>> Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
>> ---
>>   arch/arm/dts/meson-axg.dtsi | 36 ++++++++++++++++++++++++++++++++++++
>>   1 file changed, 36 insertions(+)
>>
>> diff --git a/arch/arm/dts/meson-axg.dtsi b/arch/arm/dts/meson-axg.dtsi
>> index 3f5254eeb4..4f6fdd5523 100644
>> --- a/arch/arm/dts/meson-axg.dtsi
>> +++ b/arch/arm/dts/meson-axg.dtsi
>> @@ -430,6 +430,27 @@
>>                       };
>>                   };
>>   +                nand_all_pins: nand_all_pins {
>> +                    mux {
>> +                        groups = "emmc_nand_d0",
>> +                             "emmc_nand_d1",
>> +                             "emmc_nand_d2",
>> +                             "emmc_nand_d3",
>> +                             "emmc_nand_d4",
>> +                             "emmc_nand_d5",
>> +                             "emmc_nand_d6",
>> +                             "emmc_nand_d7",
>> +                             "nand_ce0",
>> +                             "nand_ale",
>> +                             "nand_cle",
>> +                             "nand_wen_clk",
>> +                             "nand_ren_wr";
>> +                        function = "nand";
>> +                        input-enable;
>> +                        bias-pull-up;
>> +                    };
>> +                };
>> +
>>                   emmc_ds_pins: emmc_ds {
>>                       mux {
>>                           groups = "emmc_ds";
>> @@ -1906,6 +1927,21 @@
>>                   resets = <&reset RESET_SD_EMMC_C>;
>>               };
>>   +            nfc: nand-controller@7800 {
>> +                compatible = "amlogic,meson-axg-nfc";
>> +                reg = <0x0 0x7800 0x0 0x100>,
>> +                      <0x0 0x7000 0x0 0x800>;
>> +                reg-names = "nfc", "emmc";
>> +                pinctrl-0 = <&nand_all_pins>;
>> +                pinctrl-names = "default";
>> +                #address-cells = <1>;
>> +                #size-cells = <0>;
>> +                interrupts = <GIC_SPI 34 IRQ_TYPE_EDGE_RISING>;
>> +                clocks = <&clkc CLKID_SD_EMMC_C>,
>> +                     <&clkc CLKID_FCLK_DIV2>;
>> +                clock-names = "core", "device";
>> +            };
>> +
>>               usb2_phy1: phy@9020 {
>>                   compatible = "amlogic,meson-gxl-usb2-phy";
>>                   #phy-cells = <0>;
> 


  reply	other threads:[~2024-04-26 13:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 17:50 [PATCH v1] arm: dts: meson-axg: add NAND controller node for AXG Arseniy Krasnov
2024-04-26  8:21 ` Neil Armstrong
2024-04-26  8:40   ` Arseniy Krasnov [this message]
2024-04-26  8:55     ` neil.armstrong
2024-04-26 10:38       ` Arseniy Krasnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21b14ae5-1f92-6c7b-2c65-20ef3cb5820d@salutedevices.com \
    --to=avkrasnov@salutedevices.com \
    --cc=kernel@sberdevices.ru \
    --cc=neil.armstrong@linaro.org \
    --cc=oxffffaa@gmail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot-amlogic@groups.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).