From: "Neil Armstrong" <narmstrong@baylibre.com>
To: Art Nikpal <email2tema@gmail.com>, Tom Rini <trini@konsulko.com>
Cc: Simon Glass <sjg@chromium.org>, Tom Warren <twarren@nvidia.com>,
Andre Przywara <andre.przywara@arm.com>,
U-Boot Mailing List <u-boot@lists.denx.de>,
u-boot-amlogic@groups.io,
Christian Hewitt <christianshewitt@gmail.com>,
Artem Lapkin <art@khadas.com>, Nick Xie <nick@khadas.com>,
Gouwa Wang <gouwa@khadas.com>
Subject: Re: [PATCH v2] image-board: fix wrong implementation ram disk address setup from cmdline
Date: Mon, 24 Jan 2022 10:26:21 +0100 [thread overview]
Message-ID: <1125d75f-7bba-37da-d9e0-7e562c766915@baylibre.com> (raw)
In-Reply-To: <CAKaHn9JSvM2S2DzjfdruhN56w8zf72udCdR-2QoQfKN4PHfhdg@mail.gmail.com>
Hi,
On 23/01/2022 04:32, Art Nikpal wrote:
> On Tue, Jan 18, 2022 at 3:47 AM Tom Rini <trini@konsulko.com> wrote:
>>
>> On Thu, Nov 25, 2021 at 11:08:59AM +0800, Artem Lapkin wrote:
>>
>>> Problem
>>>
>>> Wrong implementation logic: ramdisk cmdline image address always ignored!
>>> Next block { rd_addr = hextoul(select, NULL) } unusable for raw initrd.
>>>
>>> We have unbootable raw initrd images because, select_ramdisk for raw
>>> initrd images ignore submited select addr and setup rd_datap value to 0
>>>
>>> Signed-off-by: Artem Lapkin <art@khadas.com>
>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>> ---
>>> V2 changes
>>> _ rebase to master
>>> _ from https://patchwork.ozlabs.org/project/uboot/patch/20211016051915.4157293-1-art@khadas.com/
>>> ---
>>> boot/image-board.c | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/boot/image-board.c b/boot/image-board.c
>>> index bf8817165c..87a8f07432 100644
>>> --- a/boot/image-board.c
>>> +++ b/boot/image-board.c
>>> @@ -334,7 +334,7 @@ static int select_ramdisk(bootm_headers_t *images, const char *select, u8 arch,
>>>
>>> if (select) {
>>> ulong default_addr;
>>> - bool done = true;
>>> + bool done = false;
>>>
>>> if (CONFIG_IS_ENABLED(FIT)) {
>>> /*
>>> @@ -352,13 +352,13 @@ static int select_ramdisk(bootm_headers_t *images, const char *select, u8 arch,
>>> &fit_uname_config)) {
>>> debug("* ramdisk: config '%s' from image at 0x%08lx\n",
>>> fit_uname_config, rd_addr);
>>> + done = true;
>>> } else if (fit_parse_subimage(select, default_addr,
>>> &rd_addr,
>>> &fit_uname_ramdisk)) {
>>> debug("* ramdisk: subimage '%s' from image at 0x%08lx\n",
>>> fit_uname_ramdisk, rd_addr);
>>> - } else {
>>> - done = false;
>>> + done = true;
>>> }
>>> }
>>> if (!done) {
>>
>> I think we still need this? Can you please confirm and if so rebase to
>> master again, sorry, thanks!
>
> i have check master which have new commit
> 621158d106fe53fbb2d786d9d19dff44ad1baf91
>
> no need for this state !!
>
> Author: Tom Rini <trini@konsulko.com>
> Date: Mon Dec 20 09:36:32 2021 -0500
>
> Revert "image: Remove #ifdefs from select_ramdisk()"
>
> This reverts commit f33a2c1bd0fb371511a485cac1f182ba50db51be.
>
> This causes a crash on some platforms as seen here:
> https://lore.kernel.org/r/f153017b-c41a-0d32-67b9-f288e695f900@baylibre.com/
>
> Reported-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
>
> PS: about crash problem maybe its same reason may be need try apply my
> patch and no need reverts commit
> f33a2c1bd0fb371511a485cac1f182ba50db51be.
Indeed, I missed this fix completely... anyway having a functional release was the most important at that time.
Re-sending "image: Remove #ifdefs from select_ramdisk()" with this fix squashed would be the time now.
Neil
>>
>> --
>> Tom
prev parent reply other threads:[~2022-01-24 9:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 3:08 [PATCH v2] image-board: fix wrong implementation ram disk address setup from cmdline Artem Lapkin
[not found] ` <20220117194708.GA2657591@bill-the-cat>
[not found] ` <CAKaHn9JSvM2S2DzjfdruhN56w8zf72udCdR-2QoQfKN4PHfhdg@mail.gmail.com>
2022-01-24 9:26 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1125d75f-7bba-37da-d9e0-7e562c766915@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=andre.przywara@arm.com \
--cc=art@khadas.com \
--cc=christianshewitt@gmail.com \
--cc=email2tema@gmail.com \
--cc=gouwa@khadas.com \
--cc=nick@khadas.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=twarren@nvidia.com \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).