From: "Neil Armstrong" <narmstrong@baylibre.com>
To: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc: u-boot-amlogic@groups.io, u-boot@lists.denx.de
Subject: Re: [PATCH] configs: amlogic: Disable CONFIG_NET_RANDOM_ETHADDR for android
Date: Wed, 12 Jan 2022 10:03:50 +0100 [thread overview]
Message-ID: <056e759b-a2af-cbf5-ed4f-b1528e2067ea@baylibre.com> (raw)
In-Reply-To: <20220112084023.2858375-1-mkorpershoek@baylibre.com>
On 12/01/2022 09:40, Mattijs Korpershoek wrote:
> The Khadas vim3 and vim3l defconfigs introduced with:
> * f89b90d2d9 ("configs: add khadas-vim3{l}_android for AOSP support")
> * 425f06f86e ("configs: prepare khadas-vim3{l}_ab_android for AOSP support")
>
> were based on an outdated defconfig prior to the ede1f4f297 ("configs:
> amlogic: Disable CONFIG_NET_RANDOM_ETHADDR when unnecessary") cleanup.
>
> Disable CONFIG_NET_RANDOM_ETHADDR for the android configs as well to
> stay consistent.
>
> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> configs/khadas-vim3_android_ab_defconfig | 1 -
> configs/khadas-vim3_android_defconfig | 1 -
> configs/khadas-vim3l_android_ab_defconfig | 1 -
> configs/khadas-vim3l_android_defconfig | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/configs/khadas-vim3_android_ab_defconfig b/configs/khadas-vim3_android_ab_defconfig
> index 88325c37db..c5aaaf3ce7 100644
> --- a/configs/khadas-vim3_android_ab_defconfig
> +++ b/configs/khadas-vim3_android_ab_defconfig
> @@ -39,7 +39,6 @@ CONFIG_CMD_REGULATOR=y
> CONFIG_CMD_AVB=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_ADC=y
> CONFIG_SARADC_MESON=y
> CONFIG_BUTTON=y
> diff --git a/configs/khadas-vim3_android_defconfig b/configs/khadas-vim3_android_defconfig
> index 9305a54b1b..f0b2c205a7 100644
> --- a/configs/khadas-vim3_android_defconfig
> +++ b/configs/khadas-vim3_android_defconfig
> @@ -37,7 +37,6 @@ CONFIG_CMD_REGULATOR=y
> CONFIG_CMD_AVB=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_ADC=y
> CONFIG_SARADC_MESON=y
> CONFIG_BUTTON=y
> diff --git a/configs/khadas-vim3l_android_ab_defconfig b/configs/khadas-vim3l_android_ab_defconfig
> index 608b54dca2..3401c51721 100644
> --- a/configs/khadas-vim3l_android_ab_defconfig
> +++ b/configs/khadas-vim3l_android_ab_defconfig
> @@ -39,7 +39,6 @@ CONFIG_CMD_REGULATOR=y
> CONFIG_CMD_AVB=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_ADC=y
> CONFIG_SARADC_MESON=y
> CONFIG_BUTTON=y
> diff --git a/configs/khadas-vim3l_android_defconfig b/configs/khadas-vim3l_android_defconfig
> index 5eed79b263..429db2b344 100644
> --- a/configs/khadas-vim3l_android_defconfig
> +++ b/configs/khadas-vim3l_android_defconfig
> @@ -37,7 +37,6 @@ CONFIG_CMD_REGULATOR=y
> CONFIG_CMD_AVB=y
> CONFIG_OF_CONTROL=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> -CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_ADC=y
> CONFIG_SARADC_MESON=y
> CONFIG_BUTTON=y
>
Applied to u-boot-amlogic
Thanks,
Neil
prev parent reply other threads:[~2022-01-12 9:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 8:40 [PATCH] configs: amlogic: Disable CONFIG_NET_RANDOM_ETHADDR for android Mattijs Korpershoek
2022-01-12 9:03 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=056e759b-a2af-cbf5-ed4f-b1528e2067ea@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=mkorpershoek@baylibre.com \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).