From: Takashi Iwai <tiwai@suse.de>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: Tommi Rantala <tt.rantala@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Dave Jones <davej@redhat.com>,
alsa-devel@alsa-project.org, LKML <linux-kernel@vger.kernel.org>,
trinity@vger.kernel.org
Subject: Re: [alsa-devel] /proc/asound/card0/oss_mixer stack corruption
Date: Fri, 22 Aug 2014 07:23:19 +0200 [thread overview]
Message-ID: <s5h38cpumgo.wl-tiwai@suse.de> (raw)
In-Reply-To: <53F64099.8000601@ladisch.de>
At Thu, 21 Aug 2014 20:55:21 +0200,
Clemens Ladisch wrote:
>
> Tommi Rantala wrote:
> > Trinity discovered that writing 128 bytes to
> > /proc/asound/card0/oss_mixer triggers a stack corruption.
> >
> > Call Trace:
> > [<ffffffff8113c716>] __stack_chk_fail+0x16/0x20
> > [<ffffffff81e193ba>] snd_mixer_oss_proc_write+0x24a/0x270
>
> snd_info_get_line() wants the len parameter to be one less than the
> buffer size, but it isn't:
>
> while (!snd_info_get_line(buffer, line, sizeof(line))) {
>
> Not that *any* other caller got it correct either:
>
> sound/core/oss/pcm_oss.c: while (!snd_info_get_line(buffer, line, sizeof(line))) {
> sound/core/pcm.c: if (!snd_info_get_line(buffer, line, sizeof(line)))
> sound/core/pcm_memory.c: if (!snd_info_get_line(buffer, line, sizeof(line))) {
> sound/drivers/dummy.c: while (!snd_info_get_line(buffer, line, sizeof(line))) {
> sound/pci/ac97/ac97_proc.c: while (!snd_info_get_line(buffer, line, sizeof(line))) {
> sound/pci/ca0106/ca0106_proc.c: while (!snd_info_get_line(buffer, line, sizeof(line))) {
> sound/pci/ca0106/ca0106_proc.c: while (!snd_info_get_line(buffer, line, sizeof(line))) {
> sound/pci/ca0106/ca0106_proc.c: while (!snd_info_get_line(buffer, line, sizeof(line))) {
> sound/pci/emu10k1/emu10k1x.c: while (!snd_info_get_line(buffer, line, sizeof(line))) {
> sound/pci/emu10k1/emuproc.c: while (!snd_info_get_line(buffer, line, sizeof(line))) {
> sound/pci/emu10k1/emuproc.c: while (!snd_info_get_line(buffer, line, sizeof(line))) {
> sound/pci/hda/hda_eld.c: while (!snd_info_get_line(buffer, line, sizeof(line))) {
> sound/pci/ice1712/pontis.c: while (!snd_info_get_line(buffer, line, sizeof(line))) {
> sound/pci/ice1712/prodigy_hifi.c: while (!snd_info_get_line(buffer, line, sizeof(line))) {
> sound/pci/lola/lola_proc.c: while (!snd_info_get_line(buffer, line, sizeof(line))) {
> sound/pci/pcxhr/pcxhr.c: while (!snd_info_get_line(buffer, line, sizeof(line))) {
>
> Oh well. At least these proc files are writable only by root, and the
> fix is easy:
Indeed. Applied now, thanks.
Takashi
>
> --8<---------------------------------------------------------------->8--
> ALSA: core: fix buffer overflow in snd_info_get_line()
>
> snd_info_get_line() documents that its last parameter must be one
> less than the buffer size, but this API design guarantees that
> (literally) every caller gets it wrong.
>
> Just change this parameter to have its obvious meaning.
>
> Reported-by: Tommi Rantala <tt.rantala@gmail.com>
> Cc: <stable@vger.kernel.org> # v2.2.26+
> Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
> ---
> sound/core/info.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/sound/core/info.c
> +++ b/sound/core/info.c
> @@ -684,7 +684,7 @@ int snd_info_card_free(struct snd_card *card)
> * snd_info_get_line - read one line from the procfs buffer
> * @buffer: the procfs buffer
> * @line: the buffer to store
> - * @len: the max. buffer size - 1
> + * @len: the max. buffer size
> *
> * Reads one line from the buffer and stores the string.
> *
> @@ -704,7 +704,7 @@ int snd_info_get_line(struct snd_info_buffer *buffer, char *line, int len)
> buffer->stop = 1;
> if (c == '\n')
> break;
> - if (len) {
> + if (len > 1) {
> len--;
> *line++ = c;
> }
>
prev parent reply other threads:[~2014-08-22 5:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 17:45 /proc/asound/card0/oss_mixer stack corruption Tommi Rantala
2014-08-21 18:55 ` [alsa-devel] " Clemens Ladisch
2014-08-22 5:23 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h38cpumgo.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=trinity@vger.kernel.org \
--cc=tt.rantala@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).